From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from arkanian.console-pimps.org ([212.110.184.194]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VlcCD-0006NO-Q2 for kexec@lists.infradead.org; Wed, 27 Nov 2013 10:18:14 +0000 Date: Wed, 27 Nov 2013 10:17:47 +0000 From: Matt Fleming Subject: Re: [PATCH v4 07/12] efi: passing kexec necessary efi data via setup_data Message-ID: <20131127101747.GC18170@console-pimps.org> References: <1385445477-9665-1-git-send-email-dyoung@redhat.com> <1385445477-9665-8-git-send-email-dyoung@redhat.com> <20131126220448.GB18170@console-pimps.org> <20131127045237.GC11852@dhcp-16-126.nay.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20131127045237.GC11852@dhcp-16-126.nay.redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: Dave Young Cc: mjg59@srcf.ucam.org, linux-efi@vger.kernel.org, toshi.kani@hp.com, greg@kroah.com, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, James.Bottomley@HansenPartnership.com, horms@verge.net.au, bp@alien8.de, ebiederm@xmission.com, hpa@zytor.com, vgoyal@redhat.com On Wed, 27 Nov, at 12:52:37PM, Dave Young wrote: > To make it more readable, I will change them like below: > > p = efi_runtime_map; > md = efi_setup->map; > for (i = 0; i < nr_efi_runtime_map; i++) { > [...] > md += 1; > } Actually, md++ is the canonical way to write this. > > > > > + efi_map_region_fixed(md); > > > + size = md->num_pages << PAGE_SHIFT; > > > + end = md->phys_addr + size; > > > + > > > + systab = (u64) (unsigned long) efi_phys.systab; > > > + if (md->phys_addr <= systab && systab < end) { > > > + systab += md->virt_addr - md->phys_addr; > > > + efi.systab = > > > + (efi_system_table_t *) (unsigned long) systab; > > > + } > > > + if (efi_runtime_map) { > > > + memcpy(p, md, memmap.desc_size); > > > + p += memmap.desc_size; > > > + } > > > > Is this if () needed? Is it possible to enter the loop and have > > 'efi_runtime_map' be NULL? > > Yes, it is needed. if efi_runtime_map kmalloc fails I only print error, do not > return so kernel can still boot, just kexec on efi will not work that has been > put in the error message. OK. On second thought, is there any way to turn the above code into a call to efi_save_runtime_map()? Because you've basically duplicated that code and I can definitely envisage the two code paths fragmenting over time, e.g. when someone makes changes to one but not the other. -- Matt Fleming, Intel Open Source Technology Center _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec