From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from arkanian.console-pimps.org ([212.110.184.194]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VleZZ-0001fQ-V8 for kexec@lists.infradead.org; Wed, 27 Nov 2013 12:50:31 +0000 Date: Wed, 27 Nov 2013 12:50:03 +0000 From: Matt Fleming Subject: Re: [PATCH v4 00/12] kexec kernel efi runtime support Message-ID: <20131127125003.GG18170@console-pimps.org> References: <1385445477-9665-1-git-send-email-dyoung@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1385445477-9665-1-git-send-email-dyoung@redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: Dave Young Cc: mjg59@srcf.ucam.org, linux-efi@vger.kernel.org, toshi.kani@hp.com, greg@kroah.com, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, James.Bottomley@HansenPartnership.com, horms@verge.net.au, bp@alien8.de, ebiederm@xmission.com, hpa@zytor.com, vgoyal@redhat.com On Tue, 26 Nov, at 01:57:45PM, Dave Young wrote: > Hi, > > Here is the V4 resend for supporting kexec kernel efi runtime. > Per pervious discussion I pass the 1st kernel efi runtime mapping > via setup_data to 2nd kernel. Besides of the runtime mapping > info I also pass the fw_vendor, runtime, config table, smbios > physical address in setup_data. EFI spec mentioned fw_vendor, > runtime, config table addresses will be converted to virt address > after entering virtual mode, but we will use it as physical address > in efi_init. For smbios EFI spec did not mention about the address > updating, but during my test on a HP workstation, the bios will > convert it to Virt addr, thus pass it in setup_data as well. Dave, your commits introduce a bunch of new sparse warnings, /home/build/git/efi/arch/x86/platform/efi/efi.c:130:15: warning: incorrect type in assignment (different address spaces) /home/build/git/efi/arch/x86/platform/efi/efi.c:130:15: expected struct setup_data *sdata /home/build/git/efi/arch/x86/platform/efi/efi.c:130:15: got void [noderef] * /home/build/git/efi/arch/x86/platform/efi/efi.c:140:23: warning: incorrect type in argument 1 (different address spaces) /home/build/git/efi/arch/x86/platform/efi/efi.c:140:23: expected void [noderef] *addr /home/build/git/efi/arch/x86/platform/efi/efi.c:140:23: got struct setup_data *sdata /home/build/git/efi/arch/x86/platform/efi/efi.c:143:16: warning: incorrect type in assignment (different address spaces) /home/build/git/efi/arch/x86/platform/efi/efi.c:143:16: expected struct efi_setup_data *[addressable] [toplevel] esdata /home/build/git/efi/arch/x86/platform/efi/efi.c:143:16: got void [noderef] * /home/build/git/efi/arch/x86/platform/efi/efi.c:701:20: warning: incorrect type in assignment (different address spaces) /home/build/git/efi/arch/x86/platform/efi/efi.c:701:20: expected void *tablep /home/build/git/efi/arch/x86/platform/efi/efi.c:701:20: got void [noderef] * /home/build/git/efi/arch/x86/platform/efi/efi.c:722:23: warning: incorrect type in argument 1 (different address spaces) /home/build/git/efi/arch/x86/platform/efi/efi.c:722:23: expected void [noderef] *addr /home/build/git/efi/arch/x86/platform/efi/efi.c:722:23: got void *tablep /home/build/git/efi/arch/x86/platform/efi/efi.c:1079:31: warning: incorrect type in argument 1 (different address spaces) /home/build/git/efi/arch/x86/platform/efi/efi.c:1079:31: expected void [noderef] *addr /home/build/git/efi/arch/x86/platform/efi/efi.c:1079:31: got struct efi_setup_data *[addressable] [toplevel] esdata -- Matt Fleming, Intel Open Source Technology Center _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec