From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.skyhub.de ([2a01:4f8:120:8448::d00d]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vlg5q-00055z-FC for kexec@lists.infradead.org; Wed, 27 Nov 2013 14:27:55 +0000 Date: Wed, 27 Nov 2013 15:27:26 +0100 From: Borislav Petkov Subject: Re: [PATCH v4 08/12] efi: only print saved efi runtime maps instead of all memmap ranges for kexec Message-ID: <20131127142726.GE32267@pd.tnic> References: <1385445477-9665-1-git-send-email-dyoung@redhat.com> <1385445477-9665-9-git-send-email-dyoung@redhat.com> <20131127102701.GD18170@console-pimps.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20131127102701.GD18170@console-pimps.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: Matt Fleming Cc: mjg59@srcf.ucam.org, linux-efi@vger.kernel.org, toshi.kani@hp.com, greg@kroah.com, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, James.Bottomley@HansenPartnership.com, horms@verge.net.au, ebiederm@xmission.com, hpa@zytor.com, Dave Young , vgoyal@redhat.com On Wed, Nov 27, 2013 at 10:27:01AM +0000, Matt Fleming wrote: > Heh, you can probably already guess what I'm going to say here... I guessed :-) > How about using a single function to dump the memory ranges irrespective > of whether the memory map comes from 'memmap' or 'esdata'? e.g. > something along the lines of, > > if (esdata) > print_efi_memmap(esdata->map, nr_efi_runtime_map, > sizeof(esdata->map[0])); > else > print_efi_memmap(memmap.map, memmap.nr_map, > memmap.desc_size); And while you're at it: WARNING: quoted string split across lines #19: FILE: arch/x86/platform/efi/efi.c:443: + pr_info("mem%02u: type=%u, attr=0x%llx, " + "range=[0x%016llx-0x%016llx) (%lluMB)\n", Btw, do we really want to dump the same map again in the second kernel? -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec