From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VnVSi-00005H-4Q for kexec@lists.infradead.org; Mon, 02 Dec 2013 15:31:04 +0000 Date: Mon, 2 Dec 2013 10:30:37 -0500 From: Vivek Goyal Subject: Re: [PATCH 6/6] kexec: Support for Kexec on panic using new system call Message-ID: <20131202153037.GD18642@redhat.com> References: <1384969851-7251-1-git-send-email-vgoyal@redhat.com> <1384969851-7251-7-git-send-email-vgoyal@redhat.com> <20131128112816.GC4318@dhcp-16-252.nay.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20131128112816.GC4318@dhcp-16-252.nay.redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: Baoquan He Cc: mjg59@srcf.ucam.org, greg@kroah.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, ebiederm@xmission.com, hpa@zytor.com On Thu, Nov 28, 2013 at 07:28:16PM +0800, Baoquan He wrote: [..] > > +int crash_copy_backup_region(struct kimage *image) > > +{ > > Why need this func be called, backup region has been added into crash > segment by kexec_add_buffer, and then buffer copy is done in > kimage_load_crash_segment. I think this copy is handled twice. Please > correct me if I am wrong. > Hi Bao, kexec_add_buffer() will copy the backup region but it will happen when crash kernel is loaded. We want snapshot of backup region at the time of crash and that's why this second call to copy backup region and it is executed after the crash. Thanks Vivek _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec