From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.skyhub.de ([2a01:4f8:120:8448::d00d]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VrDRd-0001hc-Hs for kexec@lists.infradead.org; Thu, 12 Dec 2013 21:05:19 +0000 Date: Thu, 12 Dec 2013 22:04:39 +0100 From: Borislav Petkov Subject: Re: [PATCH v5 09/14] efi: passing kexec necessary efi data via setup_data Message-ID: <20131212210439.GB30162@pd.tnic> References: <1386582147-9802-1-git-send-email-dyoung@redhat.com> <1386582147-9802-10-git-send-email-dyoung@redhat.com> <20131211222057.GB8863@pd.tnic> <20131212030619.GG3751@dhcp-16-126.nay.redhat.com> <20131212071743.GJ3751@dhcp-16-126.nay.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20131212071743.GJ3751@dhcp-16-126.nay.redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: Dave Young Cc: mjg59@srcf.ucam.org, linux-efi@vger.kernel.org, toshi.kani@hp.com, matt@console-pimps.org, greg@kroah.com, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, James.Bottomley@HansenPartnership.com, horms@verge.net.au, ebiederm@xmission.com, hpa@zytor.com, vgoyal@redhat.com On Thu, Dec 12, 2013 at 03:17:43PM +0800, Dave Young wrote: > Rethink about this issue, moving them to efi_$(BITS).c I need move the > efi_setup from a static variable to an extern, It looks not worth. Dave, would you please do what is suggested to you? A big part of the efi code is split into 32-bit and 64-bit functionality. If you have a serious argument why it shouldn't be done so then sure, by all means, but stop coming up with silly arguments like having an extern declaration is a bad thing. Please. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec