Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: WANG Chao <chaowang@redhat.com>
Cc: kexec@lists.infradead.org, Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [PATCH] vmcore-dmesg: struct_val_u64() not casting u64 to u32
Date: Mon, 13 Jan 2014 17:43:30 +0900	[thread overview]
Message-ID: <20140113084329.GB29308@verge.net.au> (raw)
In-Reply-To: <20140113052944.GG9622@dhcp-17-89.nay.redhat.com>

On Mon, Jan 13, 2014 at 01:29:44PM +0800, WANG Chao wrote:
> On 01/06/14 at 02:14pm, Vivek Goyal wrote:
> > On Tue, Jan 07, 2014 at 01:37:34AM +0800, WANG Chao wrote:
> > > It seems gcc doesn't check return type from inline function.
> > > struct_val_u64() should return u64 otherwise upper 32bit is lost.
> > > 
> > > Signed-off-by: WANG Chao <chaowang@redhat.com>
> > 
> > Acked-by: Vivek Goyal <vgoyal@redhat.com>
> > 
> > Vivek
> 
> Hi, Simon
> 
> Could you please pick up this one?

Done, thanks.

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

      reply	other threads:[~2014-01-13  8:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-06 17:37 [PATCH] vmcore-dmesg: struct_val_u64() not casting u64 to u32 WANG Chao
2014-01-06 19:14 ` Vivek Goyal
2014-01-13  5:29   ` WANG Chao
2014-01-13  8:43     ` Simon Horman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140113084329.GB29308@verge.net.au \
    --to=horms@verge.net.au \
    --cc=chaowang@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox