From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from baikonur.stro.at ([88.198.36.42]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1W3QoF-0007pD-GS for kexec@lists.infradead.org; Wed, 15 Jan 2014 13:47:08 +0000 Date: Wed, 15 Jan 2014 14:38:38 +0100 From: Maximilian Attems Subject: Re: [PATCH] kexec.h: stop exporting kexec_load() to userspace Message-ID: <20140115133838.GD8101@stro.at> References: <1389791824.17407.9.camel@x220> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1389791824.17407.9.camel@x220> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: Paul Bolle , "H. Peter Anvin" Cc: kexec@lists.infradead.org, Andrew Morton , Linus Torvalds , Eric Biederman , linux-kernel@vger.kernel.org On Wed, Jan 15, 2014 at 02:17:04PM +0100, Paul Bolle wrote: > Since v3.5 kexec.h is exported to userspace. That includes its > declaration of kexec_load(): > extern int kexec_load(void *, size_t, struct kexec_segment *, > unsigned long int); > > This declaration isn't very useful to userspace programs on itself. They > still have to define a matching function (which basically wraps the > kexec_load syscall). I'm not aware of programs or libraries that actually > do that. > > It can be removed. The programs that actually use it, if there > are any, should then provide their own declaration to keep compiling. > Already compiled binaries will not be affected. nack, klibc uses the header and there was some discussion that glibc could/should use it too. I didn't follow kexec git, but there is/was a version that just uses the kexec_load() if the c library provides it. Until Santa Claus materialises in form of a direct kernel user-space API, see follow ups on http://lwn.net/Articles/534682/ and proposal by hpa > This gets rid of the headers_check warning that can be seen ever since > this header was exported: > [...]/usr/include/linux/kexec.h:49: userspace cannot reference function or variable defined in the kernel > this is the wrong way of fix. -- maks _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec