From: Dave Young <dyoung@redhat.com>
To: Wang Nan <wangnan0@huawei.com>
Cc: Simon Horman <horms@verge.net.au>,
kexec@lists.infradead.org, Geng Hui <hui.geng@huawei.com>
Subject: Re: [PATCH 3/3] kexec: increase zImage compression ratio from 4 to 5
Date: Thu, 6 Feb 2014 12:01:32 +0800 [thread overview]
Message-ID: <20140206040132.GC3943@dhcp-16-126.nay.redhat.com> (raw)
In-Reply-To: <1390387924-73946-4-git-send-email-wangnan0@huawei.com>
On 01/22/14 at 06:52pm, Wang Nan wrote:
> Old code assume the zImage compression ration is 4, it is not enough, 5 shall be
> better.
4 works well during my test. Do you have real test case to reproduce this problem?
>
> Signed-off-by: Wang Nan <wangnan0@huawei.com>
> Cc: Simon Horman <horms@verge.net.au>
> Cc: Dave Young <dyoung@redhat.com>
> Cc: Geng Hui <hui.geng@huawei.com>
> ---
> kexec/arch/arm/kexec-zImage-arm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kexec/arch/arm/kexec-zImage-arm.c b/kexec/arch/arm/kexec-zImage-arm.c
> index 6d6b239..6e5e12b 100644
> --- a/kexec/arch/arm/kexec-zImage-arm.c
> +++ b/kexec/arch/arm/kexec-zImage-arm.c
> @@ -351,7 +351,7 @@ int zImage_arm_load(int argc, char **argv, const char *buf, off_t len,
> } else {
> /* Otherwise, assume the maximum kernel compression ratio
> * is 4, and just to be safe, place ramdisk after that */
> - initrd_base = base + _ALIGN(len * 4, 4096);
> + initrd_base = base + _ALIGN(len * 5, 4096);
> }
>
> if (use_atags) {
> --
> 1.8.4
>
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2014-02-06 4:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-22 10:52 [PATCH 0/3] kexec-tools: fix bugs and pass initrd position for arm Wang Nan
2014-01-22 10:52 ` [PATCH 1/3] kexec: align initrd when no --image-size Wang Nan
2014-02-06 3:44 ` Dave Young
2014-01-22 10:52 ` [PATCH 2/3] kexec: pass initrd position in dtb Wang Nan
2014-02-06 3:58 ` Dave Young
2014-01-22 10:52 ` [PATCH 3/3] kexec: increase zImage compression ratio from 4 to 5 Wang Nan
2014-02-06 4:01 ` Dave Young [this message]
2014-01-23 2:02 ` [PATCH 0/3] kexec-tools: fix bugs and pass initrd position for arm Dave Young
2014-01-23 2:47 ` Dave Young
2014-01-23 2:56 ` Wang Nan
2014-01-23 3:38 ` Dave Young
2014-01-23 4:17 ` Wang Nan
2014-01-23 5:00 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140206040132.GC3943@dhcp-16-126.nay.redhat.com \
--to=dyoung@redhat.com \
--cc=horms@verge.net.au \
--cc=hui.geng@huawei.com \
--cc=kexec@lists.infradead.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox