Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: WANG Chao <chaowang@redhat.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: kexec@lists.infradead.org, horms@verge.net.au,
	ebiederm@xmission.com, hpa@zytor.com, dyoung@redhat.com,
	trenn@suse.de
Subject: Re: [PATCH 1/4] add macro dbgprint_mem_range
Date: Fri, 14 Feb 2014 14:31:58 +0800	[thread overview]
Message-ID: <20140214063158.GD18964@dhcp-17-89.nay.redhat.com> (raw)
In-Reply-To: <20140213203505.GK30844@redhat.com>

On 02/13/14 at 03:35pm, Vivek Goyal wrote:
> On Thu, Feb 13, 2014 at 09:10:52PM +0800, WANG Chao wrote:
> 
> [..]
> > diff --git a/kexec/kexec.h b/kexec/kexec.h
> > index 2bd6e96..753acc5 100644
> > --- a/kexec/kexec.h
> > +++ b/kexec/kexec.h
> > @@ -121,6 +121,16 @@ do { \
> >  		fprintf(stderr, __VA_ARGS__); \
> >  } while(0)
> >  
> > +#define dbgprint_mem_range(prefix, mr, nr_mr) \
> > +do { \
> > +	int i; \
> > +	dbgprintf(prefix "\n"); \
> > +	for (i = 0; i < nr_mr; i++) { \
> > +		dbgprintf("%016llx-%016llx (%d)\n", (mr)[i].start, \
> > +			  (mr)[i].end, (mr)[i].type);                \
> > +	} \
> > +} while (0)
> > +
> 
> Can we make it a function instead of macro? 

Sure. Will put it in kexec.c

Thanks
WANG Chao

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2014-02-14  6:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-13 13:10 [PATCH 0/4] kexec-tools, x86: E820 memmap pass for kdump WANG Chao
2014-02-13 13:10 ` [PATCH 1/4] add macro dbgprint_mem_range WANG Chao
2014-02-13 20:35   ` Vivek Goyal
2014-02-14  6:31     ` WANG Chao [this message]
2014-02-13 13:10 ` [PATCH 2/4] x86: Store memory ranges globally used for crash kernel to boot into WANG Chao
2014-02-13 21:46   ` Vivek Goyal
2014-02-14  6:30     ` WANG Chao
2014-02-13 13:10 ` [PATCH 3/4] x86: add --pass-memmap-cmdline option WANG Chao
2014-02-13 13:10 ` [PATCH] x86: Pass memory range via E820 for kdump WANG Chao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140214063158.GD18964@dhcp-17-89.nay.redhat.com \
    --to=chaowang@redhat.com \
    --cc=dyoung@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=horms@verge.net.au \
    --cc=hpa@zytor.com \
    --cc=kexec@lists.infradead.org \
    --cc=trenn@suse.de \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox