From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from ernst.netinsight.se ([194.16.221.21]) by merlin.infradead.org with smtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WNGdU-0001kQ-6p for kexec@lists.infradead.org; Tue, 11 Mar 2014 06:58:01 +0000 Date: Tue, 11 Mar 2014 07:57:30 +0100 From: Simon =?UTF-8?B?S8OlZ3N0csO2bQ==?= Subject: Re: [PATCH v2 2/4] build: Use INCLUDES for normal CFLAGS in addition to CFLAGS_ARCH Message-ID: <20140311075730.358bc01f@marrow.netinsight.se> In-Reply-To: <0910DD04CBD6DE4193FCF86B9C00BE971F41D3@BPXM01GP.gisp.nec.co.jp> References: <20140307093626.09701790@marrow.netinsight.se> <20140307093840.72e71fbe@marrow.netinsight.se> <0910DD04CBD6DE4193FCF86B9C00BE971F41D3@BPXM01GP.gisp.nec.co.jp> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: Atsushi Kumagai Cc: "kexec@lists.infradead.org" On Mon, 10 Mar 2014 05:26:34 +0000 Atsushi Kumagai wrote: > >-CFLAGS = -g -O2 -Wall -D_FILE_OFFSET_BITS=64 \ > >+CFLAGS = $(INCLUDES) -g -O2 -Wall -D_FILE_OFFSET_BITS=64 \ > > -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE \ > > -DVERSION='"$(VERSION)"' -DRELEASE_DATE='"$(DATE)"' > > CFLAGS_ARCH = $(INCLUDES) -g -O2 -Wall -D_FILE_OFFSET_BITS=64 \ > ^^^^^^^^^^^ > CFLAGS_ARCH also doesn't use INCLUDES in the upstream version, > so this diff and the subject of this patch are wrong. Sorry about that! I merged in the new version, but apparently we had some local modifications to the Makefile. So please drop this patch in the series. // Simon _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec