From: Petr Tesarik <ptesarik@suse.cz>
To: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>
Cc: kexec@lists.infradead.org, kumagai-atsushi@mxc.nes.nec.co.jp
Subject: Re: [PATCH v2 2/3] Generic handling of multi-page exclusions
Date: Tue, 8 Apr 2014 12:07:28 +0200 [thread overview]
Message-ID: <20140408120728.03224214@hananiah.suse.cz> (raw)
In-Reply-To: <20140408.171903.322808733.d.hatayama@jp.fujitsu.com>
On Tue, 08 Apr 2014 17:19:03 +0900 (JST)
HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com> wrote:
> From: Petr Tesarik <ptesarik@suse.cz>
> Subject: Re: [PATCH v2 2/3] Generic handling of multi-page exclusions
> Date: Tue, 8 Apr 2014 08:54:36 +0200
>
> > On Tue, 08 Apr 2014 10:49:07 +0900 (JST)
> > HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com> wrote:
> >>
> >> Also, it seems to me better to introduce a new type for this
> >> processing rather than extending existing code. struct mem_map_data is
> >> not specific for the excluding processing.
> >
> > Kind of agreed. OTOH it will most likely be embedded in struct
> > mem_map_data anyway, because exactly one such object per mm is needed.
> >
> > Petr T
>
> I don't understand well. It seems to me a single object is enough. Is
> it possible to nr_pages cover multiple mm's?
In fact, I believe it may be sufficient, but the loop nesting is like
this (pseudo-code):
for each cycle:
for each mm:
call __exclude_unnecessary_pages
I'm not 100% sure that the region cannot change back and forth between
two consecutive calls to __exclude_unnecessary_pages.
Thinking about it some more, this can be harmful only if there are
overlapping memory maps... Can it happen, or can I safely ignore this
possibility?
Petr T
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2014-04-08 10:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 17:25 [PATCH v2 0/3] Generic multi-page exclusion Petr Tesarik
2014-04-04 17:25 ` [PATCH v2 1/3] Pass mmd pointer to __exclude_unnecessary_pages Petr Tesarik
2014-04-04 17:25 ` [PATCH v2 2/3] Generic handling of multi-page exclusions Petr Tesarik
2014-04-08 1:49 ` HATAYAMA Daisuke
2014-04-08 6:54 ` Petr Tesarik
2014-04-08 8:19 ` HATAYAMA Daisuke
2014-04-08 9:00 ` Atsushi Kumagai
2014-04-09 7:27 ` HATAYAMA Daisuke
2014-04-15 4:18 ` Atsushi Kumagai
2014-04-15 8:27 ` HATAYAMA Daisuke
2014-04-15 10:06 ` Atsushi Kumagai
2014-04-08 10:07 ` Petr Tesarik [this message]
2014-04-09 7:12 ` HATAYAMA Daisuke
2014-04-08 7:06 ` Atsushi Kumagai
2014-04-10 10:47 ` Petr Tesarik
2014-04-11 1:59 ` HATAYAMA Daisuke
2014-04-15 1:20 ` Atsushi Kumagai
2014-04-15 6:23 ` Petr Tesarik
2014-04-15 8:09 ` HATAYAMA Daisuke
2014-04-04 17:25 ` [PATCH v2 3/3] Get rid of overrun adjustments Petr Tesarik
2014-04-08 7:02 ` [PATCH v2 0/3] Generic multi-page exclusion Atsushi Kumagai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140408120728.03224214@hananiah.suse.cz \
--to=ptesarik@suse.cz \
--cc=d.hatayama@jp.fujitsu.com \
--cc=kexec@lists.infradead.org \
--cc=kumagai-atsushi@mxc.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox