From: Simon Horman <horms@verge.net.au>
To: Nikita Yushchenko <nyushchenko@dev.rtsoft.ru>
Cc: yadviga@dev.rtsoft.ru, lugovskoy@dev.rtsoft.ru,
kexec@lists.infradead.org
Subject: Re: [PATCH] kexec/ppc: cleanup crash regions creation
Date: Thu, 10 Apr 2014 08:22:54 +0900 [thread overview]
Message-ID: <20140409232254.GE2187@verge.net.au> (raw)
In-Reply-To: <532C1B71.2080406@dev.rtsoft.ru>
On Fri, Mar 21, 2014 at 02:58:57PM +0400, Nikita Yushchenko wrote:
> > Move filling crash_memory_range table entries into a separate routine,
> > which saves quite a few lines of code.
> >
> > In this routine, if range spawns over lowmem-highmem border, split range
> > into two. This is needed to get proper virtual address for lowmem part.
> > Similar thing is already done for x86. Credits to Yadviga Grigorieva
> > <yadviga@dev.rtsoft.ru> for tracking down this issue for ppc.
> >
> > Also this patch makes excluding crash kernel region a bit shorter, and
> > removes unused variable to get rid of compiler warning.
> >
> > Signed-off-by: Nikita Yushchenko <nyushchenko@dev.rtsoft.ru>
> > ---
> > kexec/arch/ppc/crashdump-powerpc.c | 108 +++++++++++++++++-------------------
> > 1 files changed, 51 insertions(+), 57 deletions(-)
>
> Hi
>
> Any followup on this?
>
> Without this patch, vmcore files extracted with kdump is not very useful with gdb:
Apologies for the delay, I have applied this patch.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
prev parent reply other threads:[~2014-04-09 23:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 7:40 [PATCH] kexec/ppc: cleanup crash regions creation Nikita Yushchenko
2014-03-21 10:58 ` Nikita Yushchenko
2014-04-09 23:22 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140409232254.GE2187@verge.net.au \
--to=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=lugovskoy@dev.rtsoft.ru \
--cc=nyushchenko@dev.rtsoft.ru \
--cc=yadviga@dev.rtsoft.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox