Re: [PATCH 2/3] ARM : kdump : add arch_crash_save_vmcoreinfo

Will Deacon
2014-04-14T11:37:18Z

On Thu, Mar 27, 2014 at 08:00:39AM +0000, Liu Hua wrote:
> For vmcore generated by LPAE enabled kernel, user space
> utility such as crash needs additional infomation to
> parse.
>
> So this patch add arch_crash_save_vmcoreinfo as what PAE enabled
> i386 linux does.

Looks sensible to me:

Reviewed-by: Will Deacon <will.deacon@arm.com>

Will

> Signed-off-by: Liu Hua <sdu.liu@huawei.com>
> To: Russell King <linux@arm.linux.org.uk>
> Cc: Stephen Warren <swarren@nvidia.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Vijaya Kumar K <vijay.kilari@gmail.com>
> Cc: <linux-arm-kernel@lists.infradead.org>
> Cc: <linux-kernel@vger.kernel.org>
> Cc: <kexec@lists.infradead.org>
> ---
> arch/arm/kernel/machine_kexec.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/kernel/machine_kexec.c b/arch/arm/kernel/machine_kexec.c
> index f0d180d..8cf0996 100644
> --- a/arch/arm/kernel/machine_kexec.c
> +++ b/arch/arm/kernel/machine_kexec.c
> @@ -184,3 +184,10 @@ void machine_kexec(struct kimage *image)
>
> soft_restart(reboot_entry_phys);
> }
> +
> +void arch_crash_save_vmcoreinfo(void)
> +{
> +#ifdef CONFIG_ARM_LPAE
> + VMCOREINFO_CONFIG(ARM_LPAE);
> +#endif
> +}
> --
> 1.9.0
>
>