Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Young <dyoung@redhat.com>
To: Prarit Bhargava <prarit@redhat.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
	isimatu.yasuaki@jp.fujitsu.com, Andi Kleen <ak@linux.intel.com>,
	linux-doc@vger.kernel.org, linux-api@vger.kernel.org,
	Rusty Russell <rusty@rustcorp.com.au>,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	Fabian Frederick <fabf@skynet.be>,
	Jason Baron <jbaron@akamai.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	vgoyal@redhat.com
Subject: Re: [PATCH V4] kernel, add bug_on_warn
Date: Tue, 28 Oct 2014 10:32:51 +0800	[thread overview]
Message-ID: <20141028023251.GD3329@darkstar.nay.redhat.com> (raw)
In-Reply-To: <544E8BB8.8000707@redhat.com>

> > Seems reasonable-I'm wondering why you just don't call panic() in this
> > case. The BUG() call at line '434' doesn't at anything since its just being
> > called from panic.c.
> 
> Hmm ... I didn't even think about that.
> 
> > 
> > So something like 'panic_on_warn' would seem to be more appropriate
> > in keeping with things like 'panic_on_oops' or 'panic_on_stackoverflow'.
> 
> I like it a lot better that way too :)  I'm changing it to panic_on_warn unless
> anyone has any strenuous objections.

I would vote for panic_on_warn, it will make more sense than bug_on_warn.

Thanks
Dave

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2014-10-28  2:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-24 12:53 [PATCH V4] kernel, add bug_on_warn Prarit Bhargava
2014-10-27 18:05 ` Jason Baron
2014-10-27 18:15   ` Prarit Bhargava
2014-10-28  2:32     ` Dave Young [this message]
2014-10-28  5:41     ` Masami Hiramatsu
2014-10-28  0:00 ` Yasuaki Ishimatsu
2014-10-28 12:16 ` Andi Kleen
2014-10-28 12:22   ` Prarit Bhargava
2014-10-28 12:29     ` Vivek Goyal
2014-10-28 12:44       ` Andi Kleen
2014-10-28 12:48         ` Prarit Bhargava
2014-10-28 12:56           ` Andi Kleen
2014-10-28 13:19             ` Prarit Bhargava
2014-10-28 12:55         ` Vivek Goyal
2014-10-28 12:59           ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141028023251.GD3329@darkstar.nay.redhat.com \
    --to=dyoung@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=corbet@lwn.net \
    --cc=fabf@skynet.be \
    --cc=hpa@zytor.com \
    --cc=isimatu.yasuaki@jp.fujitsu.com \
    --cc=jbaron@akamai.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=prarit@redhat.com \
    --cc=rusty@rustcorp.com.au \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox