From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <kexec-bounces+dwmw2=infradead.org@lists.infradead.org>
Received: from mga11.intel.com ([192.55.52.93])
 by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux))
 id 1Xj68k-0007Vd-Ny
 for kexec@lists.infradead.org; Tue, 28 Oct 2014 12:44:47 +0000
Date: Tue, 28 Oct 2014 05:44:25 -0700
From: Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH V4] kernel, add bug_on_warn
Message-ID: <20141028124425.GD3274@tassilo.jf.intel.com>
References: <1414155207-29839-1-git-send-email-prarit@redhat.com>
 <20141028121636.GC3274@tassilo.jf.intel.com>
 <544F8A78.9070008@redhat.com> <20141028122900.GA10632@redhat.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20141028122900.GA10632@redhat.com>
List-Id: <kexec.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/kexec>,
 <mailto:kexec-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/kexec/>
List-Post: <mailto:kexec@lists.infradead.org>
List-Help: <mailto:kexec-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/kexec>,
 <mailto:kexec-request@lists.infradead.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "kexec" <kexec-bounces@lists.infradead.org>
Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org
To: Vivek Goyal <vgoyal@redhat.com>
Cc: Prarit Bhargava <prarit@redhat.com>, Jonathan Corbet <corbet@lwn.net>, kexec@lists.infradead.org, Rusty Russell <rusty@rustcorp.com.au>, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Fabian Frederick <fabf@skynet.be>, isimatu.yasuaki@jp.fujitsu.com, "H. Peter Anvin" <hpa@zytor.com>, Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>, Andrew Morton <akpm@linux-foundation.org>, linux-api@vger.kernel.org, jason.wessel@windriver.com

> > I suppose ... but that would mean I would have to explain to an end user the
> > elaborate process of enabling kdb, inserting a break point, etc.  The whole
> > purpose of this is to let an end user panic on WARN() easily.
> > 
> > Asking an end user to enable kdb is magnitudes worse than asking them to
> > recompile a kernel.
> 
> Agreed. Asking a customer to setup and run kdb and put breakpoints is much
> more pain than simply asking to reboot kernel with a command line option.

If you have a command line option to execute kdb commands you still
would only have a command line option, just a slightly longer one.

kdb="on, bp warn_slowpath_common sr c, go" 

But it would be a generic facility instead of a special purpose hack.

-Andi


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec