From: Simon Horman <horms@verge.net.au>
To: HuKeping <hukeping@huawei.com>
Cc: kexec@lists.infradead.org, peifeiyue@huawei.com, sdu.liu@huawei.com
Subject: Re: [PATCH] kexec: remove some re zero-assignment
Date: Tue, 2 Dec 2014 10:50:57 +0900 [thread overview]
Message-ID: <20141202015057.GE20072@verge.net.au> (raw)
In-Reply-To: <1417221932-75098-1-git-send-email-hukeping@huawei.com>
On Sat, Nov 29, 2014 at 08:45:32AM +0800, HuKeping wrote:
> since we have already cleared kexec_info with memset,
> there is no need to do that again to the struct members.
>
> Signed-off-by: Hu Keping <hukeping@huawei.com>
Thanks, applied.
> ---
> kexec/kexec.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/kexec/kexec.c b/kexec/kexec.c
> index a5e78c6..b088916 100644
> --- a/kexec/kexec.c
> +++ b/kexec/kexec.c
> @@ -662,10 +662,6 @@ static int my_load(const char *type, int fileind, int argc, char **argv,
> int guess_only = 0;
>
> memset(&info, 0, sizeof(info));
> - info.segment = NULL;
> - info.nr_segments = 0;
> - info.entry = NULL;
> - info.backup_start = 0;
> info.kexec_flags = kexec_flags;
>
> result = 0;
> --
> 1.8.5.5
>
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
prev parent reply other threads:[~2014-12-02 1:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-29 0:45 [PATCH] kexec: remove some re zero-assignment HuKeping
2014-12-02 1:50 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141202015057.GE20072@verge.net.au \
--to=horms@verge.net.au \
--cc=hukeping@huawei.com \
--cc=kexec@lists.infradead.org \
--cc=peifeiyue@huawei.com \
--cc=sdu.liu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox