From: Simon Horman <horms@verge.net.au>
To: Kevin Hao <kexin.hao@windriver.com>
Cc: kexec@lists.infradead.org
Subject: Re: [PATCH] purgatory: Disabling GCC's stack protection
Date: Thu, 30 Apr 2015 14:08:09 +0900 [thread overview]
Message-ID: <20150430050809.GI15511@verge.net.au> (raw)
In-Reply-To: <20150430043950.GD15511@verge.net.au>
On Thu, Apr 30, 2015 at 01:39:50PM +0900, Simon Horman wrote:
> Hi Kevin,
>
> On Tue, Apr 28, 2015 at 08:50:19PM +0800, Kevin Hao wrote:
> > If the GCC's stack protection is enabled by default, the purgatory will
> > also be built with this option. But it makes no sense to enable this
> > for the purgatory code, and would cause error when we are trying to
> > relocate the purgatory codes because symbol like __stack_chk_fail is
> > unresolved. Instead of disabling this for some archs specifically,
> > disable it for all the archs.
> >
> > Signed-off-by: Kevin Hao <kexin.hao@windriver.com>
>
> This seems like a reasonable change to me, however, it does
> not apply cleanly to the kexec tree on kernel.org which I maintain.
>
> https://git.kernel.org/pub/scm/utils/kernel/kexec/kexec-tools.git
>
> Could you rebase and repost?
I have now realised that Mike Frysinger has posted a similar,
slightly more comprehensive, patch which I have now applied.
Could you see if it addresses the problem you are seeing?
It is the following commit in the above tree:
4a837c9a19f9 purgatory: force PIC/PIE/SSP off
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2015-04-30 5:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 12:50 [PATCH] purgatory: Disabling GCC's stack protection Kevin Hao
2015-04-30 4:39 ` Simon Horman
2015-04-30 5:08 ` Simon Horman [this message]
2015-04-30 5:21 ` Kevin Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150430050809.GI15511@verge.net.au \
--to=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=kexin.hao@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox