From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZJiiQ-0002on-OO for kexec@lists.infradead.org; Mon, 27 Jul 2015 13:45:15 +0000 Date: Mon, 27 Jul 2015 09:44:53 -0400 From: Vivek Goyal Subject: Re: [PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic Message-ID: <20150727134453.GA16064@redhat.com> References: <1433571252-11874-1-git-send-email-mhuang@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1433571252-11874-1-git-send-email-mhuang@redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Minfei Huang Cc: Minfei Huang , kexec@lists.infradead.org, ebiederm@xmission.com, linux-kernel@vger.kernel.org On Sat, Jun 06, 2015 at 02:14:12PM +0800, Minfei Huang wrote: > From: Minfei Huang > > Transforming PFN(Page Frame Number) to struct page is never failure, so > we can simplify the code logic to do the image->control_page assignment > directly in the loop, and remove the unnecessary conditional judgement. > > Signed-off-by: Minfei Huang Looks good to me. Acked-by: Vivek Goyal Thanks Vivek > --- > kernel/kexec.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/kernel/kexec.c b/kernel/kexec.c > index 7a36fdc..4589899 100644 > --- a/kernel/kexec.c > +++ b/kernel/kexec.c > @@ -796,11 +796,10 @@ static struct page *kimage_alloc_crash_control_pages(struct kimage *image, > /* If I don't overlap any segments I have found my hole! */ > if (i == image->nr_segments) { > pages = pfn_to_page(hole_start >> PAGE_SHIFT); > + image->control_page = hole_end; > break; > } > } > - if (pages) > - image->control_page = hole_end; > > return pages; > } > -- > 2.2.2 _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec