Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Minfei Huang <mnfhuang@gmail.com>
To: Simon Horman <horms@verge.net.au>
Cc: Minfei Huang <mhuang@redhat.com>,
	kexec@lists.infradead.org, ebiederm@xmission.com,
	Vivek Goyal <vgoyal@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic
Date: Tue, 28 Jul 2015 12:42:08 +0800	[thread overview]
Message-ID: <20150728044208.GA32290@t440s.lenovo> (raw)
In-Reply-To: <20150728043019.GC25714@verge.net.au>

On 07/28/15 at 01:30pm, Simon Horman wrote:
> On Mon, Jul 27, 2015 at 09:44:53AM -0400, Vivek Goyal wrote:
> > On Sat, Jun 06, 2015 at 02:14:12PM +0800, Minfei Huang wrote:
> > > From: Minfei Huang <mnfhuang@gmail.com>
> > > 
> > > Transforming PFN(Page Frame Number) to struct page is never failure, so
> > > we can simplify the code logic to do the image->control_page assignment
> > > directly in the loop, and remove the unnecessary conditional judgement.
> > > 
> > > Signed-off-by: Minfei Huang <mnfhuang@gmail.com>
> > 
> > Looks good to me.
> > 
> > Acked-by: Vivek Goyal <vgoyal@redhat.com>
> 
> FWIW, this probably needs to be reposted to Andrew Morton with appropriate
> Acks and CCs in order to proceed into his tree and then Linus's.

Thanks.

I will repost it to Andrew Morton.

Thanks
Minfei

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

      reply	other threads:[~2015-07-28  4:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-06  6:14 [PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic Minfei Huang
2015-06-15  9:28 ` Dave Young
2015-07-25  9:11   ` Minfei Huang
2015-07-27 13:44 ` Vivek Goyal
2015-07-28  4:30   ` Simon Horman
2015-07-28  4:42     ` Minfei Huang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150728044208.GA32290@t440s.lenovo \
    --to=mnfhuang@gmail.com \
    --cc=ebiederm@xmission.com \
    --cc=horms@verge.net.au \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhuang@redhat.com \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox