From: Simon Horman <horms@verge.net.au>
To: Baoquan He <bhe@redhat.com>
Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
Minfei Huang <mnfhuang@gmail.com>,
akpm@linux-foundation.org, vgoyal@redhat.com,
ebiederm@xmission.com
Subject: Re: [REPOST PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic
Date: Thu, 13 Aug 2015 16:57:32 +0900 [thread overview]
Message-ID: <20150813075730.GA4325@verge.net.au> (raw)
In-Reply-To: <20150813055345.GC26247@dhcp-128-28.nay.redhat.com>
On Thu, Aug 13, 2015 at 01:53:45PM +0800, Baoquan He wrote:
> On 08/13/15 at 09:55am, Simon Horman wrote:
> > On Tue, Jul 28, 2015 at 12:46:42PM +0800, Minfei Huang wrote:
> > > Transforming PFN(Page Frame Number) to struct page is never failure, so
> > > we can simplify the code logic to do the image->control_page assignment
> > > directly in the loop, and remove the unnecessary conditional judgement.
> > >
> > > Signed-off-by: Minfei Huang <mnfhuang@gmail.com>
> > > Acked-by: Dave Young <dyoung@redhat.com>
> > > Acked-by: Vivek Goyal <vgoyal@redhat.com>
> >
> > Andrew, could you consider picking this up.
> > It seems to have been sufficiently reviewed, acked, etc...
>
> I saw this has been in linux-next tree.
Excellent, sorry for the noise.
> commit b90b6ef0f152ef42fe66ce5c9ccf2783ea84fa69
> Author: Minfei Huang <mnfhuang@gmail.com>
> Date: Thu Jul 30 09:56:18 2015 +1000
>
> kexec: remove unnecessary test in kimage_alloc_crash_control_pages()
>
> Thanks
> Baoquan
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2015-08-13 7:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 4:46 [REPOST PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic Minfei Huang
2015-08-13 0:55 ` Simon Horman
2015-08-13 5:53 ` Baoquan He
2015-08-13 7:57 ` Simon Horman [this message]
2015-08-13 20:43 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150813075730.GA4325@verge.net.au \
--to=horms@verge.net.au \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mnfhuang@gmail.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox