Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
Cc: linux-nvdimm@ml01.01.org, dan.j.williams@intel.com,
	kexec@lists.infradead.org, hch@lst.de,
	linux-kernel@vger.kernel.org
Subject: Re: kexec, x86: Need a new e820 type support for kexec
Date: Wed, 19 Aug 2015 10:53:16 +0800	[thread overview]
Message-ID: <20150819025316.GD19950@dhcp-128-28.nay.redhat.com> (raw)
In-Reply-To: <1439910078.24434.106.camel@hp.com>

On 08/18/15 at 09:01am, Toshi Kani wrote:
> On Tue, 2015-08-18 at 16:53 +0800, Baoquan He wrote:
> > Rethink it again, maybe it's better to pass PMEM as PRAM to kdump
> > kernel if user really want to use memmap way by specifying
> > --pass-memmap-cmdline. Then I need add the PMEM and PRAM checking here
> > you pointed out. Will repost with them.
> 
> No, you should not report PMEM as PRAM.  They are different things.  The
> kdump kernel does not need to support memmap cmdline for PMEM, as the
> regular kernel does not -- memmap cmdline cannot emulate PMEM.

OK. Then it will be wrong if people intend to specify
--pass-memmap-cmdline. There might be 3 ways to fix this:

1) add PMEM support in kernel. memmap cmdline is not only used for
emulating, but for kexec/kdump using.

2) Delete --pass-memmap-cmdline option in kexec-tools since people
rarely use it.

3) Add a note in kexec-tools that option --pass-memmap-cmdline can't
work together with PMEM, people should not use it.

Thanks
Baoquan

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2015-08-19  2:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-24  0:26 kexec, x86: Need a new e820 type support for kexec Toshi Kani
2015-07-24  5:31 ` Baoquan He
2015-07-24  5:50   ` Baoquan He
2015-07-24 14:27     ` Toshi Kani
2015-07-24 14:37   ` Toshi Kani
2015-08-06  8:12 ` Baoquan He
2015-08-07  1:13   ` Toshi Kani
2015-08-18  8:34     ` Baoquan He
2015-08-18 14:55       ` Toshi Kani
2015-08-18  8:53     ` Baoquan He
2015-08-18 15:01       ` Toshi Kani
2015-08-19  2:53         ` Baoquan He [this message]
2015-08-19  5:36           ` Toshi Kani
2015-08-19  5:59             ` Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150819025316.GD19950@dhcp-128-28.nay.redhat.com \
    --to=bhe@redhat.com \
    --cc=dan.j.williams@intel.com \
    --cc=hch@lst.de \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@ml01.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox