From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZSNvC-0000w0-Dk for kexec@lists.infradead.org; Thu, 20 Aug 2015 11:22:14 +0000 Date: Thu, 20 Aug 2015 16:51:50 +0530 From: Pratyush Anand Subject: Re: [PATCH] makedumpfile: Support ARM64 Message-ID: <20150820112150.GA26132@dhcppc13.redhat.com> References: <20150624033241.GA22348@localhost.localdomain> <558A25A3.60504@codeaurora.org> <20150627082256.GE21646@localhost.localdomain> <20150703043241.GC21990@dhcppc13.redhat.com> <2c41ac3516494a1cc5d05462494b333b.squirrel@www.codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: sgoel@codeaurora.org Cc: virajm@codeaurora.org, Timur Tabi , Azriel Samson , kexec@lists.infradead.org, ats-kumagai@wm.jp.nec.com Hi Sameer, On 19/08/2015:11:16:07 PM, sgoel@codeaurora.org wrote: > Hi Pratyush, > > I made the following changes to the code: > > KVBASE was being mapped to page_offset, so the mem_map that I saw using > the kmem command in crash did not seem to audit with the data generated by > make dumpfile. I changed this to vmalloc_start. I am not sure if KVBASE should be VMALLOC_START. May be Atsushi can comment on that. But if so, did you correct info->page_offset definition in get_machdep_info_arm64? Something like following... diff --git a/arch/arm64.c b/arch/arm64.c index 4d50012529c3..a94a4ba16dd5 100644 --- a/arch/arm64.c +++ b/arch/arm64.c @@ -199,7 +199,8 @@ get_machdep_info_arm64(void) { info->max_physmem_bits = PHYS_MASK_SHIFT; info->section_size_bits = SECTIONS_SIZE_BITS; - info->page_offset = KVBASE; + info->page_offset = SYMBOL(_stext) + & (0xffffffffffffffffUL << (VA_BITS - 1)); info->vmalloc_start = 0xffffffffffffffffUL << VA_BITS; info->vmalloc_end = PAGE_OFFSET - PUD_SIZE - VMEMMAP_SIZE - 0x10000; info->vmemmap_start = VMALLOC_END + 0x10000; diff --git a/makedumpfile.h b/makedumpfile.h index c33b5f321d9a..f7d6fbefe98e 100644 --- a/makedumpfile.h +++ b/makedumpfile.h @@ -488,8 +488,7 @@ int get_va_bits_arm64(void); #define ARM64_PGTABLE_LEVELS get_pgtable_level_arm64() #define VA_BITS get_va_bits_arm64() #define PAGE_SHIFT get_page_shift_arm64() -#define KVBASE_MASK (0xffffffffffffffffUL << (VA_BITS - 1)) -#define KVBASE (SYMBOL(_stext) & KVBASE_MASK) +#define KVBASE VMALLOC_START #endif /* aarch64 */ #ifdef __arm__ ~Pratyush _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec