From: Simon Horman <horms@verge.net.au>
To: Dave Young <dyoung@redhat.com>
Cc: kexec@lists.infradead.org
Subject: Re: [PATCH] fix kexec load hang in case crash notes addr read failure
Date: Fri, 25 Sep 2015 14:39:15 +0900 [thread overview]
Message-ID: <20150925053912.GA21799@verge.net.au> (raw)
In-Reply-To: <20150925023728.GA11505@dhcp-129-149.nay.redhat.com>
On Fri, Sep 25, 2015 at 10:37:51AM +0800, Dave Young wrote:
> While readng crash note, count_cpu variable will be never decreased in case
> any failure to read the sysfs file.
>
> The issue was found during I test CONFIG_KEXEC_FILE only kernel option.
> crash_notes are exported to sysfs only for CONFIG_KEXEC. In latest kernel
> we can configure kernel with CONFIG_KEXEC_FILE only in Kconfig. In this
> case, if you run a kernel with kexec_file only but do not specify "-s"
> in kexec-tools arguments, then kexec-tools will hang there.
>
> Though "-s" is mandatory for kexec_file_load, kexec should still fail out
> instead of hanging.
>
> Fixing the problem by always decreasing count_cpu in the for loop.
>
> Signed-off-by: Dave Young <dyoung@redhat.com>
Thanks Dave, applied.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
prev parent reply other threads:[~2015-09-25 5:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-25 2:37 [PATCH] fix kexec load hang in case crash notes addr read failure Dave Young
2015-09-25 5:39 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150925053912.GA21799@verge.net.au \
--to=horms@verge.net.au \
--cc=dyoung@redhat.com \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox