From: Baoquan He <bhe@redhat.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: iommu@lists.linux-foundation.org, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/10] iommu/amd: Clear the iommu pre enabled setting
Date: Sat, 10 Oct 2015 20:30:36 +0800 [thread overview]
Message-ID: <20151010123036.GC31787@dhcp-16-116.nay.redhat.com> (raw)
In-Reply-To: <20150929160949.GP3036@8bytes.org>
On 09/29/15 at 06:09pm, Joerg Roedel wrote:
> On Thu, Sep 24, 2015 at 02:37:35PM +0800, Baoquan He wrote:
> > @@ -2469,6 +2469,8 @@ static dma_addr_t __map_single(struct device *dev,
> > unsigned long align_mask = 0;
> > int i;
> >
> > + if (translation_pre_enabled())
> > + clear_translation_pre_enabled();
>
> There is probably a better place to do this somewhere in the
> initialization state machine of the AMD IOMMU driver.
Yeah, I put it in state_next().
static int __init state_next(void)
{
int ret = 0;
switch (init_state) {
case IOMMU_START_STATE:
......
case IOMMU_DMA_OPS:
if (translation_pre_enabled())
clear_translation_pre_enabled();
init_state = IOMMU_INITIALIZED;
break;
......
}
>
>
> Joerg
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2015-10-10 12:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-24 6:37 [PATCH 00/10] Fix AMD IOMMU faults in kdump kernel Baoquan He
2015-09-24 6:37 ` [PATCH 01/10] iommu/amd: Use standard bitmap operation to set bitmap Baoquan He
2015-09-24 6:37 ` [PATCH 02/10] iommu/amd: Adjust functons which get first/last devid by reading pci config Baoquan He
2015-09-24 6:37 ` [PATCH 03/10] iommu/amd: Get the first/last device of iommu earlier Baoquan He
2015-09-24 6:37 ` [PATCH 04/10] iommu/amd: Detect pre enabled translation Baoquan He
2015-09-24 6:37 ` [PATCH 05/10] iommu/amd: Add function copy_dev_tables Baoquan He
2015-09-24 6:37 ` [PATCH 06/10] iommu/amd: Add functions copy_command_buffer/copy_event_buffer Baoquan He
[not found] ` <20150929160439.GN3036@8bytes.org>
2015-10-10 12:24 ` Baoquan He
2015-09-24 6:37 ` [PATCH 07/10] iommu/amd: copy old dev tables and do not touch dev tables Baoquan He
[not found] ` <20150929160808.GO3036@8bytes.org>
2015-10-10 12:28 ` Baoquan He
2015-09-24 6:37 ` [PATCH 08/10] iommu/amd: Do not update the information of domain to devtables before device driver init Baoquan He
2015-09-24 6:37 ` [PATCH 09/10] iommu/amd: Clear the iommu pre enabled setting Baoquan He
[not found] ` <20150929160949.GP3036@8bytes.org>
2015-10-10 12:30 ` Baoquan He [this message]
2015-09-24 6:37 ` [PATCH 10/10] iommu/amd: Copy the old ir table Baoquan He
[not found] ` <20150929161140.GQ3036@8bytes.org>
2015-10-10 12:40 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151010123036.GC31787@dhcp-16-116.nay.redhat.com \
--to=bhe@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox