From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZpYZh-0000Jy-0p for kexec@lists.infradead.org; Fri, 23 Oct 2015 09:23:49 +0000 Date: Fri, 23 Oct 2015 17:23:19 +0800 From: Dave Young Subject: Re: [PATCH] kexec-tools: do not copy 1st kernel root= param in fs2dt.c Message-ID: <20151023092319.GF11227@dhcp-129-115.nay.redhat.com> References: <20151009055722.GA6248@dhcp-129-237.nay.redhat.com> <20151016013331.GB20667@verge.net.au> <20151019082246.GC31886@dhcp-129-115.nay.redhat.com> <20151023031917.GE11227@dhcp-129-115.nay.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20151023031917.GE11227@dhcp-129-115.nay.redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Simon Horman Cc: jstodola@redhat.com, kexec@lists.infradead.org On 10/23/15 at 11:19am, Dave Young wrote: > Hi, Simon > > > > > > > > > Also, won't this affect other architectures that use DT. > > > I'm thinking about ARM. If so it might be good to tweak the changelog. > > > > arm also uses the function, but I need verify the behavior. Will tune the changelog > > after I confirming it. > > kexec on arm will have same problem when there's no external dtb being passed. > But kexec kernel failed to start up during my test there may be other problems. > > I will work out a new patch for new option about skip adding root= from 1st kernel. Simon, for the new option, I'm thinking to create a "--dt-no-old-root". It can be a general option, or arch dependent one for arm and ppc64. What do you prefer? Thanks Dave _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec