From: Simon Horman <horms@verge.net.au>
To: Dave Young <dyoung@redhat.com>
Cc: jstodola@redhat.com, kexec@lists.infradead.org
Subject: Re: [PATCH] kexec-tools: do not copy 1st kernel root= param in fs2dt.c
Date: Mon, 26 Oct 2015 13:32:33 +0900 [thread overview]
Message-ID: <20151026043233.GC2411@verge.net.au> (raw)
In-Reply-To: <20151023092319.GF11227@dhcp-129-115.nay.redhat.com>
On Fri, Oct 23, 2015 at 05:23:19PM +0800, Dave Young wrote:
> On 10/23/15 at 11:19am, Dave Young wrote:
> > Hi, Simon
> >
> > >
> > > >
> > > > Also, won't this affect other architectures that use DT.
> > > > I'm thinking about ARM. If so it might be good to tweak the changelog.
> > >
> > > arm also uses the function, but I need verify the behavior. Will tune the changelog
> > > after I confirming it.
> >
> > kexec on arm will have same problem when there's no external dtb being passed.
> > But kexec kernel failed to start up during my test there may be other problems.
> >
> > I will work out a new patch for new option about skip adding root= from 1st kernel.
>
> Simon, for the new option, I'm thinking to create a "--dt-no-old-root". It can be
> a general option, or arch dependent one for arm and ppc64. What do you prefer?
Lets just make it arch dependent if it only changes the behaviour
on some architectures. The name sounds good to me.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2015-10-26 4:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 5:57 [PATCH] kexec-tools: do not copy 1st kernel root= param in fs2dt.c Dave Young
2015-10-16 1:33 ` Simon Horman
2015-10-19 8:22 ` Dave Young
2015-10-23 3:19 ` Dave Young
2015-10-23 9:23 ` Dave Young
2015-10-26 4:32 ` Simon Horman [this message]
2015-10-26 7:32 ` Dave Young
2015-10-26 4:31 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151026043233.GC2411@verge.net.au \
--to=horms@verge.net.au \
--cc=dyoung@redhat.com \
--cc=jstodola@redhat.com \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox