From: Simon Horman <horms@verge.net.au>
To: Daniel Kiper <daniel.kiper@oracle.com>
Cc: keir@xen.org, konrad.wilk@oracle.com, andrew.cooper3@citrix.com,
kexec@lists.infradead.org, david.vrabel@citrix.com,
jbeulich@suse.com, xen-devel@lists.xenproject.org
Subject: Re: [RFC PATCH] crashdump/x86: Add option to get crash kernel region size
Date: Tue, 1 Dec 2015 15:20:32 +0900 [thread overview]
Message-ID: <20151201062032.GC16260@verge.net.au> (raw)
In-Reply-To: <20151130073931.GZ4768@olila.local.net-space.pl>
On Mon, Nov 30, 2015 at 08:39:31AM +0100, Daniel Kiper wrote:
> On Mon, Nov 30, 2015 at 08:55:32AM +0900, Simon Horman wrote:
> > On Sat, Nov 28, 2015 at 09:14:04PM +0100, Daniel Kiper wrote:
> > > Crash kernel region size is available via sysfs on Linux running on
> > > bare metal. However, this does not work when Linux runs as Xen dom0.
> > > In this case Xen crash kernel region size should be established using
> > > __HYPERVISOR_kexec_op hypercall (Linux kernel kexec functionality does
> > > not make a lot of sense in Xen dom0). Sadly hypercalls are not easily
> > > accessible using shell scripts or something like that. Potentially we
> > > can check "xl dmesg" output for crashkernel option but this is not nice.
> > > So, let's add this functionality, for Linux running on bare metal and
> > > as Xen dom0, to kexec-tools. This way kdump scripts may establish crash
> > > kernel region size in one way regardless of platform. All burden of
> > > platform detection lies on kexec-tools.
> > >
> > > Figure (and unit) displayed by this new kexec-tools functionality is
> > > the same as one taken from /sys/kernel/kexec_crash_size.
> > >
> > > This functionality is available on x86 platform only. If idea is acceptable
> > > then I can prepare patches for other platforms (if it is possible and make
> > > sense) and repost them as fully flagged patch series.
> > >
> > > Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
> >
> > Thanks, applied.
>
> Thanks a lot. However, this patch itself breaks build on other platforms.
> That is why I posted it as a RFC. To fix this I can post similar patches
> for other platforms (this will happen probably tomorrow or on Wednesday
> but no later than by the end of this week). Or you can revert this patch
> and than I repost it as a part of fully functional patch series.
Sorry for being a bit too hasty.
I will revert.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
prev parent reply other threads:[~2015-12-01 6:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-28 20:14 [RFC PATCH] crashdump/x86: Add option to get crash kernel region size Daniel Kiper
2015-11-29 23:55 ` Simon Horman
2015-11-30 7:39 ` Daniel Kiper
2015-12-01 6:20 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151201062032.GC16260@verge.net.au \
--to=horms@verge.net.au \
--cc=andrew.cooper3@citrix.com \
--cc=daniel.kiper@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=kexec@lists.infradead.org \
--cc=konrad.wilk@oracle.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox