Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Pratyush Anand <panand@redhat.com>
To: Scott Wood <scottwood@freescale.com>
Cc: Geoff Levand <geoff@infradead.org>,
	kexec@lists.infradead.org, Simon Horman <horms@verge.net.au>,
	Petitboot@lists.ozlabs.org, Dave Young <dyoung@redhat.com>,
	Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [PATCH] kexec: Add --lite option
Date: Mon, 7 Dec 2015 17:15:47 +0530	[thread overview]
Message-ID: <20151207114547.GE16406@dhcppc13.redhat.com> (raw)
In-Reply-To: <1446703011.12676.83.camel@freescale.com>

+linux-arm-kernel@lists.infradead.org (May be someone from arm kernel list can
give some more input)

On 04/11/2015:11:56:51 PM, Scott Wood wrote:
> On Thu, 2015-10-22 at 12:08 -0700, Geoff Levand wrote:
> > I notice the difference on the my arm64 system, so I guess we
> > are even on that.
> 
> For me it was beyond "notice the difference" -- I thought it was completely 
> broken, and was preparing to debug, until it started spitting out output over 
> a minute later.
> 
> Compiling the sha256 code with -O2 instead of -O0 cut it down to around 10 
> seconds (still unpleasant, but not quite as crazy... still unacceptable for 
> non-kdump, though).

Yes, compiling purgatory code with -O2 helps to improve the timing, and I notice
that enabling D-cache on top of -O2 does not improve it further. However, I am
still not able to understand that why there is huge difference between following
two.

1) When we execute kexec() system call in first kernel, at that time it
calculates sha256 on all the binaries [1]. It take almost un-noticeable time
(less than a sec) there.

2) When purgatory is executed then it re-calculates sha256 using same routines
[2] on same binary data as that of case (1). But, now it takes 10-20 sec
(depending of size of binaries)?

Why did not it take same time with O2 + D-cache enabled? I think, we should be
able to achieve same time in second case as well. What is missing?

~Pratyush

[1] http://git.kernel.org/cgit/utils/kernel/kexec/kexec-tools.git/tree/kexec/kexec.c#n650
[2] http://git.kernel.org/cgit/utils/kernel/kexec/kexec-tools.git/tree/purgatory/purgatory.c#n20

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2015-12-07 11:46 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-21 23:12 [PATCH] kexec: Add --lite option Geoff Levand
2015-10-22  0:02 ` Jeremy Kerr
2015-10-22  0:37   ` Geoff Levand
2015-11-05  6:20     ` Scott Wood
2015-10-22  3:17 ` Dave Young
2015-10-22 12:50   ` Vivek Goyal
2015-10-22 19:08     ` Geoff Levand
2015-11-05  5:56       ` Scott Wood
2015-12-07 11:45         ` Pratyush Anand [this message]
2015-12-07 11:48           ` Pratyush Anand
2015-12-07 13:16             ` James Morse
2015-12-07 14:07               ` Pratyush Anand
2015-12-08  1:03                 ` Scott Wood
2015-12-08 16:00                 ` James Morse
2015-12-09  9:28                   ` Pratyush Anand
2016-01-11 12:46                     ` Pratyush Anand
2016-01-12  1:06                       ` Simon Horman
2015-10-22 18:57   ` Geoff Levand
2015-10-22 19:04     ` Vivek Goyal
2015-10-23  9:46     ` Dave Young
2015-10-23 18:49       ` Geoff Levand
2015-10-23 19:02     ` Eric W. Biederman
2018-04-11 18:30 ` [PATCH v2] kexec: Add --no-checks option Geoff Levand
2018-04-19  8:38   ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151207114547.GE16406@dhcppc13.redhat.com \
    --to=panand@redhat.com \
    --cc=Petitboot@lists.ozlabs.org \
    --cc=dyoung@redhat.com \
    --cc=geoff@infradead.org \
    --cc=horms@verge.net.au \
    --cc=kexec@lists.infradead.org \
    --cc=scottwood@freescale.com \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox