From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Date: Tue, 15 Dec 2015 17:05:24 +0000 From: Will Deacon Subject: Re: [PATCH v12 16/16] arm64: kdump: relax BUG_ON() if more than one cpus are still active Message-ID: <20151215170523.GA353@arm.com> References: <83db66df70fc1f7cd4da8b580d264b9320991cf0.1448403503.git.geoff@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <83db66df70fc1f7cd4da8b580d264b9320991cf0.1448403503.git.geoff@infradead.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Geoff Levand Cc: Mark Rutland , marc.zyngier@arm.com, Catalin Marinas , kexec@lists.infradead.org, AKASHI Takahiro , linux-arm-kernel@lists.infradead.org, christoffer.dall@linaro.org On Tue, Nov 24, 2015 at 10:25:34PM +0000, Geoff Levand wrote: > From: AKASHI Takahiro > > We should try best in case of kdump. > So even if not all secondary cpus have shut down, we do kdump anyway. > --- > arch/arm64/kernel/machine_kexec.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/machine_kexec.c b/arch/arm64/kernel/machine_kexec.c > index d2d7e90..482aae7 100644 > --- a/arch/arm64/kernel/machine_kexec.c > +++ b/arch/arm64/kernel/machine_kexec.c > @@ -148,7 +148,13 @@ void machine_kexec(struct kimage *kimage) > phys_addr_t reboot_code_buffer_phys; > void *reboot_code_buffer; > > - BUG_ON(num_online_cpus() > 1); > + if (num_online_cpus() > 1) { > + if (in_crash_kexec) > + pr_warn("kdump might fail because %d cpus are still online\n", > + num_online_cpus()); > + else > + BUG(); > + } Can you just rewrite the existing BUG_ON as: BUG_ON(num_online_cpus() && !WARN_ON(in_crash_kexec)); ? Will _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec