Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Pratyush Anand <panand@redhat.com>
To: AKASHI Takahiro <takahiro.akashi@linaro.org>
Cc: geoff@infradead.org, kexec@lists.infradead.org,
	horms@verge.net.au, james.morse@arm.com, jk@ozlabs.org,
	scottwood@freescale.com, dyoung@redhat.com, vgoyal@redhat.com,
	ebiederm@xmission.com
Subject: Re: [PATCH RFC V2 1/2] arm64: Add enable/disable d-cache support for purgatory
Date: Wed, 13 Jan 2016 11:14:57 +0530	[thread overview]
Message-ID: <20160113054457.GC8122@dhcppc1> (raw)
In-Reply-To: <20160112095342.GJ21206@dhcppc13.redhat.com>

Hi Akashi,

On 12/01/2016:03:23:42 PM, Pratyush Anand wrote:
> > >+static void init_page_table(void)
> > >+{
> > >+	inval_cache_range((uint64_t)page_table,
> > >+				(uint64_t)page_table + PAGE_TABLE_SIZE);
> > >+	memset(page_table, 0, PAGE_TABLE_SIZE);
> > 
> > why invalidate first?
> 
> Humm..may be you are right. It was copied from arch/arm64/kernel/head.S.
> http://lxr.free-electrons.com/source/arch/arm64/kernel/head.S#L322

I am not yet sure about the cache eviction policy on different arch. So as per
kernel code's comment (Invalidate the idmap and swapper page tables to avoid
potential dirty cache lines being evicted.), I would like to keep it here.  May
be I will add similar comment here as well.

~Pratyush

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  parent reply	other threads:[~2016-01-13  5:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-12  5:12 [PATCH RFC V2 0/2] kexec: arm64: purgatory: cache support Pratyush Anand
2016-01-12  5:12 ` [PATCH RFC V2 1/2] arm64: Add enable/disable d-cache support for purgatory Pratyush Anand
2016-01-12  8:34   ` AKASHI Takahiro
2016-01-12  9:53     ` Pratyush Anand
2016-01-13  4:35       ` AKASHI Takahiro
2016-01-13  5:44       ` Pratyush Anand [this message]
2016-01-12  5:12 ` [PATCH RFC V2 2/2] arm64: Pass RAM boundary and enable-dcache flag to purgatory Pratyush Anand
2016-01-12  8:38   ` AKASHI Takahiro
2016-01-12  9:55     ` Pratyush Anand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160113054457.GC8122@dhcppc1 \
    --to=panand@redhat.com \
    --cc=dyoung@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=geoff@infradead.org \
    --cc=horms@verge.net.au \
    --cc=james.morse@arm.com \
    --cc=jk@ozlabs.org \
    --cc=kexec@lists.infradead.org \
    --cc=scottwood@freescale.com \
    --cc=takahiro.akashi@linaro.org \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox