From: Ivan Delalande <colona@arista.com>
To: Petr Tesarik <ptesarik@suse.cz>
Cc: Atsushi Kumagai <ats-kumagai@wm.jp.nec.com>,
"kexec@lists.infradead.org" <kexec@lists.infradead.org>
Subject: Re: [PATCH] makedumpfile: readpage_elf: handle 0-pages not stored in the ELF file
Date: Wed, 10 Feb 2016 04:21:18 +0100 [thread overview]
Message-ID: <20160210032118.GI382@ycc.fr> (raw)
In-Reply-To: <20160209093150.35da61c2@hananiah.suse.cz>
Hi,
On Tue, Feb 09, 2016 at 09:31:50AM +0100, Petr Tesarik wrote:
> On Tue, 2 Feb 2016 08:00:44 +0100 Ivan Delalande <colona@arista.com> wrote:
> > On Tue, Feb 02, 2016 at 06:48:17AM +0000, Atsushi Kumagai wrote:
> > > >Anyway, are you going to take the patch by Ivan, or my patch (after I
> > > >remove exclude_nodata_pages)?
> > >
> > > Ivan's patch is necessary to follow the ELF specification, but also
> > > your patch (with exclude_nodata_pages) should be merged.
> > > The two patches have different approach to expand struct pt_load_segment,
> > > hence could you manage both work ?
> > >
> > > Ivan, your v2 patch has no problems, but could I leave this work to Petr
> > > since the two patches touch the same area ?
> >
> > Sure, this sounds reasonable.
>
> just a short status update. I haven't forgotten this patch, but I've
> had some troubles reproducing the issue. To make sure I'm not on the
> wrong track, what happened when you tried to dump dmesg on the affected
> dump file without the patch?
>
> For me, I crafted a dump file which causes a segfault. Did makedumpfile
> also terminate on SIGSEGV? Did it report an error? Or did it just
> produce wrong output?
Yeah, just a segfault, without any other message or output. It was
coming from readpage_elf, at the call to memset in the `if (!offset1)`
block, as it thinks it is handling one of this weird overlapping
segments from ia64 and computes bad offsets.
Thank you,
--
Ivan "Colona" Delalande
Arista Networks
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2016-02-10 3:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-22 23:35 [PATCH] makedumpfile: readpage_elf: handle 0-pages not stored in the ELF file Ivan Delalande
2016-01-27 2:21 ` Atsushi Kumagai
[not found] ` <20160127085821.3be424e1@hananiah.suse.cz>
2016-01-27 9:37 ` Petr Tesarik
2016-02-01 6:48 ` Atsushi Kumagai
2016-02-01 12:00 ` Petr Tesarik
2016-02-02 6:48 ` Atsushi Kumagai
2016-02-02 7:00 ` Ivan Delalande
2016-02-09 8:31 ` Petr Tesarik
2016-02-10 2:57 ` Kexec on ARM? Rudici Cazeao
2016-02-10 3:21 ` Ivan Delalande [this message]
2016-02-10 7:52 ` [PATCH] makedumpfile: readpage_elf: handle 0-pages not stored in the ELF file Petr Tesarik
2016-02-10 18:06 ` Kexec on ARM? Rudici Cazeao
2016-01-27 22:17 ` [PATCH v2] makedumpfile: readpage_elf: handle 0-pages not stored in the ELF file Ivan Delalande
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160210032118.GI382@ycc.fr \
--to=colona@arista.com \
--cc=ats-kumagai@wm.jp.nec.com \
--cc=kexec@lists.infradead.org \
--cc=ptesarik@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox