From: Vivek Goyal <vgoyal@redhat.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Pratyush Anand <panand@redhat.com>,
linux-doc@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
kexec@lists.infradead.org, Haren Myneni <hbabu@us.ibm.com>,
Dave Young <dyoung@redhat.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: kexec: fix crashkernel= handling
Date: Wed, 30 Mar 2016 09:27:08 -0400 [thread overview]
Message-ID: <20160330132708.GC32738@redhat.com> (raw)
In-Reply-To: <20160330130530.GH19428@n2100.arm.linux.org.uk>
On Wed, Mar 30, 2016 at 02:05:30PM +0100, Russell King - ARM Linux wrote:
> On Wed, Mar 30, 2016 at 06:09:22PM +0530, Pratyush Anand wrote:
> > On 30/03/2016:09:46:38 AM, Dave Young wrote:
> > > Hi, Russell
> > >
> > > A long standing issue, but nobody tried to do it. Thank you for bringing up.
> > >
> > > On 03/29/16 at 11:10am, Russell King wrote:
> > > > When the kernel crashkernel parameter is specified with just a size, we
> > > > are supposed to allocate a region from RAM to store the crashkernel.
> > > > However, ARM merely reserves physical address zero with no checking
> > > > that there is even RAM there.
> > > >
> > > > Fix this by lifting similar code from x86, importing it to ARM with
> > > > the ARM specific parameters added.
> > > >
> > > > Update the kdump documentation to reflect this change.
> > > >
> > > > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> > > > ---
> > > > Documentation/kdump/kdump.txt | 13 +++----------
> > > > arch/arm/kernel/setup.c | 26 ++++++++++++++++++++++++++
> > > > 2 files changed, 29 insertions(+), 10 deletions(-)
> > > >
> > > > diff --git a/Documentation/kdump/kdump.txt b/Documentation/kdump/kdump.txt
> > > > index bc4bd5a44b88..88ff63d5fde3 100644
> > > > --- a/Documentation/kdump/kdump.txt
> > > > +++ b/Documentation/kdump/kdump.txt
> > > > @@ -263,12 +263,6 @@ been removed from the machine.
> > > > crashkernel=<range1>:<size1>[,<range2>:<size2>,...][@offset]
> > > > range=start-[end]
> > > >
> > > > -Please note, on arm, the offset is required.
> > > > - crashkernel=<range1>:<size1>[,<range2>:<size2>,...]@offset
> > > > - range=start-[end]
> > > > -
> > > > - 'start' is inclusive and 'end' is exclusive.
> > > > -
> > > > For example:
> > > >
> > > > crashkernel=512M-2G:64M,2G-:128M
> > > > @@ -307,10 +301,9 @@ Boot into System Kernel
> > > > on the memory consumption of the kdump system. In general this is not
> > > > dependent on the memory size of the production system.
> > > >
> > > > - On arm, use "crashkernel=Y@X". Note that the start address of the kernel
> > > > - will be aligned to 128MiB (0x08000000), so if the start address is not then
> > > > - any space below the alignment point may be overwritten by the dump-capture kernel,
> > > > - which means it is possible that the vmcore is not that precise as expected.
> > > > + On arm, the use of "crashkernel=Y@X" is no longer necessary; the
> > > > + kernel will automatically locate the crash kernel image within the
> > > > + first 512MB of RAM if X is not given.
> > > >
> > > >
> > > > Load the Dump-capture Kernel
> > > > diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c
> > > > index 7d0cba6f1cc5..5d8511c425f0 100644
> > > > --- a/arch/arm/kernel/setup.c
> > > > +++ b/arch/arm/kernel/setup.c
> > > > @@ -938,6 +938,13 @@ static int __init init_machine_late(void)
> > > > late_initcall(init_machine_late);
> > > >
> > > > #ifdef CONFIG_KEXEC
> > > > +/*
> > > > + * The crash region must be aligned to 128MB to avoid
> > > > + * zImage relocating below the reserved region.
> > > > + */
> > > > +#define CRASH_ALIGN (128 << 20)
> > > > +#define CRASH_ADDR_MAX (PHYS_OFFSET + (512 << 20))
> > >
> > > Any reason to limit crash mem within the first 512M only? What if one want to
> > > reserve memory over 512M?
> >
> > When crash base is not give, then may be it can be just checked if memblock
> > region is memory and not reserved, then allow to reserve. That might help to
> > remove 512M restriction.
>
> ... and then I'll have to update the commit text.
>
> You may notice that I say that this is mostly taken from the x86
> implementation. The x86 implementation also has this 512MB
> allocation limit, to prevent it being placed too high in physical
> memory.
IIRC, x86 had this limitation as they could not support any higher. But
if ARM can support higher, it would be good to allow that.
Thanks
Vivek
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2016-03-30 13:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 10:10 [PATCH] ARM: kexec: fix crashkernel= handling Russell King
2016-03-30 1:46 ` Dave Young
2016-03-30 12:39 ` Pratyush Anand
2016-03-30 13:05 ` Russell King - ARM Linux
2016-03-30 13:27 ` Vivek Goyal [this message]
2016-04-01 13:25 ` Russell King - ARM Linux
2016-04-06 6:57 ` Dave Young
2016-04-07 21:03 ` [PATCH v2] " Russell King
2016-04-08 2:12 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160330132708.GC32738@redhat.com \
--to=vgoyal@redhat.com \
--cc=corbet@lwn.net \
--cc=dyoung@redhat.com \
--cc=hbabu@us.ibm.com \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=panand@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox