From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1b5qlu-0000vY-CP for kexec@lists.infradead.org; Thu, 26 May 2016 08:36:03 +0000 Date: Thu, 26 May 2016 09:35:28 +0100 From: Russell King - ARM Linux Subject: Re: [PATCH kexec-tools 01/32] kdump: mmap() and munmap() only work on page-aligned quantites Message-ID: <20160526083528.GE19428@n2100.arm.linux.org.uk> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Pratyush Anand Cc: kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org On Wed, May 25, 2016 at 11:46:08AM +0530, Pratyush Anand wrote: > On Tue, May 3, 2016 at 3:51 PM, Russell King wrote: > > The man page for mmap() and munmap() says that mmap() and munmap() > > only works for page-aligned addresses, sizes and offsets. Arrange > > to give these interfaces what they want. > > > > If I read correctly, it talks only offsets to be page aligned. Yes, it's not really needed, but as we have to adjust the size anyway to compensate for the reduced file offset, it makes little difference whether we align the size or not. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec