From: Baoquan He <bhe@redhat.com>
To: Atsushi Kumagai <ats-kumagai@wm.jp.nec.com>
Cc: "kexec@lists.infradead.org" <kexec@lists.infradead.org>,
"thgarnie@google.com" <thgarnie@google.com>
Subject: Re: [PATCH 3/3] makedumpfile: Add support for MM randomization
Date: Tue, 4 Oct 2016 21:09:49 +0800 [thread overview]
Message-ID: <20161004130949.GD9185@x1.redhat.com> (raw)
In-Reply-To: <0910DD04CBD6DE4193FCF86B9C00BE9701E6CE53@BPXM01GP.gisp.nec.co.jp>
On 10/04/16 at 01:40am, Atsushi Kumagai wrote:
> >> > /*
> >> > * On linux-2.6.26, MAX_PHYSMEM_BITS is changed to 44 from 40.
> >> >@@ -159,22 +160,13 @@ get_versiondep_info_x86_64(void)
> >> > else
> >> > info->max_physmem_bits = _MAX_PHYSMEM_BITS_2_6_31;
> >> >
> >> >- if (info->kernel_version < KERNEL_VERSION(2, 6, 27))
> >> >- info->page_offset = __PAGE_OFFSET_ORIG;
> >> >- else
> >> >- info->page_offset = __PAGE_OFFSET_2_6_27;
> >> >+ info->page_offset = NUMBER(page_offset);
> >> >
> >> >- if (info->kernel_version < KERNEL_VERSION(2, 6, 31)) {
> >> >- info->vmalloc_start = VMALLOC_START_ORIG;
> >> >- info->vmalloc_end = VMALLOC_END_ORIG;
> >> >- info->vmemmap_start = VMEMMAP_START_ORIG;
> >> >- info->vmemmap_end = VMEMMAP_END_ORIG;
> >> >- } else {
> >> >- info->vmalloc_start = VMALLOC_START_2_6_31;
> >> >- info->vmalloc_end = VMALLOC_END_2_6_31;
> >> >- info->vmemmap_start = VMEMMAP_START_2_6_31;
> >> >- info->vmemmap_end = VMEMMAP_END_2_6_31;
> >> >- }
> >>
> >> These *_END_* are no longer used, it's better to remove the definitions
> >> of them.
> >
> >
> >Seems is_vmalloc_addr_x86_64 still needs VMALLOC_END and VMEMMAP_END to
> >make a judgement.
>
> Yes, VMALLOC_END and VMEMMAP_END are necessary, but what I mentioned were
> VMALLOC_END_ORIG, VMEMMAP_END_ORIG , VMALLOC_END_2_6_31 and VMEMMAP_END_2_6_31.
> The symbols were used only to initialize info->vmalloc_end and info->vmemmap_end,
> so they will be unnecessary by this patch.
Yes, you are right. These unused MACRO definitions need be removed.
Thanks for your reviewing.
Thanks
Baoquan
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2016-10-04 13:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 8:54 [PATCH 0/3] makedumpfile: Add support of mm randomization Baoquan He
2016-08-29 8:54 ` [PATCH 1/3] makedumpfile: Get info->kernel_version from SYMBOL(init_uts_ns) earlier Baoquan He
2016-08-29 8:54 ` [PATCH 2/3] makedumpfile: Move get_versiondep_info calling earlier Baoquan He
2016-08-29 8:54 ` [PATCH 3/3] makedumpfile: Add support for MM randomization Baoquan He
2016-08-31 7:56 ` Atsushi Kumagai
2016-09-30 4:56 ` Baoquan He
2016-10-04 1:40 ` Atsushi Kumagai
2016-10-04 13:09 ` Baoquan He [this message]
2016-08-29 9:03 ` [PATCH 0/3] makedumpfile: Add support of mm randomization Baoquan He
2016-09-22 8:45 ` Dave Young
2016-09-22 8:48 ` Dave Young
2016-09-22 8:57 ` Baoquan He
2016-09-22 9:03 ` Dave Young
2016-09-22 9:07 ` Baoquan He
2016-09-23 2:38 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161004130949.GD9185@x1.redhat.com \
--to=bhe@redhat.com \
--cc=ats-kumagai@wm.jp.nec.com \
--cc=kexec@lists.infradead.org \
--cc=thgarnie@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).