Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: Dave Anderson <anderson@redhat.com>
Cc: panand@redhat.com, ats-kumagai@wm.jp.nec.com,
	kexec@lists.infradead.org, ebiederm@xmission.com,
	tglx@linutronix.de, dyoung@redhat.com
Subject: Re: [PATCH 2/2] makedumpfile: Clean up unused KERNEL_IMAGE_SIZE
Date: Wed, 9 Nov 2016 08:16:50 +0800	[thread overview]
Message-ID: <20161109001650.GA3598@x1> (raw)
In-Reply-To: <307037751.13707363.1478615163009.JavaMail.zimbra@redhat.com>

On 11/08/16 at 09:26am, Dave Anderson wrote:
> 
> 
> ----- Original Message -----
> > The old MODULES_VADDR need be decided by KERNEL_IMAGE_SIZE when kaslr
> > enabled. Now MODULES_VADDR is not needed any more since Pratyush makes
> > all VA to PA converting done by page table lookup. So remove its related
> > code.
> 
> Hi Bao,
> 
> I'm not clear on this.  The crash utility still reads/needs KERNEL_IMAGE_SIZE
> from the dumpfile's vmcoreinfo data.  Is it being written to the vmcoreinfo
> section somewhere else in the code?

Aha, seems makedumpfile will get the vmcoreinfo offset and size, then
write the whole vmcoreinfo block into dumped vmcore header. But if
specify '-g' for makedumpfile to only generate a vmcoreinfo file, it
won't contain KERNEL_IMAGE_SIZE. 

makedumpfile -g vmcoreinfo -x vmlinux

So I am not sure if you care about vmcoreinfo file, but you are right, I
should not remove the vmcoreinfo reading and writing data.

Thanks for pointing it out, will send v2 post.

Thanks
Baoquan

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2016-11-09  0:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-08  8:55 [PATCH 0/2] makedumpfile: Adapt code to get value of phys_base Baoquan He
2016-11-08  8:55 ` [PATCH 1/2] " Baoquan He
2016-11-10  3:57   ` Atsushi Kumagai
2016-11-10  4:51     ` Baoquan He
2016-11-10  6:30   ` [PATCH v2 " Baoquan He
2016-11-11  8:12     ` Atsushi Kumagai
2016-11-11  9:49       ` Baoquan He
2016-11-08  8:55 ` [PATCH 2/2] makedumpfile: Clean up unused KERNEL_IMAGE_SIZE Baoquan He
2016-11-08 14:26   ` Dave Anderson
2016-11-09  0:16     ` Baoquan He [this message]
2016-11-10  1:15       ` Atsushi Kumagai
2016-11-10  2:06         ` Baoquan He
2016-11-10  3:58           ` Atsushi Kumagai
2016-11-10  4:48             ` Baoquan He
2016-11-10  5:31               ` Atsushi Kumagai
2016-11-10 13:48           ` Dave Anderson
2016-11-09  6:55   ` Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161109001650.GA3598@x1 \
    --to=bhe@redhat.com \
    --cc=anderson@redhat.com \
    --cc=ats-kumagai@wm.jp.nec.com \
    --cc=dyoung@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=kexec@lists.infradead.org \
    --cc=panand@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox