From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <kexec-bounces+dwmw2=infradead.org@lists.infradead.org>
Received: from mx1.redhat.com ([209.132.183.28])
 by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux))
 id 1c4elg-0000Kl-0r
 for kexec@lists.infradead.org; Thu, 10 Nov 2016 02:07:08 +0000
Date: Thu, 10 Nov 2016 10:06:43 +0800
From: Baoquan He <bhe@redhat.com>
Subject: Re: [PATCH 2/2] makedumpfile: Clean up unused KERNEL_IMAGE_SIZE
Message-ID: <20161110020643.GB22737@x1>
References: <1478595319-9299-1-git-send-email-bhe@redhat.com>
 <1478595319-9299-3-git-send-email-bhe@redhat.com>
 <307037751.13707363.1478615163009.JavaMail.zimbra@redhat.com>
 <20161109001650.GA3598@x1>
 <0910DD04CBD6DE4193FCF86B9C00BE9701E7E2F3@BPXM01GP.gisp.nec.co.jp>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <0910DD04CBD6DE4193FCF86B9C00BE9701E7E2F3@BPXM01GP.gisp.nec.co.jp>
List-Id: <kexec.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/kexec>,
 <mailto:kexec-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/kexec/>
List-Post: <mailto:kexec@lists.infradead.org>
List-Help: <mailto:kexec-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/kexec>,
 <mailto:kexec-request@lists.infradead.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "kexec" <kexec-bounces@lists.infradead.org>
Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org
To: Atsushi Kumagai <ats-kumagai@wm.jp.nec.com>
Cc: "panand@redhat.com" <panand@redhat.com>, "kexec@lists.infradead.org" <kexec@lists.infradead.org>, Dave Anderson <anderson@redhat.com>, "ebiederm@xmission.com" <ebiederm@xmission.com>, "tglx@linutronix.de" <tglx@linutronix.de>, "dyoung@redhat.com" <dyoung@redhat.com>

On 11/10/16 at 01:15am, Atsushi Kumagai wrote:
> Hello Baoquan,
> 
> >> > The old MODULES_VADDR need be decided by KERNEL_IMAGE_SIZE when kaslr
> >> > enabled. Now MODULES_VADDR is not needed any more since Pratyush makes
> >> > all VA to PA converting done by page table lookup. So remove its related
> >> > code.
> >>
> >> Hi Bao,
> >>
> >> I'm not clear on this.  The crash utility still reads/needs KERNEL_IMAGE_SIZE
> >> from the dumpfile's vmcoreinfo data.  Is it being written to the vmcoreinfo
> >> section somewhere else in the code?
> >
> >Aha, seems makedumpfile will get the vmcoreinfo offset and size, then
> >write the whole vmcoreinfo block into dumped vmcore header. But if
> >specify '-g' for makedumpfile to only generate a vmcoreinfo file, it
> >won't contain KERNEL_IMAGE_SIZE.
> >
> >makedumpfile -g vmcoreinfo -x vmlinux
> >
> >So I am not sure if you care about vmcoreinfo file, but you are right, I
> >should not remove the vmcoreinfo reading and writing data.
> >
> >Thanks for pointing it out, will send v2 post.
> 
> I understand the vmcoreinfo file generated by '-g' is used only for
> makedumpfile, so it's OK if it doesn't contain KERNEL_IMAGE_SIZE since
> crash doesn't refer to the file.
> This patch doesn't modify the original vmcoreinfo section in dumpfile,
> it sounds reasonable to me.

Thanks for your comments, Atsushi! Then I am fine.

Thanks
Baoquan


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec