Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Pratyush Anand <panand@redhat.com>
Cc: Geoff Levand <geoff@infradead.org>,
	Kexec Mailing List <kexec@lists.infradead.org>
Subject: Re: [PATCH] purgatory: Change default sha256 optimization to -O2
Date: Wed, 30 Nov 2016 12:02:33 +0100	[thread overview]
Message-ID: <20161130110233.GA31616@verge.net.au> (raw)
In-Reply-To: <CAHB_GupOJfW+1p9F9Ybuvz_VZ0Shs4OZyxLHm1cX-5svQk-oOQ@mail.gmail.com>

On Mon, Nov 28, 2016 at 11:14:38AM +0530, Pratyush Anand wrote:
> On Thu, Nov 24, 2016 at 1:23 PM, Simon Horman <horms@verge.net.au> wrote:
> > On Wed, Nov 23, 2016 at 09:57:09AM -0800, Geoff Levand wrote:
> >> Change the default purgatory sha256 code optimization from -O0 to -O2, and add a
> >> new arch specific makefile variable $(ARCH)_PURGATORY_SHA256_CFLAGS which can
> >> over ride this default.  Set ia64_PURGATORY_SHA256_CFLAGS to -O0 to retain the
> >> previous optimization level for ia64.
> >>
> >> The purgatory sha256 code needs the be built with -O0 for the  ia64
> >> architecture.  Currently this code is built with -O0 for all architectures,
> >> which slows down the calculations for architectures which could otherwise
> >> use -O2.
> >
> > Could you give an indication of the performance improvement you expect,
> > e.g. on arm64?
> >
> 
> It takes around 20 second to verify SHA in purgatory when vmlinuz
> image is around 13MB and initramfs is around 30M with -O2 enables.
> Otherwise, it takes more than 2 minutes.

Thanks.

This patch doesn't seem to apply against the master branch.
I'm wondering if you or Geoff could:

1. Rebase the patch
2. Include some text about the performance improvement.
   Something like what is above would be fine from my pov.

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2016-11-30 11:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-23 17:57 [PATCH] purgatory: Change default sha256 optimization to -O2 Geoff Levand
2016-11-24  7:53 ` Simon Horman
2016-11-28  5:44   ` Pratyush Anand
2016-11-30 11:02     ` Simon Horman [this message]
2016-12-01 19:09       ` Geoff Levand
2016-12-01 19:09 ` [PATCH V2] " Geoff Levand
2016-12-02  8:21   ` Simon Horman
  -- strict thread matches above, loose matches on Subject: below --
2015-11-06 20:36 [PATCH] " Geoff Levand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161130110233.GA31616@verge.net.au \
    --to=horms@verge.net.au \
    --cc=geoff@infradead.org \
    --cc=kexec@lists.infradead.org \
    --cc=panand@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox