From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <kexec-bounces+dwmw2=infradead.org@lists.infradead.org>
Received: from kirsty.vergenet.net ([202.4.237.240])
 by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux))
 id 1cGLbF-0003qW-Jq
 for kexec@lists.infradead.org; Mon, 12 Dec 2016 08:04:42 +0000
Date: Mon, 12 Dec 2016 09:04:12 +0100
From: Simon Horman <horms@verge.net.au>
Subject: Re: [PATCH v2 kexec-tools] arm: do not build iomem.o target with no
 soruce
Message-ID: <20161212080412.GC10193@verge.net.au>
References: <1481281212-16929-1-git-send-email-horms@verge.net.au>
 <9d7b9d56-f4a6-4f0c-533b-20f56296c61a@redhat.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <9d7b9d56-f4a6-4f0c-533b-20f56296c61a@redhat.com>
List-Id: <kexec.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/kexec>,
 <mailto:kexec-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/kexec/>
List-Post: <mailto:kexec@lists.infradead.org>
List-Help: <mailto:kexec-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/kexec>,
 <mailto:kexec-request@lists.infradead.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "kexec" <kexec-bounces@lists.infradead.org>
Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org
To: Pratyush Anand <panand@redhat.com>
Cc: Dave Young <dyoung@redhat.com>, kexec@lists.infradead.org

On Fri, Dec 09, 2016 at 05:45:55PM +0530, Pratyush Anand wrote:
> 
> 
> On Friday 09 December 2016 04:30 PM, Simon Horman wrote:
> >Header files should be added to the distribution but not
> >used to derive targets for compilation. In this an attempt was
> >made to build iomem.o, but iomem.c does not exist so this fails.
> >
> >Fixes: 1574ff1aae4f ("arm: include phys_to_virt.h and iomem.h in distribution")
> >Cc: Dave Young <dyoung@redhat.com>
> >Cc: Pratyush Anand <panand@redhat.com>
> >Signed-off-by: Simon Horman <horms@verge.net.au>
> >---
> >v2
> >* add headers directly to dist
> >---
> > kexec/arch/arm/Makefile | 5 ++---
> > 1 file changed, 2 insertions(+), 3 deletions(-)
> >
> >diff --git a/kexec/arch/arm/Makefile b/kexec/arch/arm/Makefile
> >index 871979e0ae26..4454f47a48df 100644
> >--- a/kexec/arch/arm/Makefile
> >+++ b/kexec/arch/arm/Makefile
> >@@ -27,9 +27,8 @@ arm_KEXEC_SRCS += $(libfdt_SRCS)
> >
> > arm_UIMAGE = kexec/kexec-uImage.c
> > arm_PHYS_TO_VIRT = kexec/arch/arm/phys_to_virt.c
> >-arm_PHYS_TO_VIRT += kexec/arch/arm/iomem.h
> >-arm_PHYS_TO_VIRT += kexec/arch/arm/phys_to_virt.h
> >
> > dist += kexec/arch/arm/Makefile $(arm_KEXEC_SRCS) $(arm_PHYS_TO_VIRT)	\
> >-	kexec/arch/arm/crashdump-arm.h kexec/arch/arm/kexec-arm.h	\
> >+	kexec/arch/arm/iomem.h kexec/arch/arm/phys_to_virt.h \
> >+	kexec/arch/arm/crashdump-arm.h kexec/arch/arm/kexec-arm.h \
> > 	kexec/arch/arm/include/arch/options.h
> >
> 
> Reviewed-by: Pratyush Anand <panand@redhat.com>

Thanks, applied.

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec