From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from userp1040.oracle.com ([156.151.31.81]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cb7Bf-0000GZ-7C for kexec@lists.infradead.org; Tue, 07 Feb 2017 14:56:09 +0000 Date: Tue, 7 Feb 2017 15:55:38 +0100 From: Daniel Kiper Subject: Re: [PATCH v2 01/12] crashdump/x86: Add print_crashkernel_region_size() function Message-ID: <20170207145538.GC13477@olila.local.net-space.pl> References: <1486410144-28595-1-git-send-email-eric.devolder@oracle.com> <1486410144-28595-2-git-send-email-eric.devolder@oracle.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1486410144-28595-2-git-send-email-eric.devolder@oracle.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Eric DeVolder Cc: andrew.cooper3@citrix.com, dyoung@redhat.com, horms@verge.net.au, kexec@lists.infradead.org, konrad.wilk@oracle.com On Mon, Feb 06, 2017 at 01:42:13PM -0600, Eric DeVolder wrote: > From: Daniel Kiper > > Crash kernel region size is available via sysfs on Linux running on > bare metal. However, this does not work when Linux runs as Xen dom0. > In this case Xen crash kernel region size should be established using > __HYPERVISOR_kexec_op hypercall (Linux kernel kexec functionality does > not make a lot of sense in Xen dom0). Sadly hypercalls are not easily > accessible using shell scripts or something like that. Potentially we > can check "xl dmesg" output for crashkernel option but this is not nice. > So, let's add this functionality, for Linux running on bare metal and > as Xen dom0, to kexec-tools. This way kdump scripts may establish crash > kernel region size in one way regardless of platform. All burden of > platform detection lies on kexec-tools. > > Figure (and unit) displayed by this new kexec-tools functionality is > the same as one taken from /sys/kernel/kexec_crash_size. > > This patch just adds print_crashkernel_region_size() function, which > prints crash kernel region size, for x86 arch. Next patches will add > same named function for other archs supported by kexec-tools. Last patch > of this series will export this functionality to the userspace via > separate kexec utility option. > > Signed-off-by: Daniel Kiper > Signed-off-by: Eric DeVolder > --- > v0: Interal version. > v1: Posted to kexec-tools mailing list > v2: Incorporated feedback: > - utilize the is_crashkernel_mem_reserved() function common in all archs > - for ppc and ppc64, utilize device-tree values to print size > - for unsupported architectures, print appropriate message Please do not blindly copy description of changes from patch #00. I think it makes more sense if you tell us what really has been changed in this patch. Otherwise LGTM. Daniel _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec