From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]) by casper.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1ckhka-00083Z-5V for kexec@lists.infradead.org; Mon, 06 Mar 2017 01:47:50 +0000 Date: Mon, 6 Mar 2017 09:46:45 +0800 From: Dave Young Subject: Re: [PATCH v3] Only print debug message when failed to serach for kernel symbol from /proc/kallsyms Message-ID: <20170306014645.GA3111@dhcp-128-65.nay.redhat.com> References: <1488513135-29611-1-git-send-email-bhe@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1488513135-29611-1-git-send-email-bhe@redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Baoquan He Cc: panand@redhat.com, horms@verge.net.au, kexec@lists.infradead.org, thgarnie@google.com On 03/03/17 at 11:52am, Baoquan He wrote: > Kernel symbol page_offset_base could be unavailable when mm KASLR code is > not compiled in kernel. It's unappropriate to print out error message > when failed to search for page_offset_base from /proc/kallsyms. Seems now > there is not a way to find out if mm KASLR is compiled in or not. An > alternative approach is only printing out debug message in get_kernel_sym > if failed to search a expected kernel symbol. > > Do it in this patch, a simple fix. > > Signed-off-by: Baoquan He > --- > kexec/arch/i386/crashdump-x86.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kexec/arch/i386/crashdump-x86.c b/kexec/arch/i386/crashdump-x86.c > index 88aeee3..c4cf201 100644 > --- a/kexec/arch/i386/crashdump-x86.c > +++ b/kexec/arch/i386/crashdump-x86.c > @@ -127,7 +127,7 @@ static unsigned long long get_kernel_sym(const char *symbol) > } > } > > - fprintf(stderr, "Cannot get kernel %s symbol address\n", symbol); > + dbgprintf("Cannot get kernel %s symbol address\n", symbol); > return 0; > } > > -- > 2.5.5 > It looks reasonable to me: Acked-by: Dave Young Thanks Dave _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec