From: Baoquan He <bhe@redhat.com>
To: Philip Prindeville <philipp_subx@redfish-solutions.com>
Cc: panand@redhat.com, kexec@lists.infradead.org, horms@verge.net.au,
Dave Young <dyoung@redhat.com>,
thgarnie@google.com
Subject: Re: [PATCH v3] Only print debug message when failed to serach for kernel symbol from /proc/kallsyms
Date: Thu, 9 Mar 2017 15:29:45 +0800 [thread overview]
Message-ID: <20170309072945.GI6570@x1> (raw)
In-Reply-To: <8DEC88E0-ED27-46FE-A992-DD24283E402C@redfish-solutions.com>
On 03/08/17 at 09:13pm, Philip Prindeville wrote:
> Inline…
>
>
> > On Mar 5, 2017, at 6:46 PM, Dave Young <dyoung@redhat.com> wrote:
> >
> > On 03/03/17 at 11:52am, Baoquan He wrote:
> >> Kernel symbol page_offset_base could be unavailable when mm KASLR code is
> >> not compiled in kernel. It's unappropriate to print out error message
>
> I subscribed to the list the day after this patch went out… Anyway, change to “inappropriate”.
Indeed, not sure if Simon want a repost.
Thanks, nice catch!
>
> -Philip
>
>
> >> when failed to search for page_offset_base from /proc/kallsyms. Seems now
> >> there is not a way to find out if mm KASLR is compiled in or not. An
> >> alternative approach is only printing out debug message in get_kernel_sym
> >> if failed to search a expected kernel symbol.
> >>
> >> Do it in this patch, a simple fix.
> >>
> >> Signed-off-by: Baoquan He <bhe@redhat.com>
> >> ---
> >> kexec/arch/i386/crashdump-x86.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/kexec/arch/i386/crashdump-x86.c b/kexec/arch/i386/crashdump-x86.c
> >> index 88aeee3..c4cf201 100644
> >> --- a/kexec/arch/i386/crashdump-x86.c
> >> +++ b/kexec/arch/i386/crashdump-x86.c
> >> @@ -127,7 +127,7 @@ static unsigned long long get_kernel_sym(const char *symbol)
> >> }
> >> }
> >>
> >> - fprintf(stderr, "Cannot get kernel %s symbol address\n", symbol);
> >> + dbgprintf("Cannot get kernel %s symbol address\n", symbol);
> >> return 0;
> >> }
> >>
> >> --
> >> 2.5.5
> >>
> >
> > It looks reasonable to me:
> >
> > Acked-by: Dave Young <dyoung@redhat.com>
> >
> > Thanks
> > Dave
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2017-03-09 7:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 3:52 [PATCH v3] Only print debug message when failed to serach for kernel symbol from /proc/kallsyms Baoquan He
2017-03-03 4:05 ` Pratyush Anand
2017-03-06 1:46 ` Dave Young
2017-03-09 4:13 ` Philip Prindeville
2017-03-09 7:29 ` Baoquan He [this message]
2017-03-10 9:14 ` Simon Horman
2017-03-10 9:23 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170309072945.GI6570@x1 \
--to=bhe@redhat.com \
--cc=dyoung@redhat.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=panand@redhat.com \
--cc=philipp_subx@redfish-solutions.com \
--cc=thgarnie@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox