From: Simon Horman <horms@verge.net.au>
To: Daniel Kiper <daniel.kiper@oracle.com>
Cc: andrew.cooper3@citrix.com,
Eric DeVolder <eric.devolder@oracle.com>,
kexec@lists.infradead.org, konrad.wilk@oracle.com
Subject: Re: [PATCH v0] Fix broken Xen support in configure.ac
Date: Sat, 8 Apr 2017 09:02:59 -0400 [thread overview]
Message-ID: <20170408130256.GA19677@verge.net.au> (raw)
In-Reply-To: <20170407195744.GP4372@olila.local.net-space.pl>
On Fri, Apr 07, 2017 at 09:57:44PM +0200, Daniel Kiper wrote:
> On Fri, Apr 07, 2017 at 09:13:06AM -0500, Eric DeVolder wrote:
> > Commit 2cf7cb9a "kexec: implemented XEN KEXEC STATUS to determine
> > if an image is loaded" added configure-time detection of the
> > kexec_status() call, but in doing so had the unintended side
> > effect of disabling support for Xen altogether due to the
> > missing HAVE_LIBXENCTRL=1. This corrects the broken behavior
> > while still maintaining the original intention of detecting
> > support for kexec_status() call.
>
> In general Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
> but two nitpicks.
>
> You do not need v0 in subject if you post first patch. Plain
> "[PATCH]" (of course without quotes) is sufficient.
>
> > ---
> > Broken behavior (HAVE_LIBXENCTRL is missing altogether):
> > ...
> > checking xenctrl.h usability... yes
> > checking xenctrl.h presence... yes
> > checking for xenctrl.h... yes
> > checking for xc_kexec_load in -lxenctrl... yes
> > checking for xc_kexec_status in -lxenctrl... yes
> >
> > in include/config.h:
> > /* The kexec_status call is available */
> > #define HAVE_KEXEC_CMD_STATUS 1
> >
> > Fixed behaviour (restores HAVE_LIBXENCTRL):
> > ...
> > checking xenctrl.h usability... yes
> > checking xenctrl.h presence... yes
> > checking for xenctrl.h... yes
> > checking for xc_kexec_load in -lxenctrl... yes
> > checking for xc_kexec_status in -lxenctrl... yes
> >
> > in include/config.h:
> > /* The kexec_status call is available */
> > #define HAVE_KEXEC_CMD_STATUS 1
> > /* Define to 1 if you have the `xenctrl' library (-lxenctrl). */
> > #define HAVE_LIBXENCTRL 1
> >
> > Reported-and-Tested-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > Signed-off-by: Eric DeVolder <eric.devolder@oracle.com>
>
> Reported-and-Tested-by, Signed-off-by et consortes should be just
> before first "---". Otherwise "git am" will drop all of them.
Thanks, I have applied this with the tags above.
Eric, please consider following Daniels advice for future postings.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
prev parent reply other threads:[~2017-04-08 13:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 14:13 [PATCH v0] Fix broken Xen support in configure.ac Eric DeVolder
2017-04-07 19:57 ` Daniel Kiper
2017-04-08 13:02 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170408130256.GA19677@verge.net.au \
--to=horms@verge.net.au \
--cc=andrew.cooper3@citrix.com \
--cc=daniel.kiper@oracle.com \
--cc=eric.devolder@oracle.com \
--cc=kexec@lists.infradead.org \
--cc=konrad.wilk@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox