From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1d3I0v-0006ZS-Vd for kexec@lists.infradead.org; Wed, 26 Apr 2017 08:09:31 +0000 Received: by mail-wm0-x241.google.com with SMTP id d79so31154954wmi.2 for ; Wed, 26 Apr 2017 01:09:09 -0700 (PDT) Date: Wed, 26 Apr 2017 10:09:05 +0200 From: Ingo Molnar Subject: Re: [PATCH v2 1/2] x86/mm/ident_map: Add PUD level 1GB page support Message-ID: <20170426080905.gvfjwpoknsgcrsyd@gmail.com> References: <1493192562-6669-1-git-send-email-xlpang@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1493192562-6669-1-git-send-email-xlpang@redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Xunlei Pang Cc: Yinghai Lu , x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Ingo Molnar , Borislav Petkov , Eric Biederman , Andy Lutomirski , "H. Peter Anvin" , akpm@linux-foundation.org, Dave Young , Thomas Gleixner * Xunlei Pang wrote: > The current kernel_ident_mapping_init() creates the identity > mapping using 2MB page(PMD level), this patch adds the 1GB > page(PUD level) support. > > This is useful on large machines to save some reserved memory > (as paging structures) in the kdump case when kexec setups up > identity mappings before booting into the new kernel. > > We will utilize this new support in the following patch. Well, the primary advantage would be better TLB coverage/performance, because we'd utilize 1GB TLBs instead of 2MB ones, right? Any kexec fallout is secondary. And I'd like to hear more about the primary advantage: what are the effects of this change on a typical test system you have access to: - For example what percentage of the identity mapping was 4K mapped (if any) and 2MB mapped - and how did this change due to the patch - how many 2MB mappings remained and how many 1GB mappings were added? - Is there anything else we could do to improve the in-RAM layout of kernel data structures. For example IIRC the CPU breaks up all TLBs under 2MB physical into 4K TLBs. Is this the current limit and could we just reserve all that space and not use it for anything important? 2MB of RAM wasted is a very small amount of space, compared to the potential performance advantages. > void *(*alloc_pgt_page)(void *); /* allocate buf for page table */ > void *context; /* context for alloc_pgt_page */ > - unsigned long pmd_flag; /* page flag for PMD entry */ > + unsigned long page_flag; /* page flag for PMD or PUD entry */ > unsigned long offset; /* ident mapping offset */ > + bool direct_gbpages; /* PUD level 1GB page support */ Doesn't follow the existing alignment. Thanks, Ingo _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec