From: Michael Holzheu <holzheu@linux.vnet.ibm.com>
To: Atsushi Kumagai <ats-kumagai@wm.jp.nec.com>
Cc: "kexec@lists.infradead.org" <kexec@lists.infradead.org>,
Zaslonko Mikhail <zaslonko@linux.vnet.ibm.com>
Subject: Re: [PATCH] makedumpfile: Error on re-filtering the dump file with no free pages
Date: Fri, 19 May 2017 09:27:45 +0200 [thread overview]
Message-ID: <20170519092745.0bc956a3@TP-holzheu> (raw)
In-Reply-To: <0910DD04CBD6DE4193FCF86B9C00BE9701ED9104@BPXM01GP.gisp.nec.co.jp>
Am Fri, 19 May 2017 02:35:40 +0000
schrieb Atsushi Kumagai <ats-kumagai@wm.jp.nec.com>:
> >> Hello Zaslonko,
> >>
[snip]
> >Since we don't have the symbols in VMCOREINFO (and IMHO don't need it?) the
> >exclude_free_page() functions fails with the described error message.
>
> It seems that it's better if I update the condition check of exclude_free_page()
> for recent kernels, but those symbols are unnecessary in this case as you thought
> anyway. exclude_free_page() shouldn't be called for recent kernels, I don't think
> this is an actual problem.
>
> >So our fix is to adjust the info->level before setup_page_is_buddy() is called.
>
> I'm sure this fix is reasonable, I'll merge this into v1.6.2.
Thanks!
Michael
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
prev parent reply other threads:[~2017-05-19 7:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 15:02 [PATCH] makedumpfile: Error on re-filtering the dump file with no free pages Zaslonko Mikhail
2017-05-18 4:37 ` Atsushi Kumagai
2017-05-18 12:02 ` Michael Holzheu
2017-05-19 2:35 ` Atsushi Kumagai
2017-05-19 7:27 ` Michael Holzheu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170519092745.0bc956a3@TP-holzheu \
--to=holzheu@linux.vnet.ibm.com \
--cc=ats-kumagai@wm.jp.nec.com \
--cc=kexec@lists.infradead.org \
--cc=zaslonko@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox