From: "Dmitry V. Levin" <ldv@altlinux.org>
To: Mikko Rapeli <mikko.rapeli@iki.fi>
Cc: linux-api@vger.kernel.org, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org,
Eric Biederman <ebiederm@xmission.com>
Subject: Re: [PATCH v06 21/36] uapi linux/kexec.h: use __kernel_size_t instead of size_t
Date: Wed, 9 Aug 2017 02:15:43 +0300 [thread overview]
Message-ID: <20170808231543.GI10552@altlinux.org> (raw)
In-Reply-To: <20170806164428.2273-22-mikko.rapeli@iki.fi>
[-- Attachment #1.1: Type: text/plain, Size: 962 bytes --]
On Sun, Aug 06, 2017 at 06:44:12PM +0200, Mikko Rapeli wrote:
> Fixes userspace compilation error:
>
> error: unknown type name ‘size_t’
> size_t bufsz;
>
> Signed-off-by: Mikko Rapeli <mikko.rapeli@iki.fi>
> Cc: kexec@lists.infradead.org
> Cc: Eric Biederman <ebiederm@xmission.com>
> ---
> include/uapi/linux/kexec.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/uapi/linux/kexec.h b/include/uapi/linux/kexec.h
> index aae5ebf2022b..f964d83b2757 100644
> --- a/include/uapi/linux/kexec.h
> +++ b/include/uapi/linux/kexec.h
> @@ -51,9 +51,9 @@
> */
> struct kexec_segment {
> const void *buf;
> - size_t bufsz;
> + __kernel_size_t bufsz;
> const void *mem;
> - size_t memsz;
> + __kernel_size_t memsz;
No, this is definitely wrong as it breaks x32.
I submitted an alternative fix some time ago, see
http://lkml.kernel.org/r/20170222224646.GC14311@altlinux.org
--
ldv
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
[-- Attachment #2: Type: text/plain, Size: 143 bytes --]
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2017-08-08 23:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170806164428.2273-1-mikko.rapeli@iki.fi>
2017-08-06 16:44 ` [PATCH v06 21/36] uapi linux/kexec.h: use __kernel_size_t instead of size_t Mikko Rapeli
2017-08-07 15:12 ` Arnd Bergmann
2017-08-08 23:15 ` Dmitry V. Levin [this message]
[not found] ` <20170808225739.GF10552@altlinux.org>
[not found] ` <20170808225417.GE10552@altlinux.org>
[not found] ` <20170808225026.GD10552@altlinux.org>
[not found] ` <20170808224555.GC10552@altlinux.org>
[not found] ` <20170808224253.GB10552@altlinux.org>
[not found] ` <20170808223420.GA10552@altlinux.org>
2017-08-09 7:18 ` [PATCH v06 05/36] uapi linux/sysctl.h: " Mikko Rapeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170808231543.GI10552@altlinux.org \
--to=ldv@altlinux.org \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikko.rapeli@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox