Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: AKASHI Takahiro <takahiro.akashi@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
	herbert@gondor.apana.org.au, bhe@redhat.com,
	ard.biesheuvel@linaro.org, catalin.marinas@arm.com,
	will.deacon@arm.com, linux-kernel@vger.kernel.org,
	kexec@lists.infradead.org, dhowells@redhat.com,
	AKASHI Takahiro <takahiro.akashi@linaro.org>,
	arnd@arndb.de, kbuild-all@01.org, mpe@ellerman.id.au,
	bauerman@linux.vnet.ibm.com, akpm@linux-foundation.org,
	dyoung@redhat.com, davem@davemloft.net, vgoyal@redhat.com
Subject: Re: [PATCH v4 03/10] kexec_file: factor out arch_kexec_kernel_*() from x86, powerpc
Date: Wed, 4 Oct 2017 17:40:03 +0800	[thread overview]
Message-ID: <201710041753.sJjSW3iY%fengguang.wu@intel.com> (raw)
In-Reply-To: <20171002061431.11117-4-takahiro.akashi@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 3850 bytes --]

Hi AKASHI,

[auto build test ERROR on arm64/for-next/core]
[also build test ERROR on v4.14-rc3 next-20170929]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/AKASHI-Takahiro/arm64-kexec-add-kexec_file_load-support/20171004-163130
base:   https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: x86_64-randconfig-x000-201740 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   kernel/kexec_file.c: In function 'kimage_file_post_load_cleanup':
>> kernel/kexec_file.c:152:2: error: implicit declaration of function 'arch_kimage_file_post_load_cleanup' [-Werror=implicit-function-declaration]
     arch_kimage_file_post_load_cleanup(image);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/arch_kimage_file_post_load_cleanup +152 kernel/kexec_file.c

a43cac0d9 Dave Young 2015-09-09  126  
a43cac0d9 Dave Young 2015-09-09  127  /*
a43cac0d9 Dave Young 2015-09-09  128   * Free up memory used by kernel, initrd, and command line. This is temporary
a43cac0d9 Dave Young 2015-09-09  129   * memory allocation which is not needed any more after these buffers have
a43cac0d9 Dave Young 2015-09-09  130   * been loaded into separate segments and have been copied elsewhere.
a43cac0d9 Dave Young 2015-09-09  131   */
a43cac0d9 Dave Young 2015-09-09  132  void kimage_file_post_load_cleanup(struct kimage *image)
a43cac0d9 Dave Young 2015-09-09  133  {
a43cac0d9 Dave Young 2015-09-09  134  	struct purgatory_info *pi = &image->purgatory_info;
a43cac0d9 Dave Young 2015-09-09  135  
a43cac0d9 Dave Young 2015-09-09  136  	vfree(image->kernel_buf);
a43cac0d9 Dave Young 2015-09-09  137  	image->kernel_buf = NULL;
a43cac0d9 Dave Young 2015-09-09  138  
a43cac0d9 Dave Young 2015-09-09  139  	vfree(image->initrd_buf);
a43cac0d9 Dave Young 2015-09-09  140  	image->initrd_buf = NULL;
a43cac0d9 Dave Young 2015-09-09  141  
a43cac0d9 Dave Young 2015-09-09  142  	kfree(image->cmdline_buf);
a43cac0d9 Dave Young 2015-09-09  143  	image->cmdline_buf = NULL;
a43cac0d9 Dave Young 2015-09-09  144  
a43cac0d9 Dave Young 2015-09-09  145  	vfree(pi->purgatory_buf);
a43cac0d9 Dave Young 2015-09-09  146  	pi->purgatory_buf = NULL;
a43cac0d9 Dave Young 2015-09-09  147  
a43cac0d9 Dave Young 2015-09-09  148  	vfree(pi->sechdrs);
a43cac0d9 Dave Young 2015-09-09  149  	pi->sechdrs = NULL;
a43cac0d9 Dave Young 2015-09-09  150  
a43cac0d9 Dave Young 2015-09-09  151  	/* See if architecture has anything to cleanup post load */
a43cac0d9 Dave Young 2015-09-09 @152  	arch_kimage_file_post_load_cleanup(image);
a43cac0d9 Dave Young 2015-09-09  153  
a43cac0d9 Dave Young 2015-09-09  154  	/*
a43cac0d9 Dave Young 2015-09-09  155  	 * Above call should have called into bootloader to free up
a43cac0d9 Dave Young 2015-09-09  156  	 * any data stored in kimage->image_loader_data. It should
a43cac0d9 Dave Young 2015-09-09  157  	 * be ok now to free it up.
a43cac0d9 Dave Young 2015-09-09  158  	 */
a43cac0d9 Dave Young 2015-09-09  159  	kfree(image->image_loader_data);
a43cac0d9 Dave Young 2015-09-09  160  	image->image_loader_data = NULL;
a43cac0d9 Dave Young 2015-09-09  161  }
a43cac0d9 Dave Young 2015-09-09  162  

:::::: The code at line 152 was first introduced by commit
:::::: a43cac0d9dc2073ff2245a171429ddbe1accece7 kexec: split kexec_file syscall code to kexec_file.c

:::::: TO: Dave Young <dyoung@redhat.com>
:::::: CC: Linus Torvalds <torvalds@linux-foundation.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 27479 bytes --]

[-- Attachment #3: Type: text/plain, Size: 143 bytes --]

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  parent reply	other threads:[~2017-10-04  9:40 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-02  6:14 [PATCH v4 00/10] arm64: kexec: add kexec_file_load() support AKASHI Takahiro
2017-10-02  6:14 ` [PATCH v4 01/10] include: pe.h: remove message[] from mz header definition AKASHI Takahiro
2017-10-02  6:14 ` [PATCH v4 02/10] resource: add walk_system_ram_res_rev() AKASHI Takahiro
2017-10-05  9:36   ` Julien Thierry
2017-10-06  7:01     ` AKASHI Takahiro
2017-10-02  6:14 ` [PATCH v4 03/10] kexec_file: factor out arch_kexec_kernel_*() from x86, powerpc AKASHI Takahiro
2017-10-04  9:08   ` kbuild test robot
2017-10-04  9:40   ` kbuild test robot [this message]
2017-10-05 10:21   ` Julien Thierry
2017-10-06  7:06     ` AKASHI Takahiro
2017-10-02  6:14 ` [PATCH v4 04/10] kexec_file: factor out crashdump elf header function from x86 AKASHI Takahiro
2017-10-02  6:14 ` [PATCH v4 05/10] asm-generic: add kexec_file_load system call to unistd.h AKASHI Takahiro
2017-10-02  6:14 ` [PATCH v4 06/10] arm64: kexec_file: create purgatory AKASHI Takahiro
2017-10-02  6:14 ` [PATCH v4 07/10] arm64: kexec_file: load initrd, device-tree and purgatory segments AKASHI Takahiro
2017-10-02  6:14 ` [PATCH v4 08/10] arm64: kexec_file: set up for crash dump adding elf core header AKASHI Takahiro
2017-10-05 14:15   ` Julien Thierry
2017-10-06  7:11     ` AKASHI Takahiro
2017-10-02  6:14 ` [PATCH v4 09/10] arm64: enable KEXEC_FILE config AKASHI Takahiro
2017-10-02  6:14 ` [PATCH v4 10/10] arm64: kexec_file: add Image format support AKASHI Takahiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201710041753.sJjSW3iY%fengguang.wu@intel.com \
    --to=lkp@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=ard.biesheuvel@linaro.org \
    --cc=arnd@arndb.de \
    --cc=bauerman@linux.vnet.ibm.com \
    --cc=bhe@redhat.com \
    --cc=catalin.marinas@arm.com \
    --cc=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=dyoung@redhat.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=kbuild-all@01.org \
    --cc=kexec@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=takahiro.akashi@linaro.org \
    --cc=vgoyal@redhat.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox