* RE: [PATCH] handle renamed init_level4_pgt -> init_top_pgt @ 2017-11-07 10:20 Atsushi Kumagai 2017-12-08 8:15 ` Atsushi Kumagai 0 siblings, 1 reply; 22+ messages in thread From: Atsushi Kumagai @ 2017-11-07 10:20 UTC (permalink / raw) To: Jeff Mahoney; +Cc: Keiichirou Suzuki, kexec@lists.infradead.org >Linux 4.13 renamed init_level4_pgt to init_top_pgt in preparation for >introducing 5-level page tables. This patch follows the rename if >the lookup for init_level4_pgt fails. It also checks to see if >5-level page tables are enabled and bails if it discovers they are. Thanks Jeff, but could you rebase it on the current devel branch ? vtop4 for x86_64 was modified in the commit below: commit 8c89727155f4994b4e75a659e28e5eff16ff6cbc Author: Takao Indoh <indou.takao@jp.fujitsu.com> Date: Thu Oct 26 20:32:54 2017 +0900 [PATCH v3 2/4] Introduce vtop4_x86_64_pagetable Regards, Atsushi Kumagai >Signed-off-by: Jeff Mahoney <jeffm@suse.com> >--- > arch/x86_64.c | 24 +++++++++++++++++++++--- > makedumpfile.c | 6 ++++++ > makedumpfile.h | 2 ++ > 3 files changed, 29 insertions(+), 3 deletions(-) > >diff --git a/arch/x86_64.c b/arch/x86_64.c >index 08dd6b2..9b09035 100644 >--- a/arch/x86_64.c >+++ b/arch/x86_64.c >@@ -259,16 +259,26 @@ vtop4_x86_64(unsigned long vaddr) > { > unsigned long page_dir, pml4, pgd_paddr, pgd_pte, pmd_paddr, pmd_pte; > unsigned long pte_paddr, pte; >+ unsigned long init_level4_pgt; > >- if (SYMBOL(init_level4_pgt) == NOT_FOUND_SYMBOL) { >+ if (SYMBOL(init_level4_pgt) != NOT_FOUND_SYMBOL) >+ init_level4_pgt = SYMBOL(init_level4_pgt); >+ else if (SYMBOL(init_top_pgt) != NOT_FOUND_SYMBOL) >+ init_level4_pgt = SYMBOL(init_top_pgt); >+ else { > ERRMSG("Can't get the symbol of init_level4_pgt.\n"); > return NOT_PADDR; > } > >+ if (SYMBOL(level4_kernel_pgt) != NOT_FOUND_SYMBOL) { >+ ERRMSG("Kernel is built with 5-level page tables\n"); >+ return NOT_PADDR; >+ } >+ > /* > * Get PGD. > */ >- page_dir = SYMBOL(init_level4_pgt) - __START_KERNEL_map + info->phys_base; >+ page_dir = init_level4_pgt - __START_KERNEL_map + info->phys_base; > if (is_xen_memory()) { > page_dir = ptom_xen(page_dir); > if (page_dir == NOT_PADDR) >@@ -549,8 +559,16 @@ find_vmemmap_x86_64() > struct vmap_pfns *vmapp, *vmaphead = NULL, *cur, *tail; > > init_level4_pgt = SYMBOL(init_level4_pgt); >+ if (init_level4_pgt == NOT_FOUND_SYMBOL) >+ init_level4_pgt = SYMBOL(init_top_pgt); >+ > if (init_level4_pgt == NOT_FOUND_SYMBOL) { >- ERRMSG("init_level4_pgt not found\n"); >+ ERRMSG("init_level4_pgt/init_top_pgt not found\n"); >+ return FAILED; >+ } >+ >+ if (SYMBOL(level4_kernel_pgt) != NOT_FOUND_SYMBOL) { >+ ERRMSG("kernel is configured for 5-level page tables\n"); > return FAILED; > } > pagestructsize = size_table.page; >diff --git a/makedumpfile.c b/makedumpfile.c >index f85003a..6e5ec34 100644 >--- a/makedumpfile.c >+++ b/makedumpfile.c >@@ -1486,6 +1486,8 @@ get_symbol_info(void) > SYMBOL_INIT(_stext, "_stext"); > SYMBOL_INIT(swapper_pg_dir, "swapper_pg_dir"); > SYMBOL_INIT(init_level4_pgt, "init_level4_pgt"); >+ SYMBOL_INIT(level4_kernel_pgt, "level4_kernel_pgt"); >+ SYMBOL_INIT(init_top_pgt, "init_top_pgt"); > SYMBOL_INIT(vmlist, "vmlist"); > SYMBOL_INIT(vmap_area_list, "vmap_area_list"); > SYMBOL_INIT(node_online_map, "node_online_map"); >@@ -2105,6 +2107,8 @@ write_vmcoreinfo_data(void) > WRITE_SYMBOL("_stext", _stext); > WRITE_SYMBOL("swapper_pg_dir", swapper_pg_dir); > WRITE_SYMBOL("init_level4_pgt", init_level4_pgt); >+ WRITE_SYMBOL("level4_kernel_pgt", level4_kernel_pgt); >+ WRITE_SYMBOL("init_top_pgt", init_top_pgt); > WRITE_SYMBOL("vmlist", vmlist); > WRITE_SYMBOL("vmap_area_list", vmap_area_list); > WRITE_SYMBOL("node_online_map", node_online_map); >@@ -2500,6 +2504,8 @@ read_vmcoreinfo(void) > READ_SYMBOL("_stext", _stext); > READ_SYMBOL("swapper_pg_dir", swapper_pg_dir); > READ_SYMBOL("init_level4_pgt", init_level4_pgt); >+ READ_SYMBOL("level4_kernel_pgt", level4_kernel_pgt); >+ READ_SYMBOL("init_top_pgt", init_top_pgt); > READ_SYMBOL("vmlist", vmlist); > READ_SYMBOL("vmap_area_list", vmap_area_list); > READ_SYMBOL("node_online_map", node_online_map); >diff --git a/makedumpfile.h b/makedumpfile.h >index 8a05794..9357e47 100644 >--- a/makedumpfile.h >+++ b/makedumpfile.h >@@ -1517,6 +1517,8 @@ struct symbol_table { > unsigned long long _stext; > unsigned long long swapper_pg_dir; > unsigned long long init_level4_pgt; >+ unsigned long long level4_kernel_pgt; >+ unsigned long long init_top_pgt; > unsigned long long vmlist; > unsigned long long vmap_area_list; > unsigned long long phys_base; > > >-- >Jeff Mahoney >SUSE Labs _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec ^ permalink raw reply [flat|nested] 22+ messages in thread
* RE: [PATCH] handle renamed init_level4_pgt -> init_top_pgt 2017-11-07 10:20 [PATCH] handle renamed init_level4_pgt -> init_top_pgt Atsushi Kumagai @ 2017-12-08 8:15 ` Atsushi Kumagai 2017-12-20 7:24 ` Dave Young 0 siblings, 1 reply; 22+ messages in thread From: Atsushi Kumagai @ 2017-12-08 8:15 UTC (permalink / raw) To: Jeff Mahoney; +Cc: Keiichirou Suzuki, kexec@lists.infradead.org >>Linux 4.13 renamed init_level4_pgt to init_top_pgt in preparation for >>introducing 5-level page tables. This patch follows the rename if >>the lookup for init_level4_pgt fails. It also checks to see if >>5-level page tables are enabled and bails if it discovers they are. > >Thanks Jeff, but could you rebase it on the current devel branch ? >vtop4 for x86_64 was modified in the commit below: > >commit 8c89727155f4994b4e75a659e28e5eff16ff6cbc >Author: Takao Indoh <indou.takao@jp.fujitsu.com> >Date: Thu Oct 26 20:32:54 2017 +0900 > > [PATCH v3 2/4] Introduce vtop4_x86_64_pagetable > >Regards, >Atsushi Kumagai I rebased that and updated the devel branch: https://sourceforge.net/p/makedumpfile/code/ci/97e156b493c46fabfc4b136ab834a6495166ac66/ I'll merge it into v1.6.3 if you have no comment. Thanks, Atsushi Kumagai >>Signed-off-by: Jeff Mahoney <jeffm@suse.com> >>--- >> arch/x86_64.c | 24 +++++++++++++++++++++--- >> makedumpfile.c | 6 ++++++ >> makedumpfile.h | 2 ++ >> 3 files changed, 29 insertions(+), 3 deletions(-) >> >>diff --git a/arch/x86_64.c b/arch/x86_64.c >>index 08dd6b2..9b09035 100644 >>--- a/arch/x86_64.c >>+++ b/arch/x86_64.c >>@@ -259,16 +259,26 @@ vtop4_x86_64(unsigned long vaddr) >> { >> unsigned long page_dir, pml4, pgd_paddr, pgd_pte, pmd_paddr, pmd_pte; >> unsigned long pte_paddr, pte; >>+ unsigned long init_level4_pgt; >> >>- if (SYMBOL(init_level4_pgt) == NOT_FOUND_SYMBOL) { >>+ if (SYMBOL(init_level4_pgt) != NOT_FOUND_SYMBOL) >>+ init_level4_pgt = SYMBOL(init_level4_pgt); >>+ else if (SYMBOL(init_top_pgt) != NOT_FOUND_SYMBOL) >>+ init_level4_pgt = SYMBOL(init_top_pgt); >>+ else { >> ERRMSG("Can't get the symbol of init_level4_pgt.\n"); >> return NOT_PADDR; >> } >> >>+ if (SYMBOL(level4_kernel_pgt) != NOT_FOUND_SYMBOL) { >>+ ERRMSG("Kernel is built with 5-level page tables\n"); >>+ return NOT_PADDR; >>+ } >>+ >> /* >> * Get PGD. >> */ >>- page_dir = SYMBOL(init_level4_pgt) - __START_KERNEL_map + info->phys_base; >>+ page_dir = init_level4_pgt - __START_KERNEL_map + info->phys_base; >> if (is_xen_memory()) { >> page_dir = ptom_xen(page_dir); >> if (page_dir == NOT_PADDR) >>@@ -549,8 +559,16 @@ find_vmemmap_x86_64() >> struct vmap_pfns *vmapp, *vmaphead = NULL, *cur, *tail; >> >> init_level4_pgt = SYMBOL(init_level4_pgt); >>+ if (init_level4_pgt == NOT_FOUND_SYMBOL) >>+ init_level4_pgt = SYMBOL(init_top_pgt); >>+ >> if (init_level4_pgt == NOT_FOUND_SYMBOL) { >>- ERRMSG("init_level4_pgt not found\n"); >>+ ERRMSG("init_level4_pgt/init_top_pgt not found\n"); >>+ return FAILED; >>+ } >>+ >>+ if (SYMBOL(level4_kernel_pgt) != NOT_FOUND_SYMBOL) { >>+ ERRMSG("kernel is configured for 5-level page tables\n"); >> return FAILED; >> } >> pagestructsize = size_table.page; >>diff --git a/makedumpfile.c b/makedumpfile.c >>index f85003a..6e5ec34 100644 >>--- a/makedumpfile.c >>+++ b/makedumpfile.c >>@@ -1486,6 +1486,8 @@ get_symbol_info(void) >> SYMBOL_INIT(_stext, "_stext"); >> SYMBOL_INIT(swapper_pg_dir, "swapper_pg_dir"); >> SYMBOL_INIT(init_level4_pgt, "init_level4_pgt"); >>+ SYMBOL_INIT(level4_kernel_pgt, "level4_kernel_pgt"); >>+ SYMBOL_INIT(init_top_pgt, "init_top_pgt"); >> SYMBOL_INIT(vmlist, "vmlist"); >> SYMBOL_INIT(vmap_area_list, "vmap_area_list"); >> SYMBOL_INIT(node_online_map, "node_online_map"); >>@@ -2105,6 +2107,8 @@ write_vmcoreinfo_data(void) >> WRITE_SYMBOL("_stext", _stext); >> WRITE_SYMBOL("swapper_pg_dir", swapper_pg_dir); >> WRITE_SYMBOL("init_level4_pgt", init_level4_pgt); >>+ WRITE_SYMBOL("level4_kernel_pgt", level4_kernel_pgt); >>+ WRITE_SYMBOL("init_top_pgt", init_top_pgt); >> WRITE_SYMBOL("vmlist", vmlist); >> WRITE_SYMBOL("vmap_area_list", vmap_area_list); >> WRITE_SYMBOL("node_online_map", node_online_map); >>@@ -2500,6 +2504,8 @@ read_vmcoreinfo(void) >> READ_SYMBOL("_stext", _stext); >> READ_SYMBOL("swapper_pg_dir", swapper_pg_dir); >> READ_SYMBOL("init_level4_pgt", init_level4_pgt); >>+ READ_SYMBOL("level4_kernel_pgt", level4_kernel_pgt); >>+ READ_SYMBOL("init_top_pgt", init_top_pgt); >> READ_SYMBOL("vmlist", vmlist); >> READ_SYMBOL("vmap_area_list", vmap_area_list); >> READ_SYMBOL("node_online_map", node_online_map); >>diff --git a/makedumpfile.h b/makedumpfile.h >>index 8a05794..9357e47 100644 >>--- a/makedumpfile.h >>+++ b/makedumpfile.h >>@@ -1517,6 +1517,8 @@ struct symbol_table { >> unsigned long long _stext; >> unsigned long long swapper_pg_dir; >> unsigned long long init_level4_pgt; >>+ unsigned long long level4_kernel_pgt; >>+ unsigned long long init_top_pgt; >> unsigned long long vmlist; >> unsigned long long vmap_area_list; >> unsigned long long phys_base; >> >> >>-- >>Jeff Mahoney >>SUSE Labs > > > >_______________________________________________ >kexec mailing list >kexec@lists.infradead.org >http://lists.infradead.org/mailman/listinfo/kexec _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH] handle renamed init_level4_pgt -> init_top_pgt 2017-12-08 8:15 ` Atsushi Kumagai @ 2017-12-20 7:24 ` Dave Young 2017-12-21 8:48 ` Atsushi Kumagai 0 siblings, 1 reply; 22+ messages in thread From: Dave Young @ 2017-12-20 7:24 UTC (permalink / raw) To: Atsushi Kumagai Cc: Keiichirou Suzuki, Jeff Mahoney, kexec@lists.infradead.org On 12/08/17 at 08:15am, Atsushi Kumagai wrote: > >>Linux 4.13 renamed init_level4_pgt to init_top_pgt in preparation for > >>introducing 5-level page tables. This patch follows the rename if > >>the lookup for init_level4_pgt fails. It also checks to see if > >>5-level page tables are enabled and bails if it discovers they are. > > > >Thanks Jeff, but could you rebase it on the current devel branch ? > >vtop4 for x86_64 was modified in the commit below: > > > >commit 8c89727155f4994b4e75a659e28e5eff16ff6cbc > >Author: Takao Indoh <indou.takao@jp.fujitsu.com> > >Date: Thu Oct 26 20:32:54 2017 +0900 > > > > [PATCH v3 2/4] Introduce vtop4_x86_64_pagetable > > > >Regards, > >Atsushi Kumagai > > I rebased that and updated the devel branch: > > https://sourceforge.net/p/makedumpfile/code/ci/97e156b493c46fabfc4b136ab834a6495166ac66/ > > I'll merge it into v1.6.3 if you have no comment. [dyoung@dhcp-*-* makedumpfile]$ sudo ./makedumpfile -l -d 31 /mnt/vmcore/vmcore /tmp/vmcore.1 The kernel version is not supported. The makedumpfile operation may be incomplete. Checking for memory holes : [100.0 %] | __vtop4_x86_64: Can't get a valid pte. readmem: Can't convert a virtual address(ffff88007ebb1000) to physical address. readmem: type_addr: 0, addr:ffff88007ebb1000, size:32768 __exclude_unnecessary_pages: Can't read the buffer of struct page. create_2nd_bitmap: Can't exclude unnecessary pages. makedumpfile Failed. If you need the vmcore for debugging please let me know, my test is just a normal test in kvm guest. > > Thanks, > Atsushi Kumagai > > >>Signed-off-by: Jeff Mahoney <jeffm@suse.com> > >>--- > >> arch/x86_64.c | 24 +++++++++++++++++++++--- > >> makedumpfile.c | 6 ++++++ > >> makedumpfile.h | 2 ++ > >> 3 files changed, 29 insertions(+), 3 deletions(-) > >> > >>diff --git a/arch/x86_64.c b/arch/x86_64.c > >>index 08dd6b2..9b09035 100644 > >>--- a/arch/x86_64.c > >>+++ b/arch/x86_64.c > >>@@ -259,16 +259,26 @@ vtop4_x86_64(unsigned long vaddr) > >> { > >> unsigned long page_dir, pml4, pgd_paddr, pgd_pte, pmd_paddr, pmd_pte; > >> unsigned long pte_paddr, pte; > >>+ unsigned long init_level4_pgt; > >> > >>- if (SYMBOL(init_level4_pgt) == NOT_FOUND_SYMBOL) { > >>+ if (SYMBOL(init_level4_pgt) != NOT_FOUND_SYMBOL) > >>+ init_level4_pgt = SYMBOL(init_level4_pgt); > >>+ else if (SYMBOL(init_top_pgt) != NOT_FOUND_SYMBOL) > >>+ init_level4_pgt = SYMBOL(init_top_pgt); > >>+ else { > >> ERRMSG("Can't get the symbol of init_level4_pgt.\n"); > >> return NOT_PADDR; > >> } > >> > >>+ if (SYMBOL(level4_kernel_pgt) != NOT_FOUND_SYMBOL) { > >>+ ERRMSG("Kernel is built with 5-level page tables\n"); > >>+ return NOT_PADDR; > >>+ } > >>+ > >> /* > >> * Get PGD. > >> */ > >>- page_dir = SYMBOL(init_level4_pgt) - __START_KERNEL_map + info->phys_base; > >>+ page_dir = init_level4_pgt - __START_KERNEL_map + info->phys_base; > >> if (is_xen_memory()) { > >> page_dir = ptom_xen(page_dir); > >> if (page_dir == NOT_PADDR) > >>@@ -549,8 +559,16 @@ find_vmemmap_x86_64() > >> struct vmap_pfns *vmapp, *vmaphead = NULL, *cur, *tail; > >> > >> init_level4_pgt = SYMBOL(init_level4_pgt); > >>+ if (init_level4_pgt == NOT_FOUND_SYMBOL) > >>+ init_level4_pgt = SYMBOL(init_top_pgt); > >>+ > >> if (init_level4_pgt == NOT_FOUND_SYMBOL) { > >>- ERRMSG("init_level4_pgt not found\n"); > >>+ ERRMSG("init_level4_pgt/init_top_pgt not found\n"); > >>+ return FAILED; > >>+ } > >>+ > >>+ if (SYMBOL(level4_kernel_pgt) != NOT_FOUND_SYMBOL) { > >>+ ERRMSG("kernel is configured for 5-level page tables\n"); > >> return FAILED; > >> } > >> pagestructsize = size_table.page; > >>diff --git a/makedumpfile.c b/makedumpfile.c > >>index f85003a..6e5ec34 100644 > >>--- a/makedumpfile.c > >>+++ b/makedumpfile.c > >>@@ -1486,6 +1486,8 @@ get_symbol_info(void) > >> SYMBOL_INIT(_stext, "_stext"); > >> SYMBOL_INIT(swapper_pg_dir, "swapper_pg_dir"); > >> SYMBOL_INIT(init_level4_pgt, "init_level4_pgt"); > >>+ SYMBOL_INIT(level4_kernel_pgt, "level4_kernel_pgt"); > >>+ SYMBOL_INIT(init_top_pgt, "init_top_pgt"); > >> SYMBOL_INIT(vmlist, "vmlist"); > >> SYMBOL_INIT(vmap_area_list, "vmap_area_list"); > >> SYMBOL_INIT(node_online_map, "node_online_map"); > >>@@ -2105,6 +2107,8 @@ write_vmcoreinfo_data(void) > >> WRITE_SYMBOL("_stext", _stext); > >> WRITE_SYMBOL("swapper_pg_dir", swapper_pg_dir); > >> WRITE_SYMBOL("init_level4_pgt", init_level4_pgt); > >>+ WRITE_SYMBOL("level4_kernel_pgt", level4_kernel_pgt); > >>+ WRITE_SYMBOL("init_top_pgt", init_top_pgt); > >> WRITE_SYMBOL("vmlist", vmlist); > >> WRITE_SYMBOL("vmap_area_list", vmap_area_list); > >> WRITE_SYMBOL("node_online_map", node_online_map); > >>@@ -2500,6 +2504,8 @@ read_vmcoreinfo(void) > >> READ_SYMBOL("_stext", _stext); > >> READ_SYMBOL("swapper_pg_dir", swapper_pg_dir); > >> READ_SYMBOL("init_level4_pgt", init_level4_pgt); > >>+ READ_SYMBOL("level4_kernel_pgt", level4_kernel_pgt); > >>+ READ_SYMBOL("init_top_pgt", init_top_pgt); > >> READ_SYMBOL("vmlist", vmlist); > >> READ_SYMBOL("vmap_area_list", vmap_area_list); > >> READ_SYMBOL("node_online_map", node_online_map); > >>diff --git a/makedumpfile.h b/makedumpfile.h > >>index 8a05794..9357e47 100644 > >>--- a/makedumpfile.h > >>+++ b/makedumpfile.h > >>@@ -1517,6 +1517,8 @@ struct symbol_table { > >> unsigned long long _stext; > >> unsigned long long swapper_pg_dir; > >> unsigned long long init_level4_pgt; > >>+ unsigned long long level4_kernel_pgt; > >>+ unsigned long long init_top_pgt; > >> unsigned long long vmlist; > >> unsigned long long vmap_area_list; > >> unsigned long long phys_base; > >> > >> > >>-- > >>Jeff Mahoney > >>SUSE Labs > > > > > > > >_______________________________________________ > >kexec mailing list > >kexec@lists.infradead.org > >http://lists.infradead.org/mailman/listinfo/kexec > > > _______________________________________________ > kexec mailing list > kexec@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/kexec Thanks Dave _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec ^ permalink raw reply [flat|nested] 22+ messages in thread
* RE: [PATCH] handle renamed init_level4_pgt -> init_top_pgt 2017-12-20 7:24 ` Dave Young @ 2017-12-21 8:48 ` Atsushi Kumagai 2017-12-22 4:54 ` Dave Young 0 siblings, 1 reply; 22+ messages in thread From: Atsushi Kumagai @ 2017-12-21 8:48 UTC (permalink / raw) To: Dave Young; +Cc: Keiichirou Suzuki, Jeff Mahoney, kexec@lists.infradead.org Hello Dave, >[dyoung@dhcp-*-* makedumpfile]$ sudo ./makedumpfile -l -d 31 /mnt/vmcore/vmcore /tmp/vmcore.1 >The kernel version is not supported. >The makedumpfile operation may be incomplete. >Checking for memory holes : [100.0 %] | __vtop4_x86_64: Can't get a valid pte. >readmem: Can't convert a virtual address(ffff88007ebb1000) to physical address. >readmem: type_addr: 0, addr:ffff88007ebb1000, size:32768 >__exclude_unnecessary_pages: Can't read the buffer of struct page. >create_2nd_bitmap: Can't exclude unnecessary pages. > >makedumpfile Failed. > >If you need the vmcore for debugging please let me know, my test is just >a normal test in kvm guest. Thanks for your report. I can't reproduce that in my environment, could you give me the vmcore ? It's helpful if you append the vmlinux and the .config. Thanks, Atsushi Kumagai >> >>Signed-off-by: Jeff Mahoney <jeffm@suse.com> >> >>--- >> >> arch/x86_64.c | 24 +++++++++++++++++++++--- >> >> makedumpfile.c | 6 ++++++ >> >> makedumpfile.h | 2 ++ >> >> 3 files changed, 29 insertions(+), 3 deletions(-) >> >> >> >>diff --git a/arch/x86_64.c b/arch/x86_64.c >> >>index 08dd6b2..9b09035 100644 >> >>--- a/arch/x86_64.c >> >>+++ b/arch/x86_64.c >> >>@@ -259,16 +259,26 @@ vtop4_x86_64(unsigned long vaddr) >> >> { >> >> unsigned long page_dir, pml4, pgd_paddr, pgd_pte, pmd_paddr, pmd_pte; >> >> unsigned long pte_paddr, pte; >> >>+ unsigned long init_level4_pgt; >> >> >> >>- if (SYMBOL(init_level4_pgt) == NOT_FOUND_SYMBOL) { >> >>+ if (SYMBOL(init_level4_pgt) != NOT_FOUND_SYMBOL) >> >>+ init_level4_pgt = SYMBOL(init_level4_pgt); >> >>+ else if (SYMBOL(init_top_pgt) != NOT_FOUND_SYMBOL) >> >>+ init_level4_pgt = SYMBOL(init_top_pgt); >> >>+ else { >> >> ERRMSG("Can't get the symbol of init_level4_pgt.\n"); >> >> return NOT_PADDR; >> >> } >> >> >> >>+ if (SYMBOL(level4_kernel_pgt) != NOT_FOUND_SYMBOL) { >> >>+ ERRMSG("Kernel is built with 5-level page tables\n"); >> >>+ return NOT_PADDR; >> >>+ } >> >>+ >> >> /* >> >> * Get PGD. >> >> */ >> >>- page_dir = SYMBOL(init_level4_pgt) - __START_KERNEL_map + info->phys_base; >> >>+ page_dir = init_level4_pgt - __START_KERNEL_map + info->phys_base; >> >> if (is_xen_memory()) { >> >> page_dir = ptom_xen(page_dir); >> >> if (page_dir == NOT_PADDR) >> >>@@ -549,8 +559,16 @@ find_vmemmap_x86_64() >> >> struct vmap_pfns *vmapp, *vmaphead = NULL, *cur, *tail; >> >> >> >> init_level4_pgt = SYMBOL(init_level4_pgt); >> >>+ if (init_level4_pgt == NOT_FOUND_SYMBOL) >> >>+ init_level4_pgt = SYMBOL(init_top_pgt); >> >>+ >> >> if (init_level4_pgt == NOT_FOUND_SYMBOL) { >> >>- ERRMSG("init_level4_pgt not found\n"); >> >>+ ERRMSG("init_level4_pgt/init_top_pgt not found\n"); >> >>+ return FAILED; >> >>+ } >> >>+ >> >>+ if (SYMBOL(level4_kernel_pgt) != NOT_FOUND_SYMBOL) { >> >>+ ERRMSG("kernel is configured for 5-level page tables\n"); >> >> return FAILED; >> >> } >> >> pagestructsize = size_table.page; >> >>diff --git a/makedumpfile.c b/makedumpfile.c >> >>index f85003a..6e5ec34 100644 >> >>--- a/makedumpfile.c >> >>+++ b/makedumpfile.c >> >>@@ -1486,6 +1486,8 @@ get_symbol_info(void) >> >> SYMBOL_INIT(_stext, "_stext"); >> >> SYMBOL_INIT(swapper_pg_dir, "swapper_pg_dir"); >> >> SYMBOL_INIT(init_level4_pgt, "init_level4_pgt"); >> >>+ SYMBOL_INIT(level4_kernel_pgt, "level4_kernel_pgt"); >> >>+ SYMBOL_INIT(init_top_pgt, "init_top_pgt"); >> >> SYMBOL_INIT(vmlist, "vmlist"); >> >> SYMBOL_INIT(vmap_area_list, "vmap_area_list"); >> >> SYMBOL_INIT(node_online_map, "node_online_map"); >> >>@@ -2105,6 +2107,8 @@ write_vmcoreinfo_data(void) >> >> WRITE_SYMBOL("_stext", _stext); >> >> WRITE_SYMBOL("swapper_pg_dir", swapper_pg_dir); >> >> WRITE_SYMBOL("init_level4_pgt", init_level4_pgt); >> >>+ WRITE_SYMBOL("level4_kernel_pgt", level4_kernel_pgt); >> >>+ WRITE_SYMBOL("init_top_pgt", init_top_pgt); >> >> WRITE_SYMBOL("vmlist", vmlist); >> >> WRITE_SYMBOL("vmap_area_list", vmap_area_list); >> >> WRITE_SYMBOL("node_online_map", node_online_map); >> >>@@ -2500,6 +2504,8 @@ read_vmcoreinfo(void) >> >> READ_SYMBOL("_stext", _stext); >> >> READ_SYMBOL("swapper_pg_dir", swapper_pg_dir); >> >> READ_SYMBOL("init_level4_pgt", init_level4_pgt); >> >>+ READ_SYMBOL("level4_kernel_pgt", level4_kernel_pgt); >> >>+ READ_SYMBOL("init_top_pgt", init_top_pgt); >> >> READ_SYMBOL("vmlist", vmlist); >> >> READ_SYMBOL("vmap_area_list", vmap_area_list); >> >> READ_SYMBOL("node_online_map", node_online_map); >> >>diff --git a/makedumpfile.h b/makedumpfile.h >> >>index 8a05794..9357e47 100644 >> >>--- a/makedumpfile.h >> >>+++ b/makedumpfile.h >> >>@@ -1517,6 +1517,8 @@ struct symbol_table { >> >> unsigned long long _stext; >> >> unsigned long long swapper_pg_dir; >> >> unsigned long long init_level4_pgt; >> >>+ unsigned long long level4_kernel_pgt; >> >>+ unsigned long long init_top_pgt; >> >> unsigned long long vmlist; >> >> unsigned long long vmap_area_list; >> >> unsigned long long phys_base; >> >> >> >> >> >>-- >> >>Jeff Mahoney >> >>SUSE Labs >> > >> > >> > >> >_______________________________________________ >> >kexec mailing list >> >kexec@lists.infradead.org >> >http://lists.infradead.org/mailman/listinfo/kexec >> >> >> _______________________________________________ >> kexec mailing list >> kexec@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/kexec > >Thanks >Dave _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH] handle renamed init_level4_pgt -> init_top_pgt 2017-12-21 8:48 ` Atsushi Kumagai @ 2017-12-22 4:54 ` Dave Young 2017-12-22 5:48 ` Dave Young 0 siblings, 1 reply; 22+ messages in thread From: Dave Young @ 2017-12-22 4:54 UTC (permalink / raw) To: Atsushi Kumagai Cc: Keiichirou Suzuki, Jeff Mahoney, kexec@lists.infradead.org Hi Atsushi, On 12/21/17 at 08:48am, Atsushi Kumagai wrote: > Hello Dave, > > >[dyoung@dhcp-*-* makedumpfile]$ sudo ./makedumpfile -l -d 31 /mnt/vmcore/vmcore /tmp/vmcore.1 > >The kernel version is not supported. > >The makedumpfile operation may be incomplete. > >Checking for memory holes : [100.0 %] | __vtop4_x86_64: Can't get a valid pte. > >readmem: Can't convert a virtual address(ffff88007ebb1000) to physical address. > >readmem: type_addr: 0, addr:ffff88007ebb1000, size:32768 > >__exclude_unnecessary_pages: Can't read the buffer of struct page. > >create_2nd_bitmap: Can't exclude unnecessary pages. > > > >makedumpfile Failed. > > > >If you need the vmcore for debugging please let me know, my test is just > >a normal test in kvm guest. > > Thanks for your report. > I can't reproduce that in my environment, could you give me the vmcore ? > It's helpful if you append the vmlinux and the .config. I'm bisecting it, nearly finished, will post the results and share vmcore if needed soon. > > Thanks, > Atsushi Kumagai > > >> >>Signed-off-by: Jeff Mahoney <jeffm@suse.com> > >> >>--- > >> >> arch/x86_64.c | 24 +++++++++++++++++++++--- > >> >> makedumpfile.c | 6 ++++++ > >> >> makedumpfile.h | 2 ++ > >> >> 3 files changed, 29 insertions(+), 3 deletions(-) > >> >> > >> >>diff --git a/arch/x86_64.c b/arch/x86_64.c > >> >>index 08dd6b2..9b09035 100644 > >> >>--- a/arch/x86_64.c > >> >>+++ b/arch/x86_64.c > >> >>@@ -259,16 +259,26 @@ vtop4_x86_64(unsigned long vaddr) > >> >> { > >> >> unsigned long page_dir, pml4, pgd_paddr, pgd_pte, pmd_paddr, pmd_pte; > >> >> unsigned long pte_paddr, pte; > >> >>+ unsigned long init_level4_pgt; > >> >> > >> >>- if (SYMBOL(init_level4_pgt) == NOT_FOUND_SYMBOL) { > >> >>+ if (SYMBOL(init_level4_pgt) != NOT_FOUND_SYMBOL) > >> >>+ init_level4_pgt = SYMBOL(init_level4_pgt); > >> >>+ else if (SYMBOL(init_top_pgt) != NOT_FOUND_SYMBOL) > >> >>+ init_level4_pgt = SYMBOL(init_top_pgt); > >> >>+ else { > >> >> ERRMSG("Can't get the symbol of init_level4_pgt.\n"); > >> >> return NOT_PADDR; > >> >> } > >> >> > >> >>+ if (SYMBOL(level4_kernel_pgt) != NOT_FOUND_SYMBOL) { > >> >>+ ERRMSG("Kernel is built with 5-level page tables\n"); > >> >>+ return NOT_PADDR; > >> >>+ } > >> >>+ > >> >> /* > >> >> * Get PGD. > >> >> */ > >> >>- page_dir = SYMBOL(init_level4_pgt) - __START_KERNEL_map + info->phys_base; > >> >>+ page_dir = init_level4_pgt - __START_KERNEL_map + info->phys_base; > >> >> if (is_xen_memory()) { > >> >> page_dir = ptom_xen(page_dir); > >> >> if (page_dir == NOT_PADDR) > >> >>@@ -549,8 +559,16 @@ find_vmemmap_x86_64() > >> >> struct vmap_pfns *vmapp, *vmaphead = NULL, *cur, *tail; > >> >> > >> >> init_level4_pgt = SYMBOL(init_level4_pgt); > >> >>+ if (init_level4_pgt == NOT_FOUND_SYMBOL) > >> >>+ init_level4_pgt = SYMBOL(init_top_pgt); > >> >>+ > >> >> if (init_level4_pgt == NOT_FOUND_SYMBOL) { > >> >>- ERRMSG("init_level4_pgt not found\n"); > >> >>+ ERRMSG("init_level4_pgt/init_top_pgt not found\n"); > >> >>+ return FAILED; > >> >>+ } > >> >>+ > >> >>+ if (SYMBOL(level4_kernel_pgt) != NOT_FOUND_SYMBOL) { > >> >>+ ERRMSG("kernel is configured for 5-level page tables\n"); > >> >> return FAILED; > >> >> } > >> >> pagestructsize = size_table.page; > >> >>diff --git a/makedumpfile.c b/makedumpfile.c > >> >>index f85003a..6e5ec34 100644 > >> >>--- a/makedumpfile.c > >> >>+++ b/makedumpfile.c > >> >>@@ -1486,6 +1486,8 @@ get_symbol_info(void) > >> >> SYMBOL_INIT(_stext, "_stext"); > >> >> SYMBOL_INIT(swapper_pg_dir, "swapper_pg_dir"); > >> >> SYMBOL_INIT(init_level4_pgt, "init_level4_pgt"); > >> >>+ SYMBOL_INIT(level4_kernel_pgt, "level4_kernel_pgt"); > >> >>+ SYMBOL_INIT(init_top_pgt, "init_top_pgt"); > >> >> SYMBOL_INIT(vmlist, "vmlist"); > >> >> SYMBOL_INIT(vmap_area_list, "vmap_area_list"); > >> >> SYMBOL_INIT(node_online_map, "node_online_map"); > >> >>@@ -2105,6 +2107,8 @@ write_vmcoreinfo_data(void) > >> >> WRITE_SYMBOL("_stext", _stext); > >> >> WRITE_SYMBOL("swapper_pg_dir", swapper_pg_dir); > >> >> WRITE_SYMBOL("init_level4_pgt", init_level4_pgt); > >> >>+ WRITE_SYMBOL("level4_kernel_pgt", level4_kernel_pgt); > >> >>+ WRITE_SYMBOL("init_top_pgt", init_top_pgt); > >> >> WRITE_SYMBOL("vmlist", vmlist); > >> >> WRITE_SYMBOL("vmap_area_list", vmap_area_list); > >> >> WRITE_SYMBOL("node_online_map", node_online_map); > >> >>@@ -2500,6 +2504,8 @@ read_vmcoreinfo(void) > >> >> READ_SYMBOL("_stext", _stext); > >> >> READ_SYMBOL("swapper_pg_dir", swapper_pg_dir); > >> >> READ_SYMBOL("init_level4_pgt", init_level4_pgt); > >> >>+ READ_SYMBOL("level4_kernel_pgt", level4_kernel_pgt); > >> >>+ READ_SYMBOL("init_top_pgt", init_top_pgt); > >> >> READ_SYMBOL("vmlist", vmlist); > >> >> READ_SYMBOL("vmap_area_list", vmap_area_list); > >> >> READ_SYMBOL("node_online_map", node_online_map); > >> >>diff --git a/makedumpfile.h b/makedumpfile.h > >> >>index 8a05794..9357e47 100644 > >> >>--- a/makedumpfile.h > >> >>+++ b/makedumpfile.h > >> >>@@ -1517,6 +1517,8 @@ struct symbol_table { > >> >> unsigned long long _stext; > >> >> unsigned long long swapper_pg_dir; > >> >> unsigned long long init_level4_pgt; > >> >>+ unsigned long long level4_kernel_pgt; > >> >>+ unsigned long long init_top_pgt; > >> >> unsigned long long vmlist; > >> >> unsigned long long vmap_area_list; > >> >> unsigned long long phys_base; > >> >> > >> >> > >> >>-- > >> >>Jeff Mahoney > >> >>SUSE Labs > >> > > >> > > >> > > >> >_______________________________________________ > >> >kexec mailing list > >> >kexec@lists.infradead.org > >> >http://lists.infradead.org/mailman/listinfo/kexec > >> > >> > >> _______________________________________________ > >> kexec mailing list > >> kexec@lists.infradead.org > >> http://lists.infradead.org/mailman/listinfo/kexec > > > >Thanks > >Dave > > Thanks Dave _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH] handle renamed init_level4_pgt -> init_top_pgt 2017-12-22 4:54 ` Dave Young @ 2017-12-22 5:48 ` Dave Young 2017-12-26 8:21 ` Atsushi Kumagai 0 siblings, 1 reply; 22+ messages in thread From: Dave Young @ 2017-12-22 5:48 UTC (permalink / raw) To: Atsushi Kumagai Cc: Keiichirou Suzuki, Jeff Mahoney, kexec@lists.infradead.org On 12/22/17 at 12:54pm, Dave Young wrote: > Hi Atsushi, > On 12/21/17 at 08:48am, Atsushi Kumagai wrote: > > Hello Dave, > > > > >[dyoung@dhcp-*-* makedumpfile]$ sudo ./makedumpfile -l -d 31 /mnt/vmcore/vmcore /tmp/vmcore.1 > > >The kernel version is not supported. > > >The makedumpfile operation may be incomplete. > > >Checking for memory holes : [100.0 %] | __vtop4_x86_64: Can't get a valid pte. > > >readmem: Can't convert a virtual address(ffff88007ebb1000) to physical address. > > >readmem: type_addr: 0, addr:ffff88007ebb1000, size:32768 > > >__exclude_unnecessary_pages: Can't read the buffer of struct page. > > >create_2nd_bitmap: Can't exclude unnecessary pages. > > > > > >makedumpfile Failed. > > > > > >If you need the vmcore for debugging please let me know, my test is just > > >a normal test in kvm guest. > > > > Thanks for your report. > > I can't reproduce that in my environment, could you give me the vmcore ? > > It's helpful if you append the vmlinux and the .config. > > I'm bisecting it, nearly finished, will post the results and share > vmcore if needed soon. vmcore/vmlinux (gzipped) and .config: http://people.redhat.com/ruyang/rhbz1528542/ Bisect result is below: 83e3c48729d9ebb7af5a31a504f3fd6aff0348c4 is the first bad commit commit 83e3c48729d9ebb7af5a31a504f3fd6aff0348c4 Author: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> Date: Fri Sep 29 17:08:16 2017 +0300 mm/sparsemem: Allocate mem_section at runtime for CONFIG_SPARSEMEM_EXTREME=y Size of the mem_section[] array depends on the size of the physical address space. In preparation for boot-time switching between paging modes on x86-64 we need to make the allocation of mem_section[] dynamic, because otherwise we waste a lot of RAM: with CONFIG_NODE_SHIFT=10, mem_section[] size is 32kB for 4-level paging and 2MB for 5-level paging mode. The patch allocates the array on the first call to sparse_memory_present_with_active_regions(). Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Andy Lutomirski <luto@amacapital.net> Cc: Borislav Petkov <bp@suse.de> Cc: Cyrill Gorcunov <gorcunov@openvz.org> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: linux-mm@kvack.org Link: http://lkml.kernel.org/r/20170929140821.37654-2-kirill.shutemov@linux.intel.com Signed-off-by: Ingo Molnar <mingo@kernel.org> :040000 040000 68b7ff3eedc2c9ff56e31108f7e982eacbb233fc 0014ee63bebe14efb0e36e0028e2cbe718fd6c30 M include :040000 040000 78adbc296527c802400b1f68e0fbd716920726fa a4eea8117cb318527c0d5a6281d68f312f644831 M mm > > > > > Thanks, > > Atsushi Kumagai > > > > >> >>Signed-off-by: Jeff Mahoney <jeffm@suse.com> > > >> >>--- > > >> >> arch/x86_64.c | 24 +++++++++++++++++++++--- > > >> >> makedumpfile.c | 6 ++++++ > > >> >> makedumpfile.h | 2 ++ > > >> >> 3 files changed, 29 insertions(+), 3 deletions(-) > > >> >> > > >> >>diff --git a/arch/x86_64.c b/arch/x86_64.c > > >> >>index 08dd6b2..9b09035 100644 > > >> >>--- a/arch/x86_64.c > > >> >>+++ b/arch/x86_64.c > > >> >>@@ -259,16 +259,26 @@ vtop4_x86_64(unsigned long vaddr) > > >> >> { > > >> >> unsigned long page_dir, pml4, pgd_paddr, pgd_pte, pmd_paddr, pmd_pte; > > >> >> unsigned long pte_paddr, pte; > > >> >>+ unsigned long init_level4_pgt; > > >> >> > > >> >>- if (SYMBOL(init_level4_pgt) == NOT_FOUND_SYMBOL) { > > >> >>+ if (SYMBOL(init_level4_pgt) != NOT_FOUND_SYMBOL) > > >> >>+ init_level4_pgt = SYMBOL(init_level4_pgt); > > >> >>+ else if (SYMBOL(init_top_pgt) != NOT_FOUND_SYMBOL) > > >> >>+ init_level4_pgt = SYMBOL(init_top_pgt); > > >> >>+ else { > > >> >> ERRMSG("Can't get the symbol of init_level4_pgt.\n"); > > >> >> return NOT_PADDR; > > >> >> } > > >> >> > > >> >>+ if (SYMBOL(level4_kernel_pgt) != NOT_FOUND_SYMBOL) { > > >> >>+ ERRMSG("Kernel is built with 5-level page tables\n"); > > >> >>+ return NOT_PADDR; > > >> >>+ } > > >> >>+ > > >> >> /* > > >> >> * Get PGD. > > >> >> */ > > >> >>- page_dir = SYMBOL(init_level4_pgt) - __START_KERNEL_map + info->phys_base; > > >> >>+ page_dir = init_level4_pgt - __START_KERNEL_map + info->phys_base; > > >> >> if (is_xen_memory()) { > > >> >> page_dir = ptom_xen(page_dir); > > >> >> if (page_dir == NOT_PADDR) > > >> >>@@ -549,8 +559,16 @@ find_vmemmap_x86_64() > > >> >> struct vmap_pfns *vmapp, *vmaphead = NULL, *cur, *tail; > > >> >> > > >> >> init_level4_pgt = SYMBOL(init_level4_pgt); > > >> >>+ if (init_level4_pgt == NOT_FOUND_SYMBOL) > > >> >>+ init_level4_pgt = SYMBOL(init_top_pgt); > > >> >>+ > > >> >> if (init_level4_pgt == NOT_FOUND_SYMBOL) { > > >> >>- ERRMSG("init_level4_pgt not found\n"); > > >> >>+ ERRMSG("init_level4_pgt/init_top_pgt not found\n"); > > >> >>+ return FAILED; > > >> >>+ } > > >> >>+ > > >> >>+ if (SYMBOL(level4_kernel_pgt) != NOT_FOUND_SYMBOL) { > > >> >>+ ERRMSG("kernel is configured for 5-level page tables\n"); > > >> >> return FAILED; > > >> >> } > > >> >> pagestructsize = size_table.page; > > >> >>diff --git a/makedumpfile.c b/makedumpfile.c > > >> >>index f85003a..6e5ec34 100644 > > >> >>--- a/makedumpfile.c > > >> >>+++ b/makedumpfile.c > > >> >>@@ -1486,6 +1486,8 @@ get_symbol_info(void) > > >> >> SYMBOL_INIT(_stext, "_stext"); > > >> >> SYMBOL_INIT(swapper_pg_dir, "swapper_pg_dir"); > > >> >> SYMBOL_INIT(init_level4_pgt, "init_level4_pgt"); > > >> >>+ SYMBOL_INIT(level4_kernel_pgt, "level4_kernel_pgt"); > > >> >>+ SYMBOL_INIT(init_top_pgt, "init_top_pgt"); > > >> >> SYMBOL_INIT(vmlist, "vmlist"); > > >> >> SYMBOL_INIT(vmap_area_list, "vmap_area_list"); > > >> >> SYMBOL_INIT(node_online_map, "node_online_map"); > > >> >>@@ -2105,6 +2107,8 @@ write_vmcoreinfo_data(void) > > >> >> WRITE_SYMBOL("_stext", _stext); > > >> >> WRITE_SYMBOL("swapper_pg_dir", swapper_pg_dir); > > >> >> WRITE_SYMBOL("init_level4_pgt", init_level4_pgt); > > >> >>+ WRITE_SYMBOL("level4_kernel_pgt", level4_kernel_pgt); > > >> >>+ WRITE_SYMBOL("init_top_pgt", init_top_pgt); > > >> >> WRITE_SYMBOL("vmlist", vmlist); > > >> >> WRITE_SYMBOL("vmap_area_list", vmap_area_list); > > >> >> WRITE_SYMBOL("node_online_map", node_online_map); > > >> >>@@ -2500,6 +2504,8 @@ read_vmcoreinfo(void) > > >> >> READ_SYMBOL("_stext", _stext); > > >> >> READ_SYMBOL("swapper_pg_dir", swapper_pg_dir); > > >> >> READ_SYMBOL("init_level4_pgt", init_level4_pgt); > > >> >>+ READ_SYMBOL("level4_kernel_pgt", level4_kernel_pgt); > > >> >>+ READ_SYMBOL("init_top_pgt", init_top_pgt); > > >> >> READ_SYMBOL("vmlist", vmlist); > > >> >> READ_SYMBOL("vmap_area_list", vmap_area_list); > > >> >> READ_SYMBOL("node_online_map", node_online_map); > > >> >>diff --git a/makedumpfile.h b/makedumpfile.h > > >> >>index 8a05794..9357e47 100644 > > >> >>--- a/makedumpfile.h > > >> >>+++ b/makedumpfile.h > > >> >>@@ -1517,6 +1517,8 @@ struct symbol_table { > > >> >> unsigned long long _stext; > > >> >> unsigned long long swapper_pg_dir; > > >> >> unsigned long long init_level4_pgt; > > >> >>+ unsigned long long level4_kernel_pgt; > > >> >>+ unsigned long long init_top_pgt; > > >> >> unsigned long long vmlist; > > >> >> unsigned long long vmap_area_list; > > >> >> unsigned long long phys_base; > > >> >> > > >> >> > > >> >>-- > > >> >>Jeff Mahoney > > >> >>SUSE Labs > > >> > > > >> > > > >> > > > >> >_______________________________________________ > > >> >kexec mailing list > > >> >kexec@lists.infradead.org > > >> >http://lists.infradead.org/mailman/listinfo/kexec > > >> > > >> > > >> _______________________________________________ > > >> kexec mailing list > > >> kexec@lists.infradead.org > > >> http://lists.infradead.org/mailman/listinfo/kexec > > > > > >Thanks > > >Dave > > > > > > Thanks > Dave _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec ^ permalink raw reply [flat|nested] 22+ messages in thread
* RE: [PATCH] handle renamed init_level4_pgt -> init_top_pgt 2017-12-22 5:48 ` Dave Young @ 2017-12-26 8:21 ` Atsushi Kumagai 2018-01-02 8:57 ` Dave Young 0 siblings, 1 reply; 22+ messages in thread From: Atsushi Kumagai @ 2017-12-26 8:21 UTC (permalink / raw) To: Dave Young; +Cc: Keiichirou Suzuki, Jeff Mahoney, kexec@lists.infradead.org >On 12/22/17 at 12:54pm, Dave Young wrote: >> Hi Atsushi, >> On 12/21/17 at 08:48am, Atsushi Kumagai wrote: >> > Hello Dave, >> > >> > >[dyoung@dhcp-*-* makedumpfile]$ sudo ./makedumpfile -l -d 31 /mnt/vmcore/vmcore /tmp/vmcore.1 >> > >The kernel version is not supported. >> > >The makedumpfile operation may be incomplete. >> > >Checking for memory holes : [100.0 %] | __vtop4_x86_64: Can't get a valid >pte. >> > >readmem: Can't convert a virtual address(ffff88007ebb1000) to physical address. >> > >readmem: type_addr: 0, addr:ffff88007ebb1000, size:32768 >> > >__exclude_unnecessary_pages: Can't read the buffer of struct page. >> > >create_2nd_bitmap: Can't exclude unnecessary pages. >> > > >> > >makedumpfile Failed. >> > > >> > >If you need the vmcore for debugging please let me know, my test is just >> > >a normal test in kvm guest. >> > >> > Thanks for your report. >> > I can't reproduce that in my environment, could you give me the vmcore ? >> > It's helpful if you append the vmlinux and the .config. >> >> I'm bisecting it, nearly finished, will post the results and share >> vmcore if needed soon. > >vmcore/vmlinux (gzipped) and .config: >http://people.redhat.com/ruyang/rhbz1528542/ Thanks. >Bisect result is below: I'm not sure why this commit affects makedumpfile yet, but I'll give priority to release v1.6.3 since the commit will not be included in the supported kernel(4.14). Regards, Atsushi Kumagai >83e3c48729d9ebb7af5a31a504f3fd6aff0348c4 is the first bad commit >commit 83e3c48729d9ebb7af5a31a504f3fd6aff0348c4 >Author: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> >Date: Fri Sep 29 17:08:16 2017 +0300 > > mm/sparsemem: Allocate mem_section at runtime for CONFIG_SPARSEMEM_EXTREME=y > > Size of the mem_section[] array depends on the size of the physical address space. > > In preparation for boot-time switching between paging modes on x86-64 > we need to make the allocation of mem_section[] dynamic, because otherwise > we waste a lot of RAM: with CONFIG_NODE_SHIFT=10, mem_section[] size is 32kB > for 4-level paging and 2MB for 5-level paging mode. > > The patch allocates the array on the first call to sparse_memory_present_with_active_regions(). > > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Andy Lutomirski <luto@amacapital.net> > Cc: Borislav Petkov <bp@suse.de> > Cc: Cyrill Gorcunov <gorcunov@openvz.org> > Cc: Linus Torvalds <torvalds@linux-foundation.org> > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: linux-mm@kvack.org > Link: http://lkml.kernel.org/r/20170929140821.37654-2-kirill.shutemov@linux.intel.com > Signed-off-by: Ingo Molnar <mingo@kernel.org> > >:040000 040000 68b7ff3eedc2c9ff56e31108f7e982eacbb233fc 0014ee63bebe14efb0e36e0028e2cbe718fd6c30 M include >:040000 040000 78adbc296527c802400b1f68e0fbd716920726fa a4eea8117cb318527c0d5a6281d68f312f644831 M mm > >> >> > >> > Thanks, >> > Atsushi Kumagai >> > >> > >> >>Signed-off-by: Jeff Mahoney <jeffm@suse.com> >> > >> >>--- >> > >> >> arch/x86_64.c | 24 +++++++++++++++++++++--- >> > >> >> makedumpfile.c | 6 ++++++ >> > >> >> makedumpfile.h | 2 ++ >> > >> >> 3 files changed, 29 insertions(+), 3 deletions(-) >> > >> >> >> > >> >>diff --git a/arch/x86_64.c b/arch/x86_64.c >> > >> >>index 08dd6b2..9b09035 100644 >> > >> >>--- a/arch/x86_64.c >> > >> >>+++ b/arch/x86_64.c >> > >> >>@@ -259,16 +259,26 @@ vtop4_x86_64(unsigned long vaddr) >> > >> >> { >> > >> >> unsigned long page_dir, pml4, pgd_paddr, pgd_pte, pmd_paddr, pmd_pte; >> > >> >> unsigned long pte_paddr, pte; >> > >> >>+ unsigned long init_level4_pgt; >> > >> >> >> > >> >>- if (SYMBOL(init_level4_pgt) == NOT_FOUND_SYMBOL) { >> > >> >>+ if (SYMBOL(init_level4_pgt) != NOT_FOUND_SYMBOL) >> > >> >>+ init_level4_pgt = SYMBOL(init_level4_pgt); >> > >> >>+ else if (SYMBOL(init_top_pgt) != NOT_FOUND_SYMBOL) >> > >> >>+ init_level4_pgt = SYMBOL(init_top_pgt); >> > >> >>+ else { >> > >> >> ERRMSG("Can't get the symbol of init_level4_pgt.\n"); >> > >> >> return NOT_PADDR; >> > >> >> } >> > >> >> >> > >> >>+ if (SYMBOL(level4_kernel_pgt) != NOT_FOUND_SYMBOL) { >> > >> >>+ ERRMSG("Kernel is built with 5-level page tables\n"); >> > >> >>+ return NOT_PADDR; >> > >> >>+ } >> > >> >>+ >> > >> >> /* >> > >> >> * Get PGD. >> > >> >> */ >> > >> >>- page_dir = SYMBOL(init_level4_pgt) - __START_KERNEL_map + info->phys_base; >> > >> >>+ page_dir = init_level4_pgt - __START_KERNEL_map + info->phys_base; >> > >> >> if (is_xen_memory()) { >> > >> >> page_dir = ptom_xen(page_dir); >> > >> >> if (page_dir == NOT_PADDR) >> > >> >>@@ -549,8 +559,16 @@ find_vmemmap_x86_64() >> > >> >> struct vmap_pfns *vmapp, *vmaphead = NULL, *cur, *tail; >> > >> >> >> > >> >> init_level4_pgt = SYMBOL(init_level4_pgt); >> > >> >>+ if (init_level4_pgt == NOT_FOUND_SYMBOL) >> > >> >>+ init_level4_pgt = SYMBOL(init_top_pgt); >> > >> >>+ >> > >> >> if (init_level4_pgt == NOT_FOUND_SYMBOL) { >> > >> >>- ERRMSG("init_level4_pgt not found\n"); >> > >> >>+ ERRMSG("init_level4_pgt/init_top_pgt not found\n"); >> > >> >>+ return FAILED; >> > >> >>+ } >> > >> >>+ >> > >> >>+ if (SYMBOL(level4_kernel_pgt) != NOT_FOUND_SYMBOL) { >> > >> >>+ ERRMSG("kernel is configured for 5-level page tables\n"); >> > >> >> return FAILED; >> > >> >> } >> > >> >> pagestructsize = size_table.page; >> > >> >>diff --git a/makedumpfile.c b/makedumpfile.c >> > >> >>index f85003a..6e5ec34 100644 >> > >> >>--- a/makedumpfile.c >> > >> >>+++ b/makedumpfile.c >> > >> >>@@ -1486,6 +1486,8 @@ get_symbol_info(void) >> > >> >> SYMBOL_INIT(_stext, "_stext"); >> > >> >> SYMBOL_INIT(swapper_pg_dir, "swapper_pg_dir"); >> > >> >> SYMBOL_INIT(init_level4_pgt, "init_level4_pgt"); >> > >> >>+ SYMBOL_INIT(level4_kernel_pgt, "level4_kernel_pgt"); >> > >> >>+ SYMBOL_INIT(init_top_pgt, "init_top_pgt"); >> > >> >> SYMBOL_INIT(vmlist, "vmlist"); >> > >> >> SYMBOL_INIT(vmap_area_list, "vmap_area_list"); >> > >> >> SYMBOL_INIT(node_online_map, "node_online_map"); >> > >> >>@@ -2105,6 +2107,8 @@ write_vmcoreinfo_data(void) >> > >> >> WRITE_SYMBOL("_stext", _stext); >> > >> >> WRITE_SYMBOL("swapper_pg_dir", swapper_pg_dir); >> > >> >> WRITE_SYMBOL("init_level4_pgt", init_level4_pgt); >> > >> >>+ WRITE_SYMBOL("level4_kernel_pgt", level4_kernel_pgt); >> > >> >>+ WRITE_SYMBOL("init_top_pgt", init_top_pgt); >> > >> >> WRITE_SYMBOL("vmlist", vmlist); >> > >> >> WRITE_SYMBOL("vmap_area_list", vmap_area_list); >> > >> >> WRITE_SYMBOL("node_online_map", node_online_map); >> > >> >>@@ -2500,6 +2504,8 @@ read_vmcoreinfo(void) >> > >> >> READ_SYMBOL("_stext", _stext); >> > >> >> READ_SYMBOL("swapper_pg_dir", swapper_pg_dir); >> > >> >> READ_SYMBOL("init_level4_pgt", init_level4_pgt); >> > >> >>+ READ_SYMBOL("level4_kernel_pgt", level4_kernel_pgt); >> > >> >>+ READ_SYMBOL("init_top_pgt", init_top_pgt); >> > >> >> READ_SYMBOL("vmlist", vmlist); >> > >> >> READ_SYMBOL("vmap_area_list", vmap_area_list); >> > >> >> READ_SYMBOL("node_online_map", node_online_map); >> > >> >>diff --git a/makedumpfile.h b/makedumpfile.h >> > >> >>index 8a05794..9357e47 100644 >> > >> >>--- a/makedumpfile.h >> > >> >>+++ b/makedumpfile.h >> > >> >>@@ -1517,6 +1517,8 @@ struct symbol_table { >> > >> >> unsigned long long _stext; >> > >> >> unsigned long long swapper_pg_dir; >> > >> >> unsigned long long init_level4_pgt; >> > >> >>+ unsigned long long level4_kernel_pgt; >> > >> >>+ unsigned long long init_top_pgt; >> > >> >> unsigned long long vmlist; >> > >> >> unsigned long long vmap_area_list; >> > >> >> unsigned long long phys_base; >> > >> >> >> > >> >> >> > >> >>-- >> > >> >>Jeff Mahoney >> > >> >>SUSE Labs >> > >> > >> > >> > >> > >> > >> > >> >_______________________________________________ >> > >> >kexec mailing list >> > >> >kexec@lists.infradead.org >> > >> >http://lists.infradead.org/mailman/listinfo/kexec >> > >> >> > >> >> > >> _______________________________________________ >> > >> kexec mailing list >> > >> kexec@lists.infradead.org >> > >> http://lists.infradead.org/mailman/listinfo/kexec >> > > >> > >Thanks >> > >Dave >> > >> > >> >> Thanks >> Dave _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH] handle renamed init_level4_pgt -> init_top_pgt 2017-12-26 8:21 ` Atsushi Kumagai @ 2018-01-02 8:57 ` Dave Young 2018-01-02 9:08 ` Baoquan He 0 siblings, 1 reply; 22+ messages in thread From: Dave Young @ 2018-01-02 8:57 UTC (permalink / raw) To: Atsushi Kumagai Cc: Keiichirou Suzuki, Jeff Mahoney, kexec@lists.infradead.org, bhe Hi Atsushi, Happy new year! On 12/26/17 at 08:21am, Atsushi Kumagai wrote: > >On 12/22/17 at 12:54pm, Dave Young wrote: > >> Hi Atsushi, > >> On 12/21/17 at 08:48am, Atsushi Kumagai wrote: > >> > Hello Dave, > >> > > >> > >[dyoung@dhcp-*-* makedumpfile]$ sudo ./makedumpfile -l -d 31 /mnt/vmcore/vmcore /tmp/vmcore.1 > >> > >The kernel version is not supported. > >> > >The makedumpfile operation may be incomplete. > >> > >Checking for memory holes : [100.0 %] | __vtop4_x86_64: Can't get a valid > >pte. > >> > >readmem: Can't convert a virtual address(ffff88007ebb1000) to physical address. > >> > >readmem: type_addr: 0, addr:ffff88007ebb1000, size:32768 > >> > >__exclude_unnecessary_pages: Can't read the buffer of struct page. > >> > >create_2nd_bitmap: Can't exclude unnecessary pages. > >> > > > >> > >makedumpfile Failed. > >> > > > >> > >If you need the vmcore for debugging please let me know, my test is just > >> > >a normal test in kvm guest. > >> > > >> > Thanks for your report. > >> > I can't reproduce that in my environment, could you give me the vmcore ? > >> > It's helpful if you append the vmlinux and the .config. > >> > >> I'm bisecting it, nearly finished, will post the results and share > >> vmcore if needed soon. > > > >vmcore/vmlinux (gzipped) and .config: > >http://people.redhat.com/ruyang/rhbz1528542/ > > Thanks. > > >Bisect result is below: > > I'm not sure why this commit affects makedumpfile yet, but > I'll give priority to release v1.6.3 since the commit will not be included > in the supported kernel(4.14). > > Regards, > Atsushi Kumagai > > >83e3c48729d9ebb7af5a31a504f3fd6aff0348c4 is the first bad commit > >commit 83e3c48729d9ebb7af5a31a504f3fd6aff0348c4 > >Author: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> > >Date: Fri Sep 29 17:08:16 2017 +0300 > > > > mm/sparsemem: Allocate mem_section at runtime for CONFIG_SPARSEMEM_EXTREME=y > > > > Size of the mem_section[] array depends on the size of the physical address space. > > > > In preparation for boot-time switching between paging modes on x86-64 > > we need to make the allocation of mem_section[] dynamic, because otherwise > > we waste a lot of RAM: with CONFIG_NODE_SHIFT=10, mem_section[] size is 32kB > > for 4-level paging and 2MB for 5-level paging mode. > > > > The patch allocates the array on the first call to sparse_memory_present_with_active_regions(). > > > > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> > > Cc: Andrew Morton <akpm@linux-foundation.org> > > Cc: Andy Lutomirski <luto@amacapital.net> > > Cc: Borislav Petkov <bp@suse.de> > > Cc: Cyrill Gorcunov <gorcunov@openvz.org> > > Cc: Linus Torvalds <torvalds@linux-foundation.org> > > Cc: Peter Zijlstra <peterz@infradead.org> > > Cc: Thomas Gleixner <tglx@linutronix.de> > > Cc: linux-mm@kvack.org > > Link: http://lkml.kernel.org/r/20170929140821.37654-2-kirill.shutemov@linux.intel.com > > Signed-off-by: Ingo Molnar <mingo@kernel.org> > > > >:040000 040000 68b7ff3eedc2c9ff56e31108f7e982eacbb233fc 0014ee63bebe14efb0e36e0028e2cbe718fd6c30 M include > >:040000 040000 78adbc296527c802400b1f68e0fbd716920726fa a4eea8117cb318527c0d5a6281d68f312f644831 M mm The root cause is this commit makes mem_section as a pointer instead of the static array. VMCOREINFO_SYMBOL() expand it as &mem_section, this is not correct in the test case any more. This hack code works for me: diff --git a/kernel/crash_core.c b/kernel/crash_core.c index b3663896278e..f5fe6068ae39 100644 --- a/kernel/crash_core.c +++ b/kernel/crash_core.c @@ -376,6 +376,8 @@ phys_addr_t __weak paddr_vmcoreinfo_note(void) { return __pa(vmcoreinfo_note); } +#define VMCOREINFO_SYMBOL_HACK(name) \ + vmcoreinfo_append_str("SYMBOL(%s)=%lx\n", #name, (unsigned long)name) static int __init crash_save_vmcoreinfo_init(void) { @@ -410,10 +412,11 @@ static int __init crash_save_vmcoreinfo_init(void) VMCOREINFO_SYMBOL(contig_page_data); #endif #ifdef CONFIG_SPARSEMEM - VMCOREINFO_SYMBOL(mem_section); + VMCOREINFO_SYMBOL_HACK(mem_section); VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); VMCOREINFO_STRUCT_SIZE(mem_section); VMCOREINFO_OFFSET(mem_section, section_mem_map); + #endif VMCOREINFO_STRUCT_SIZE(page); VMCOREINFO_STRUCT_SIZE(pglist_data); But probably we need this instead, but I can not test it because I do not know how to fix makedumpfile to use a _NUMBER instead of a SYMBOL. Thus bring up the issue, seeking for thoughts and discussion. diff --git a/kernel/crash_core.c b/kernel/crash_core.c index b3663896278e..dfa2238e2c28 100644 --- a/kernel/crash_core.c +++ b/kernel/crash_core.c @@ -410,10 +410,17 @@ static int __init crash_save_vmcoreinfo_init(void) VMCOREINFO_SYMBOL(contig_page_data); #endif #ifdef CONFIG_SPARSEMEM +#ifdef CONFIG_SPARSEMEM_EXTREME + VMCOREINFO_NUMBER(mem_section); +#else VMCOREINFO_SYMBOL(mem_section); +#endif VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); VMCOREINFO_STRUCT_SIZE(mem_section); VMCOREINFO_OFFSET(mem_section, section_mem_map); [snip] Thanks Dave _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec ^ permalink raw reply related [flat|nested] 22+ messages in thread
* Re: [PATCH] handle renamed init_level4_pgt -> init_top_pgt 2018-01-02 8:57 ` Dave Young @ 2018-01-02 9:08 ` Baoquan He 2018-01-03 2:30 ` makedumpfile saving vmcore fails with dynamically allocated mem_section (was: Re: [PATCH] handle renamed init_level4_pgt -> init_top_pgt) Dave Young 0 siblings, 1 reply; 22+ messages in thread From: Baoquan He @ 2018-01-02 9:08 UTC (permalink / raw) To: Dave Young Cc: Atsushi Kumagai, Jeff Mahoney, kexec@lists.infradead.org, Keiichirou Suzuki On 01/02/18 at 04:57pm, Dave Young wrote: > The root cause is this commit makes mem_section as a pointer instead of > the static array. > > VMCOREINFO_SYMBOL() expand it as &mem_section, this is not correct in > the test case any more. > > This hack code works for me: > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > index b3663896278e..f5fe6068ae39 100644 > --- a/kernel/crash_core.c > +++ b/kernel/crash_core.c > @@ -376,6 +376,8 @@ phys_addr_t __weak paddr_vmcoreinfo_note(void) > { > return __pa(vmcoreinfo_note); > } > +#define VMCOREINFO_SYMBOL_HACK(name) \ > + vmcoreinfo_append_str("SYMBOL(%s)=%lx\n", #name, (unsigned long)name) Oh, you made a new one. We may use vmcoreinfo_append_str directly since there's an existing one in crash_save_vmcoreinfo(): vmcoreinfo_append_str("CRASHTIME=%ld\n", get_seconds()); The thing is that VMCOREINFO_SYMBOL will reference symbol. While checking all exported symbol, all of them are array names. So here the value of &array_name is equal to the address of the first element of array. Now the first exception appeared, mem_section, which could be not an array name, but a pointer pointing at the allocated memory. For this issue, we either change as Dave mentioned two options, or can we adjust VMCOREINFO_SYMBOL(name)? > > static int __init crash_save_vmcoreinfo_init(void) > { > @@ -410,10 +412,11 @@ static int __init crash_save_vmcoreinfo_init(void) > VMCOREINFO_SYMBOL(contig_page_data); > #endif > #ifdef CONFIG_SPARSEMEM > - VMCOREINFO_SYMBOL(mem_section); > + VMCOREINFO_SYMBOL_HACK(mem_section); > VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); > VMCOREINFO_STRUCT_SIZE(mem_section); > VMCOREINFO_OFFSET(mem_section, section_mem_map); > + > #endif > VMCOREINFO_STRUCT_SIZE(page); > VMCOREINFO_STRUCT_SIZE(pglist_data); > > > But probably we need this instead, but I can not test it because I do > not know how to fix makedumpfile to use a _NUMBER instead of a SYMBOL. > Thus bring up the issue, seeking for thoughts and discussion. > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > index b3663896278e..dfa2238e2c28 100644 > --- a/kernel/crash_core.c > +++ b/kernel/crash_core.c > @@ -410,10 +410,17 @@ static int __init crash_save_vmcoreinfo_init(void) > VMCOREINFO_SYMBOL(contig_page_data); > #endif > #ifdef CONFIG_SPARSEMEM > +#ifdef CONFIG_SPARSEMEM_EXTREME > + VMCOREINFO_NUMBER(mem_section); > +#else > VMCOREINFO_SYMBOL(mem_section); > +#endif > VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); > VMCOREINFO_STRUCT_SIZE(mem_section); > VMCOREINFO_OFFSET(mem_section, section_mem_map); > > [snip] > > Thanks > Dave _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec ^ permalink raw reply [flat|nested] 22+ messages in thread
* makedumpfile saving vmcore fails with dynamically allocated mem_section (was: Re: [PATCH] handle renamed init_level4_pgt -> init_top_pgt) 2018-01-02 9:08 ` Baoquan He @ 2018-01-03 2:30 ` Dave Young 2018-01-03 2:38 ` Baoquan He 0 siblings, 1 reply; 22+ messages in thread From: Dave Young @ 2018-01-03 2:30 UTC (permalink / raw) To: Baoquan He Cc: Atsushi Kumagai, Jeff Mahoney, anderson@redhat.com kexec@lists.infradead.org, Keiichirou Suzuki On 01/02/18 at 05:08pm, Baoquan He wrote: > On 01/02/18 at 04:57pm, Dave Young wrote: > > The root cause is this commit makes mem_section as a pointer instead of > > the static array. > > > > VMCOREINFO_SYMBOL() expand it as &mem_section, this is not correct in > > the test case any more. > > > > This hack code works for me: > > > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > > index b3663896278e..f5fe6068ae39 100644 > > --- a/kernel/crash_core.c > > +++ b/kernel/crash_core.c > > @@ -376,6 +376,8 @@ phys_addr_t __weak paddr_vmcoreinfo_note(void) > > { > > return __pa(vmcoreinfo_note); > > } > > +#define VMCOREINFO_SYMBOL_HACK(name) \ > > + vmcoreinfo_append_str("SYMBOL(%s)=%lx\n", #name, (unsigned long)name) > > Oh, you made a new one. We may use vmcoreinfo_append_str directly since > there's an existing one in crash_save_vmcoreinfo(): Yes, it should be something like this instead, this should ensure makedumpfile maybe crash tool works without any modifications, waiting for feedback from Atsushi, also ccing Dave for crash utility potential issue. diff --git a/kernel/crash_core.c b/kernel/crash_core.c index b3663896278e..122494364179 100644 --- a/kernel/crash_core.c +++ b/kernel/crash_core.c @@ -410,10 +410,16 @@ static int __init crash_save_vmcoreinfo_init(void) VMCOREINFO_SYMBOL(contig_page_data); #endif #ifdef CONFIG_SPARSEMEM +#ifdef CONFIG_SPARSEMEM_EXTREME + vmcoreinfo_append_str("SYMBOL(mem_section)=%lx\n", + (unsigned long)mem_section); +#else VMCOREINFO_SYMBOL(mem_section); +#endif VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); VMCOREINFO_STRUCT_SIZE(mem_section); VMCOREINFO_OFFSET(mem_section, section_mem_map); + #endif VMCOREINFO_STRUCT_SIZE(page); VMCOREINFO_STRUCT_SIZE(pglist_data); > > vmcoreinfo_append_str("CRASHTIME=%ld\n", get_seconds()); > > The thing is that VMCOREINFO_SYMBOL will reference symbol. While > checking all exported symbol, all of them are array names. So here > the value of &array_name is equal to the address of the first element of > array. Now the first exception appeared, mem_section, which could be not > an array name, but a pointer pointing at the allocated memory. > > For this issue, we either change as Dave mentioned two options, or can > we adjust VMCOREINFO_SYMBOL(name)? > > > > > static int __init crash_save_vmcoreinfo_init(void) > > { > > @@ -410,10 +412,11 @@ static int __init crash_save_vmcoreinfo_init(void) > > VMCOREINFO_SYMBOL(contig_page_data); > > #endif > > #ifdef CONFIG_SPARSEMEM > > - VMCOREINFO_SYMBOL(mem_section); > > + VMCOREINFO_SYMBOL_HACK(mem_section); > > VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); > > VMCOREINFO_STRUCT_SIZE(mem_section); > > VMCOREINFO_OFFSET(mem_section, section_mem_map); > > + > > #endif > > VMCOREINFO_STRUCT_SIZE(page); > > VMCOREINFO_STRUCT_SIZE(pglist_data); > > > > > > But probably we need this instead, but I can not test it because I do > > not know how to fix makedumpfile to use a _NUMBER instead of a SYMBOL. > > Thus bring up the issue, seeking for thoughts and discussion. > > > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > > index b3663896278e..dfa2238e2c28 100644 > > --- a/kernel/crash_core.c > > +++ b/kernel/crash_core.c > > @@ -410,10 +410,17 @@ static int __init crash_save_vmcoreinfo_init(void) > > VMCOREINFO_SYMBOL(contig_page_data); > > #endif > > #ifdef CONFIG_SPARSEMEM > > +#ifdef CONFIG_SPARSEMEM_EXTREME > > + VMCOREINFO_NUMBER(mem_section); > > +#else > > VMCOREINFO_SYMBOL(mem_section); > > +#endif > > VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); > > VMCOREINFO_STRUCT_SIZE(mem_section); > > VMCOREINFO_OFFSET(mem_section, section_mem_map); > > > > [snip] > > > > Thanks > > Dave _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec ^ permalink raw reply related [flat|nested] 22+ messages in thread
* Re: makedumpfile saving vmcore fails with dynamically allocated mem_section (was: Re: [PATCH] handle renamed init_level4_pgt -> init_top_pgt) 2018-01-03 2:30 ` makedumpfile saving vmcore fails with dynamically allocated mem_section (was: Re: [PATCH] handle renamed init_level4_pgt -> init_top_pgt) Dave Young @ 2018-01-03 2:38 ` Baoquan He 2018-01-05 8:19 ` Atsushi Kumagai 0 siblings, 1 reply; 22+ messages in thread From: Baoquan He @ 2018-01-03 2:38 UTC (permalink / raw) To: Dave Young Cc: Atsushi Kumagai, Jeff Mahoney, anderson@redhat.com kexec@lists.infradead.org, Keiichirou Suzuki On 01/03/18 at 10:30am, Dave Young wrote: > On 01/02/18 at 05:08pm, Baoquan He wrote: > > On 01/02/18 at 04:57pm, Dave Young wrote: > > > The root cause is this commit makes mem_section as a pointer instead of > > > the static array. > > > > > > VMCOREINFO_SYMBOL() expand it as &mem_section, this is not correct in > > > the test case any more. > > > > > > This hack code works for me: > > > > > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > > > index b3663896278e..f5fe6068ae39 100644 > > > --- a/kernel/crash_core.c > > > +++ b/kernel/crash_core.c > > > @@ -376,6 +376,8 @@ phys_addr_t __weak paddr_vmcoreinfo_note(void) > > > { > > > return __pa(vmcoreinfo_note); > > > } > > > +#define VMCOREINFO_SYMBOL_HACK(name) \ > > > + vmcoreinfo_append_str("SYMBOL(%s)=%lx\n", #name, (unsigned long)name) > > > > Oh, you made a new one. We may use vmcoreinfo_append_str directly since > > there's an existing one in crash_save_vmcoreinfo(): > > Yes, it should be something like this instead, this should ensure > makedumpfile maybe crash tool works without any modifications, > waiting for feedback from Atsushi, also ccing Dave for crash utility > potential issue. > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > index b3663896278e..122494364179 100644 > --- a/kernel/crash_core.c > +++ b/kernel/crash_core.c > @@ -410,10 +410,16 @@ static int __init crash_save_vmcoreinfo_init(void) > VMCOREINFO_SYMBOL(contig_page_data); > #endif > #ifdef CONFIG_SPARSEMEM > +#ifdef CONFIG_SPARSEMEM_EXTREME > + vmcoreinfo_append_str("SYMBOL(mem_section)=%lx\n", > + (unsigned long)mem_section); > +#else > VMCOREINFO_SYMBOL(mem_section); > +#endif vmcoreinfo_append_str("SYMBOL(mem_section)=%lx\n", (unsigned long)mem_section); This is enough to cover both cases. mem_section is array name in non SPARSEMEM_EXTREME case, so value of &mem_section == value of mem_section. > VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); > VMCOREINFO_STRUCT_SIZE(mem_section); > VMCOREINFO_OFFSET(mem_section, section_mem_map); > + > #endif > VMCOREINFO_STRUCT_SIZE(page); > VMCOREINFO_STRUCT_SIZE(pglist_data); > > > > > vmcoreinfo_append_str("CRASHTIME=%ld\n", get_seconds()); > > > > The thing is that VMCOREINFO_SYMBOL will reference symbol. While > > checking all exported symbol, all of them are array names. So here > > the value of &array_name is equal to the address of the first element of > > array. Now the first exception appeared, mem_section, which could be not > > an array name, but a pointer pointing at the allocated memory. > > > > For this issue, we either change as Dave mentioned two options, or can > > we adjust VMCOREINFO_SYMBOL(name)? > > > > > > > > static int __init crash_save_vmcoreinfo_init(void) > > > { > > > @@ -410,10 +412,11 @@ static int __init crash_save_vmcoreinfo_init(void) > > > VMCOREINFO_SYMBOL(contig_page_data); > > > #endif > > > #ifdef CONFIG_SPARSEMEM > > > - VMCOREINFO_SYMBOL(mem_section); > > > + VMCOREINFO_SYMBOL_HACK(mem_section); > > > VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); > > > VMCOREINFO_STRUCT_SIZE(mem_section); > > > VMCOREINFO_OFFSET(mem_section, section_mem_map); > > > + > > > #endif > > > VMCOREINFO_STRUCT_SIZE(page); > > > VMCOREINFO_STRUCT_SIZE(pglist_data); > > > > > > > > > But probably we need this instead, but I can not test it because I do > > > not know how to fix makedumpfile to use a _NUMBER instead of a SYMBOL. > > > Thus bring up the issue, seeking for thoughts and discussion. > > > > > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > > > index b3663896278e..dfa2238e2c28 100644 > > > --- a/kernel/crash_core.c > > > +++ b/kernel/crash_core.c > > > @@ -410,10 +410,17 @@ static int __init crash_save_vmcoreinfo_init(void) > > > VMCOREINFO_SYMBOL(contig_page_data); > > > #endif > > > #ifdef CONFIG_SPARSEMEM > > > +#ifdef CONFIG_SPARSEMEM_EXTREME > > > + VMCOREINFO_NUMBER(mem_section); > > > +#else > > > VMCOREINFO_SYMBOL(mem_section); > > > +#endif > > > VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); > > > VMCOREINFO_STRUCT_SIZE(mem_section); > > > VMCOREINFO_OFFSET(mem_section, section_mem_map); > > > > > > [snip] > > > > > > Thanks > > > Dave _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec ^ permalink raw reply [flat|nested] 22+ messages in thread
* RE: makedumpfile saving vmcore fails with dynamically allocated mem_section (was: Re: [PATCH] handle renamed init_level4_pgt -> init_top_pgt) 2018-01-03 2:38 ` Baoquan He @ 2018-01-05 8:19 ` Atsushi Kumagai 2018-01-06 5:36 ` Dave Young 0 siblings, 1 reply; 22+ messages in thread From: Atsushi Kumagai @ 2018-01-05 8:19 UTC (permalink / raw) To: Baoquan He, Dave Young Cc: kexec@lists.infradead.org, Keiichirou Suzuki, Jeff Mahoney, anderson@redhat.com >On 01/03/18 at 10:30am, Dave Young wrote: >> On 01/02/18 at 05:08pm, Baoquan He wrote: >> > On 01/02/18 at 04:57pm, Dave Young wrote: >> > > The root cause is this commit makes mem_section as a pointer instead of >> > > the static array. >> > > >> > > VMCOREINFO_SYMBOL() expand it as &mem_section, this is not correct in >> > > the test case any more. >> > > >> > > This hack code works for me: >> > > >> > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c >> > > index b3663896278e..f5fe6068ae39 100644 >> > > --- a/kernel/crash_core.c >> > > +++ b/kernel/crash_core.c >> > > @@ -376,6 +376,8 @@ phys_addr_t __weak paddr_vmcoreinfo_note(void) >> > > { >> > > return __pa(vmcoreinfo_note); >> > > } >> > > +#define VMCOREINFO_SYMBOL_HACK(name) \ >> > > + vmcoreinfo_append_str("SYMBOL(%s)=%lx\n", #name, (unsigned long)name) >> > >> > Oh, you made a new one. We may use vmcoreinfo_append_str directly since >> > there's an existing one in crash_save_vmcoreinfo(): >> >> Yes, it should be something like this instead, this should ensure >> makedumpfile maybe crash tool works without any modifications, >> waiting for feedback from Atsushi, also ccing Dave for crash utility >> potential issue. makedumpfile needs some fix anyway since some logic depend on the array length of mem_section. I'm trying to fix it referring to the crash's fix. > I'll give priority to release v1.6.3 since the commit will not be included > in the supported kernel(4.14). The kernel change was merged also into kernel 4.14.9, I'm working on this issue for the next release(v1.6.3). Thanks, Atsushi Kumagai >> diff --git a/kernel/crash_core.c b/kernel/crash_core.c >> index b3663896278e..122494364179 100644 >> --- a/kernel/crash_core.c >> +++ b/kernel/crash_core.c >> @@ -410,10 +410,16 @@ static int __init crash_save_vmcoreinfo_init(void) >> VMCOREINFO_SYMBOL(contig_page_data); >> #endif >> #ifdef CONFIG_SPARSEMEM >> +#ifdef CONFIG_SPARSEMEM_EXTREME >> + vmcoreinfo_append_str("SYMBOL(mem_section)=%lx\n", >> + (unsigned long)mem_section); >> +#else >> VMCOREINFO_SYMBOL(mem_section); >> +#endif > > vmcoreinfo_append_str("SYMBOL(mem_section)=%lx\n", > (unsigned long)mem_section); > >This is enough to cover both cases. mem_section is array name in non >SPARSEMEM_EXTREME case, so value of &mem_section == value of >mem_section. > >> VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); >> VMCOREINFO_STRUCT_SIZE(mem_section); >> VMCOREINFO_OFFSET(mem_section, section_mem_map); >> + >> #endif >> VMCOREINFO_STRUCT_SIZE(page); >> VMCOREINFO_STRUCT_SIZE(pglist_data); >> >> > >> > vmcoreinfo_append_str("CRASHTIME=%ld\n", get_seconds()); >> > >> > The thing is that VMCOREINFO_SYMBOL will reference symbol. While >> > checking all exported symbol, all of them are array names. So here >> > the value of &array_name is equal to the address of the first element of >> > array. Now the first exception appeared, mem_section, which could be not >> > an array name, but a pointer pointing at the allocated memory. >> > >> > For this issue, we either change as Dave mentioned two options, or can >> > we adjust VMCOREINFO_SYMBOL(name)? >> > >> > > >> > > static int __init crash_save_vmcoreinfo_init(void) >> > > { >> > > @@ -410,10 +412,11 @@ static int __init crash_save_vmcoreinfo_init(void) >> > > VMCOREINFO_SYMBOL(contig_page_data); >> > > #endif >> > > #ifdef CONFIG_SPARSEMEM >> > > - VMCOREINFO_SYMBOL(mem_section); >> > > + VMCOREINFO_SYMBOL_HACK(mem_section); >> > > VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); >> > > VMCOREINFO_STRUCT_SIZE(mem_section); >> > > VMCOREINFO_OFFSET(mem_section, section_mem_map); >> > > + >> > > #endif >> > > VMCOREINFO_STRUCT_SIZE(page); >> > > VMCOREINFO_STRUCT_SIZE(pglist_data); >> > > >> > > >> > > But probably we need this instead, but I can not test it because I do >> > > not know how to fix makedumpfile to use a _NUMBER instead of a SYMBOL. >> > > Thus bring up the issue, seeking for thoughts and discussion. >> > > >> > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c >> > > index b3663896278e..dfa2238e2c28 100644 >> > > --- a/kernel/crash_core.c >> > > +++ b/kernel/crash_core.c >> > > @@ -410,10 +410,17 @@ static int __init crash_save_vmcoreinfo_init(void) >> > > VMCOREINFO_SYMBOL(contig_page_data); >> > > #endif >> > > #ifdef CONFIG_SPARSEMEM >> > > +#ifdef CONFIG_SPARSEMEM_EXTREME >> > > + VMCOREINFO_NUMBER(mem_section); >> > > +#else >> > > VMCOREINFO_SYMBOL(mem_section); >> > > +#endif >> > > VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); >> > > VMCOREINFO_STRUCT_SIZE(mem_section); >> > > VMCOREINFO_OFFSET(mem_section, section_mem_map); >> > > >> > > [snip] >> > > >> > > Thanks >> > > Dave _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: makedumpfile saving vmcore fails with dynamically allocated mem_section (was: Re: [PATCH] handle renamed init_level4_pgt -> init_top_pgt) 2018-01-05 8:19 ` Atsushi Kumagai @ 2018-01-06 5:36 ` Dave Young 2018-01-09 5:17 ` Atsushi Kumagai 0 siblings, 1 reply; 22+ messages in thread From: Dave Young @ 2018-01-06 5:36 UTC (permalink / raw) To: Atsushi Kumagai Cc: kexec@lists.infradead.org, Keiichirou Suzuki, Jeff Mahoney, anderson@redhat.com, Baoquan He On 01/05/18 at 08:19am, Atsushi Kumagai wrote: > >On 01/03/18 at 10:30am, Dave Young wrote: > >> On 01/02/18 at 05:08pm, Baoquan He wrote: > >> > On 01/02/18 at 04:57pm, Dave Young wrote: > >> > > The root cause is this commit makes mem_section as a pointer instead of > >> > > the static array. > >> > > > >> > > VMCOREINFO_SYMBOL() expand it as &mem_section, this is not correct in > >> > > the test case any more. > >> > > > >> > > This hack code works for me: > >> > > > >> > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > >> > > index b3663896278e..f5fe6068ae39 100644 > >> > > --- a/kernel/crash_core.c > >> > > +++ b/kernel/crash_core.c > >> > > @@ -376,6 +376,8 @@ phys_addr_t __weak paddr_vmcoreinfo_note(void) > >> > > { > >> > > return __pa(vmcoreinfo_note); > >> > > } > >> > > +#define VMCOREINFO_SYMBOL_HACK(name) \ > >> > > + vmcoreinfo_append_str("SYMBOL(%s)=%lx\n", #name, (unsigned long)name) > >> > > >> > Oh, you made a new one. We may use vmcoreinfo_append_str directly since > >> > there's an existing one in crash_save_vmcoreinfo(): > >> > >> Yes, it should be something like this instead, this should ensure > >> makedumpfile maybe crash tool works without any modifications, > >> waiting for feedback from Atsushi, also ccing Dave for crash utility > >> potential issue. > > makedumpfile needs some fix anyway since some logic depend on the array length > of mem_section. I'm trying to fix it referring to the crash's fix. Hmm, a makedumpfile only fix is enough for this issue? > > > I'll give priority to release v1.6.3 since the commit will not be included > > in the supported kernel(4.14). > > The kernel change was merged also into kernel 4.14.9, I'm working on this issue > for the next release(v1.6.3). > > Thanks, > Atsushi Kumagai > > >> diff --git a/kernel/crash_core.c b/kernel/crash_core.c > >> index b3663896278e..122494364179 100644 > >> --- a/kernel/crash_core.c > >> +++ b/kernel/crash_core.c > >> @@ -410,10 +410,16 @@ static int __init crash_save_vmcoreinfo_init(void) > >> VMCOREINFO_SYMBOL(contig_page_data); > >> #endif > >> #ifdef CONFIG_SPARSEMEM > >> +#ifdef CONFIG_SPARSEMEM_EXTREME > >> + vmcoreinfo_append_str("SYMBOL(mem_section)=%lx\n", > >> + (unsigned long)mem_section); > >> +#else > >> VMCOREINFO_SYMBOL(mem_section); > >> +#endif > > > > vmcoreinfo_append_str("SYMBOL(mem_section)=%lx\n", > > (unsigned long)mem_section); > > > >This is enough to cover both cases. mem_section is array name in non > >SPARSEMEM_EXTREME case, so value of &mem_section == value of > >mem_section. > > > >> VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); > >> VMCOREINFO_STRUCT_SIZE(mem_section); > >> VMCOREINFO_OFFSET(mem_section, section_mem_map); > >> + > >> #endif > >> VMCOREINFO_STRUCT_SIZE(page); > >> VMCOREINFO_STRUCT_SIZE(pglist_data); > >> > >> > > >> > vmcoreinfo_append_str("CRASHTIME=%ld\n", get_seconds()); > >> > > >> > The thing is that VMCOREINFO_SYMBOL will reference symbol. While > >> > checking all exported symbol, all of them are array names. So here > >> > the value of &array_name is equal to the address of the first element of > >> > array. Now the first exception appeared, mem_section, which could be not > >> > an array name, but a pointer pointing at the allocated memory. > >> > > >> > For this issue, we either change as Dave mentioned two options, or can > >> > we adjust VMCOREINFO_SYMBOL(name)? > >> > > >> > > > >> > > static int __init crash_save_vmcoreinfo_init(void) > >> > > { > >> > > @@ -410,10 +412,11 @@ static int __init crash_save_vmcoreinfo_init(void) > >> > > VMCOREINFO_SYMBOL(contig_page_data); > >> > > #endif > >> > > #ifdef CONFIG_SPARSEMEM > >> > > - VMCOREINFO_SYMBOL(mem_section); > >> > > + VMCOREINFO_SYMBOL_HACK(mem_section); > >> > > VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); > >> > > VMCOREINFO_STRUCT_SIZE(mem_section); > >> > > VMCOREINFO_OFFSET(mem_section, section_mem_map); > >> > > + > >> > > #endif > >> > > VMCOREINFO_STRUCT_SIZE(page); > >> > > VMCOREINFO_STRUCT_SIZE(pglist_data); > >> > > > >> > > > >> > > But probably we need this instead, but I can not test it because I do > >> > > not know how to fix makedumpfile to use a _NUMBER instead of a SYMBOL. > >> > > Thus bring up the issue, seeking for thoughts and discussion. > >> > > > >> > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > >> > > index b3663896278e..dfa2238e2c28 100644 > >> > > --- a/kernel/crash_core.c > >> > > +++ b/kernel/crash_core.c > >> > > @@ -410,10 +410,17 @@ static int __init crash_save_vmcoreinfo_init(void) > >> > > VMCOREINFO_SYMBOL(contig_page_data); > >> > > #endif > >> > > #ifdef CONFIG_SPARSEMEM > >> > > +#ifdef CONFIG_SPARSEMEM_EXTREME > >> > > + VMCOREINFO_NUMBER(mem_section); > >> > > +#else > >> > > VMCOREINFO_SYMBOL(mem_section); > >> > > +#endif > >> > > VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); > >> > > VMCOREINFO_STRUCT_SIZE(mem_section); > >> > > VMCOREINFO_OFFSET(mem_section, section_mem_map); > >> > > > >> > > [snip] > >> > > > >> > > Thanks > >> > > Dave > > Thanks Dave _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec ^ permalink raw reply [flat|nested] 22+ messages in thread
* RE: makedumpfile saving vmcore fails with dynamically allocated mem_section (was: Re: [PATCH] handle renamed init_level4_pgt -> init_top_pgt) 2018-01-06 5:36 ` Dave Young @ 2018-01-09 5:17 ` Atsushi Kumagai 2018-01-09 5:33 ` Dave Young 0 siblings, 1 reply; 22+ messages in thread From: Atsushi Kumagai @ 2018-01-09 5:17 UTC (permalink / raw) To: Dave Young Cc: anderson@redhat.com, Keiichirou Suzuki, Jeff Mahoney, kexec@lists.infradead.org, Baoquan He >> >> > > The root cause is this commit makes mem_section as a pointer instead of >> >> > > the static array. >> >> > > >> >> > > VMCOREINFO_SYMBOL() expand it as &mem_section, this is not correct in >> >> > > the test case any more. >> >> > > >> >> > > This hack code works for me: >> >> > > >> >> > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c >> >> > > index b3663896278e..f5fe6068ae39 100644 >> >> > > --- a/kernel/crash_core.c >> >> > > +++ b/kernel/crash_core.c >> >> > > @@ -376,6 +376,8 @@ phys_addr_t __weak paddr_vmcoreinfo_note(void) >> >> > > { >> >> > > return __pa(vmcoreinfo_note); >> >> > > } >> >> > > +#define VMCOREINFO_SYMBOL_HACK(name) \ >> >> > > + vmcoreinfo_append_str("SYMBOL(%s)=%lx\n", #name, (unsigned long)name) >> >> > >> >> > Oh, you made a new one. We may use vmcoreinfo_append_str directly since >> >> > there's an existing one in crash_save_vmcoreinfo(): >> >> >> >> Yes, it should be something like this instead, this should ensure >> >> makedumpfile maybe crash tool works without any modifications, >> >> waiting for feedback from Atsushi, also ccing Dave for crash utility >> >> potential issue. >> >> makedumpfile needs some fix anyway since some logic depend on the array length >> of mem_section. I'm trying to fix it referring to the crash's fix. > >Hmm, a makedumpfile only fix is enough for this issue? Sorry, it was thoughtless of me. The crash's fix uses dwarf info, the kernel side fix you thought is necessary for makedumpfile to work without vmlinux. Thanks, Atsushi Kumagai >> >> > I'll give priority to release v1.6.3 since the commit will not be included >> > in the supported kernel(4.14). >> >> The kernel change was merged also into kernel 4.14.9, I'm working on this issue >> for the next release(v1.6.3). >> >> Thanks, >> Atsushi Kumagai >> >> >> diff --git a/kernel/crash_core.c b/kernel/crash_core.c >> >> index b3663896278e..122494364179 100644 >> >> --- a/kernel/crash_core.c >> >> +++ b/kernel/crash_core.c >> >> @@ -410,10 +410,16 @@ static int __init crash_save_vmcoreinfo_init(void) >> >> VMCOREINFO_SYMBOL(contig_page_data); >> >> #endif >> >> #ifdef CONFIG_SPARSEMEM >> >> +#ifdef CONFIG_SPARSEMEM_EXTREME >> >> + vmcoreinfo_append_str("SYMBOL(mem_section)=%lx\n", >> >> + (unsigned long)mem_section); >> >> +#else >> >> VMCOREINFO_SYMBOL(mem_section); >> >> +#endif >> > >> > vmcoreinfo_append_str("SYMBOL(mem_section)=%lx\n", >> > (unsigned long)mem_section); >> > >> >This is enough to cover both cases. mem_section is array name in non >> >SPARSEMEM_EXTREME case, so value of &mem_section == value of >> >mem_section. >> > >> >> VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); >> >> VMCOREINFO_STRUCT_SIZE(mem_section); >> >> VMCOREINFO_OFFSET(mem_section, section_mem_map); >> >> + >> >> #endif >> >> VMCOREINFO_STRUCT_SIZE(page); >> >> VMCOREINFO_STRUCT_SIZE(pglist_data); >> >> >> >> > >> >> > vmcoreinfo_append_str("CRASHTIME=%ld\n", get_seconds()); >> >> > >> >> > The thing is that VMCOREINFO_SYMBOL will reference symbol. While >> >> > checking all exported symbol, all of them are array names. So here >> >> > the value of &array_name is equal to the address of the first element of >> >> > array. Now the first exception appeared, mem_section, which could be not >> >> > an array name, but a pointer pointing at the allocated memory. >> >> > >> >> > For this issue, we either change as Dave mentioned two options, or can >> >> > we adjust VMCOREINFO_SYMBOL(name)? >> >> > >> >> > > >> >> > > static int __init crash_save_vmcoreinfo_init(void) >> >> > > { >> >> > > @@ -410,10 +412,11 @@ static int __init crash_save_vmcoreinfo_init(void) >> >> > > VMCOREINFO_SYMBOL(contig_page_data); >> >> > > #endif >> >> > > #ifdef CONFIG_SPARSEMEM >> >> > > - VMCOREINFO_SYMBOL(mem_section); >> >> > > + VMCOREINFO_SYMBOL_HACK(mem_section); >> >> > > VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); >> >> > > VMCOREINFO_STRUCT_SIZE(mem_section); >> >> > > VMCOREINFO_OFFSET(mem_section, section_mem_map); >> >> > > + >> >> > > #endif >> >> > > VMCOREINFO_STRUCT_SIZE(page); >> >> > > VMCOREINFO_STRUCT_SIZE(pglist_data); >> >> > > >> >> > > >> >> > > But probably we need this instead, but I can not test it because I do >> >> > > not know how to fix makedumpfile to use a _NUMBER instead of a SYMBOL. >> >> > > Thus bring up the issue, seeking for thoughts and discussion. >> >> > > >> >> > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c >> >> > > index b3663896278e..dfa2238e2c28 100644 >> >> > > --- a/kernel/crash_core.c >> >> > > +++ b/kernel/crash_core.c >> >> > > @@ -410,10 +410,17 @@ static int __init crash_save_vmcoreinfo_init(void) >> >> > > VMCOREINFO_SYMBOL(contig_page_data); >> >> > > #endif >> >> > > #ifdef CONFIG_SPARSEMEM >> >> > > +#ifdef CONFIG_SPARSEMEM_EXTREME >> >> > > + VMCOREINFO_NUMBER(mem_section); >> >> > > +#else >> >> > > VMCOREINFO_SYMBOL(mem_section); >> >> > > +#endif >> >> > > VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); >> >> > > VMCOREINFO_STRUCT_SIZE(mem_section); >> >> > > VMCOREINFO_OFFSET(mem_section, section_mem_map); >> >> > > >> >> > > [snip] >> >> > > >> >> > > Thanks >> >> > > Dave >> >> > >Thanks >Dave > >_______________________________________________ >kexec mailing list >kexec@lists.infradead.org >http://lists.infradead.org/mailman/listinfo/kexec _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: makedumpfile saving vmcore fails with dynamically allocated mem_section (was: Re: [PATCH] handle renamed init_level4_pgt -> init_top_pgt) 2018-01-09 5:17 ` Atsushi Kumagai @ 2018-01-09 5:33 ` Dave Young 0 siblings, 0 replies; 22+ messages in thread From: Dave Young @ 2018-01-09 5:33 UTC (permalink / raw) To: Atsushi Kumagai Cc: Keiichirou Suzuki, Baoquan He, Jeff Mahoney, kexec@lists.infradead.org, anderson@redhat.com, kirill On 01/09/18 at 05:17am, Atsushi Kumagai wrote: > >> >> > > The root cause is this commit makes mem_section as a pointer instead of > >> >> > > the static array. > >> >> > > > >> >> > > VMCOREINFO_SYMBOL() expand it as &mem_section, this is not correct in > >> >> > > the test case any more. > >> >> > > > >> >> > > This hack code works for me: > >> >> > > > >> >> > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > >> >> > > index b3663896278e..f5fe6068ae39 100644 > >> >> > > --- a/kernel/crash_core.c > >> >> > > +++ b/kernel/crash_core.c > >> >> > > @@ -376,6 +376,8 @@ phys_addr_t __weak paddr_vmcoreinfo_note(void) > >> >> > > { > >> >> > > return __pa(vmcoreinfo_note); > >> >> > > } > >> >> > > +#define VMCOREINFO_SYMBOL_HACK(name) \ > >> >> > > + vmcoreinfo_append_str("SYMBOL(%s)=%lx\n", #name, (unsigned long)name) > >> >> > > >> >> > Oh, you made a new one. We may use vmcoreinfo_append_str directly since > >> >> > there's an existing one in crash_save_vmcoreinfo(): > >> >> > >> >> Yes, it should be something like this instead, this should ensure > >> >> makedumpfile maybe crash tool works without any modifications, > >> >> waiting for feedback from Atsushi, also ccing Dave for crash utility > >> >> potential issue. > >> > >> makedumpfile needs some fix anyway since some logic depend on the array length > >> of mem_section. I'm trying to fix it referring to the crash's fix. > > > >Hmm, a makedumpfile only fix is enough for this issue? > > Sorry, it was thoughtless of me. The crash's fix uses dwarf info, > the kernel side fix you thought is necessary for makedumpfile to work without > vmlinux. Ok, Kirill A. Shutemov posted a similar fix which can solve it. > > > Thanks, > Atsushi Kumagai > > >> > >> > I'll give priority to release v1.6.3 since the commit will not be included > >> > in the supported kernel(4.14). > >> > >> The kernel change was merged also into kernel 4.14.9, I'm working on this issue > >> for the next release(v1.6.3). > >> > >> Thanks, > >> Atsushi Kumagai > >> > >> >> diff --git a/kernel/crash_core.c b/kernel/crash_core.c > >> >> index b3663896278e..122494364179 100644 > >> >> --- a/kernel/crash_core.c > >> >> +++ b/kernel/crash_core.c > >> >> @@ -410,10 +410,16 @@ static int __init crash_save_vmcoreinfo_init(void) > >> >> VMCOREINFO_SYMBOL(contig_page_data); > >> >> #endif > >> >> #ifdef CONFIG_SPARSEMEM > >> >> +#ifdef CONFIG_SPARSEMEM_EXTREME > >> >> + vmcoreinfo_append_str("SYMBOL(mem_section)=%lx\n", > >> >> + (unsigned long)mem_section); > >> >> +#else > >> >> VMCOREINFO_SYMBOL(mem_section); > >> >> +#endif > >> > > >> > vmcoreinfo_append_str("SYMBOL(mem_section)=%lx\n", > >> > (unsigned long)mem_section); > >> > > >> >This is enough to cover both cases. mem_section is array name in non > >> >SPARSEMEM_EXTREME case, so value of &mem_section == value of > >> >mem_section. > >> > > >> >> VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); > >> >> VMCOREINFO_STRUCT_SIZE(mem_section); > >> >> VMCOREINFO_OFFSET(mem_section, section_mem_map); > >> >> + > >> >> #endif > >> >> VMCOREINFO_STRUCT_SIZE(page); > >> >> VMCOREINFO_STRUCT_SIZE(pglist_data); > >> >> > >> >> > > >> >> > vmcoreinfo_append_str("CRASHTIME=%ld\n", get_seconds()); > >> >> > > >> >> > The thing is that VMCOREINFO_SYMBOL will reference symbol. While > >> >> > checking all exported symbol, all of them are array names. So here > >> >> > the value of &array_name is equal to the address of the first element of > >> >> > array. Now the first exception appeared, mem_section, which could be not > >> >> > an array name, but a pointer pointing at the allocated memory. > >> >> > > >> >> > For this issue, we either change as Dave mentioned two options, or can > >> >> > we adjust VMCOREINFO_SYMBOL(name)? > >> >> > > >> >> > > > >> >> > > static int __init crash_save_vmcoreinfo_init(void) > >> >> > > { > >> >> > > @@ -410,10 +412,11 @@ static int __init crash_save_vmcoreinfo_init(void) > >> >> > > VMCOREINFO_SYMBOL(contig_page_data); > >> >> > > #endif > >> >> > > #ifdef CONFIG_SPARSEMEM > >> >> > > - VMCOREINFO_SYMBOL(mem_section); > >> >> > > + VMCOREINFO_SYMBOL_HACK(mem_section); > >> >> > > VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); > >> >> > > VMCOREINFO_STRUCT_SIZE(mem_section); > >> >> > > VMCOREINFO_OFFSET(mem_section, section_mem_map); > >> >> > > + > >> >> > > #endif > >> >> > > VMCOREINFO_STRUCT_SIZE(page); > >> >> > > VMCOREINFO_STRUCT_SIZE(pglist_data); > >> >> > > > >> >> > > > >> >> > > But probably we need this instead, but I can not test it because I do > >> >> > > not know how to fix makedumpfile to use a _NUMBER instead of a SYMBOL. > >> >> > > Thus bring up the issue, seeking for thoughts and discussion. > >> >> > > > >> >> > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > >> >> > > index b3663896278e..dfa2238e2c28 100644 > >> >> > > --- a/kernel/crash_core.c > >> >> > > +++ b/kernel/crash_core.c > >> >> > > @@ -410,10 +410,17 @@ static int __init crash_save_vmcoreinfo_init(void) > >> >> > > VMCOREINFO_SYMBOL(contig_page_data); > >> >> > > #endif > >> >> > > #ifdef CONFIG_SPARSEMEM > >> >> > > +#ifdef CONFIG_SPARSEMEM_EXTREME > >> >> > > + VMCOREINFO_NUMBER(mem_section); > >> >> > > +#else > >> >> > > VMCOREINFO_SYMBOL(mem_section); > >> >> > > +#endif > >> >> > > VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); > >> >> > > VMCOREINFO_STRUCT_SIZE(mem_section); > >> >> > > VMCOREINFO_OFFSET(mem_section, section_mem_map); > >> >> > > > >> >> > > [snip] > >> >> > > > >> >> > > Thanks > >> >> > > Dave > >> > >> > > > >Thanks > >Dave > > > >_______________________________________________ > >kexec mailing list > >kexec@lists.infradead.org > >http://lists.infradead.org/mailman/listinfo/kexec > > _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec ^ permalink raw reply [flat|nested] 22+ messages in thread
[parent not found: <mailman.7.1515009607.12089.kexec@lists.infradead.org>]
* Re: makedumpfile saving vmcore fails with dynamically allocated mem_section (was: Re: [PATCH] handle renamed init_level4_pgt -> init_top_pgt) [not found] <mailman.7.1515009607.12089.kexec@lists.infradead.org> @ 2018-01-03 20:21 ` Dave Anderson 2018-01-05 2:38 ` Dave Young 0 siblings, 1 reply; 22+ messages in thread From: Dave Anderson @ 2018-01-03 20:21 UTC (permalink / raw) To: kexec ----- Original Message ----- > On 01/02/18 at 05:08pm, Baoquan He wrote: > > On 01/02/18 at 04:57pm, Dave Young wrote: > > > The root cause is this commit makes mem_section as a pointer instead of > > > the static array. > > > > > > VMCOREINFO_SYMBOL() expand it as &mem_section, this is not correct in > > > the test case any more. > > > > > > This hack code works for me: > > > > > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > > > index b3663896278e..f5fe6068ae39 100644 > > > --- a/kernel/crash_core.c > > > +++ b/kernel/crash_core.c > > > @@ -376,6 +376,8 @@ phys_addr_t __weak paddr_vmcoreinfo_note(void) > > > { > > > return __pa(vmcoreinfo_note); > > > } > > > +#define VMCOREINFO_SYMBOL_HACK(name) \ > > > + vmcoreinfo_append_str("SYMBOL(%s)=%lx\n", #name, (unsigned long)name) > > > > Oh, you made a new one. We may use vmcoreinfo_append_str directly since > > there's an existing one in crash_save_vmcoreinfo(): > > Yes, it should be something like this instead, this should ensure > makedumpfile maybe crash tool works without any modifications, > waiting for feedback from Atsushi, also ccing Dave for crash utility > potential issue. Yeah, I ran into that issue when testing 4.15, and fixed it upstream: https://github.com/crash-utility/crash/commit/264f22dafe9f37780c4113fd08e8d5b2138edbce commit 264f22dafe9f37780c4113fd08e8d5b2138edbce Author: Dave Anderson <anderson@redhat.com> Date: Wed Nov 29 15:28:41 2017 -0500 Fix for Linux 4.15 and later kernels that are configured with CONFIG_SPARSEMEM_EXTREME, and that contain kernel commit 83e3c48729d9ebb7af5a31a504f3fd6aff0348c4, titled "mm/sparsemem: Allocate mem_section at runtime for CONFIG_SPARSEMEM_EXTREME=y". Without the patch, kernels configured with SPARSEMEM_EXTREME have changed the data type of "mem_section" from an array to a pointer, leading to errors in commands such as "kmem -p", "kmem -n", "kmem -s", and any other command that translates a physical address to its page struct address. (anderson@redhat.com) Thanks, Dave > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > index b3663896278e..122494364179 100644 > --- a/kernel/crash_core.c > +++ b/kernel/crash_core.c > @@ -410,10 +410,16 @@ static int __init crash_save_vmcoreinfo_init(void) > VMCOREINFO_SYMBOL(contig_page_data); > #endif > #ifdef CONFIG_SPARSEMEM > +#ifdef CONFIG_SPARSEMEM_EXTREME > + vmcoreinfo_append_str("SYMBOL(mem_section)=%lx\n", > + (unsigned long)mem_section); > +#else > VMCOREINFO_SYMBOL(mem_section); > +#endif > VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); > VMCOREINFO_STRUCT_SIZE(mem_section); > VMCOREINFO_OFFSET(mem_section, section_mem_map); > + > #endif > VMCOREINFO_STRUCT_SIZE(page); > VMCOREINFO_STRUCT_SIZE(pglist_data); > > > > > vmcoreinfo_append_str("CRASHTIME=%ld\n", get_seconds()); > > > > The thing is that VMCOREINFO_SYMBOL will reference symbol. While > > checking all exported symbol, all of them are array names. So here > > the value of &array_name is equal to the address of the first element of > > array. Now the first exception appeared, mem_section, which could be not > > an array name, but a pointer pointing at the allocated memory. > > > > For this issue, we either change as Dave mentioned two options, or can > > we adjust VMCOREINFO_SYMBOL(name)? > > > > > > > > static int __init crash_save_vmcoreinfo_init(void) > > > { > > > @@ -410,10 +412,11 @@ static int __init crash_save_vmcoreinfo_init(void) > > > VMCOREINFO_SYMBOL(contig_page_data); > > > #endif > > > #ifdef CONFIG_SPARSEMEM > > > - VMCOREINFO_SYMBOL(mem_section); > > > + VMCOREINFO_SYMBOL_HACK(mem_section); > > > VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); > > > VMCOREINFO_STRUCT_SIZE(mem_section); > > > VMCOREINFO_OFFSET(mem_section, section_mem_map); > > > + > > > #endif > > > VMCOREINFO_STRUCT_SIZE(page); > > > VMCOREINFO_STRUCT_SIZE(pglist_data); > > > > > > > > > But probably we need this instead, but I can not test it because I do > > > not know how to fix makedumpfile to use a _NUMBER instead of a SYMBOL. > > > Thus bring up the issue, seeking for thoughts and discussion. > > > > > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > > > index b3663896278e..dfa2238e2c28 100644 > > > --- a/kernel/crash_core.c > > > +++ b/kernel/crash_core.c > > > @@ -410,10 +410,17 @@ static int __init crash_save_vmcoreinfo_init(void) > > > VMCOREINFO_SYMBOL(contig_page_data); > > > #endif > > > #ifdef CONFIG_SPARSEMEM > > > +#ifdef CONFIG_SPARSEMEM_EXTREME > > > + VMCOREINFO_NUMBER(mem_section); > > > +#else > > > VMCOREINFO_SYMBOL(mem_section); > > > +#endif > > > VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); > > > VMCOREINFO_STRUCT_SIZE(mem_section); > > > VMCOREINFO_OFFSET(mem_section, section_mem_map); > > > > > > [snip] > > > > > > Thanks > > > Dave > > > > ------------------------------ > > Message: 2 > Date: Wed, 3 Jan 2018 10:38:35 +0800 > From: Baoquan He <bhe@redhat.com> > To: Dave Young <dyoung@redhat.com> > Cc: Atsushi Kumagai <ats-kumagai@wm.jp.nec.com>, Keiichirou Suzuki > <kei-suzuki@xr.jp.nec.com>, Jeff Mahoney <jeffm@suse.com>, > "anderson@redhat.com kexec@lists.infradead.org" > <kexec@lists.infradead.org> > Subject: Re: makedumpfile saving vmcore fails with dynamically > allocated mem_section (was: Re: [PATCH] handle renamed init_level4_pgt > -> init_top_pgt) > Message-ID: <20180103023835.GB2338@x1> > Content-Type: text/plain; charset=us-ascii > > On 01/03/18 at 10:30am, Dave Young wrote: > > On 01/02/18 at 05:08pm, Baoquan He wrote: > > > On 01/02/18 at 04:57pm, Dave Young wrote: > > > > The root cause is this commit makes mem_section as a pointer instead of > > > > the static array. > > > > > > > > VMCOREINFO_SYMBOL() expand it as &mem_section, this is not correct in > > > > the test case any more. > > > > > > > > This hack code works for me: > > > > > > > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > > > > index b3663896278e..f5fe6068ae39 100644 > > > > --- a/kernel/crash_core.c > > > > +++ b/kernel/crash_core.c > > > > @@ -376,6 +376,8 @@ phys_addr_t __weak paddr_vmcoreinfo_note(void) > > > > { > > > > return __pa(vmcoreinfo_note); > > > > } > > > > +#define VMCOREINFO_SYMBOL_HACK(name) \ > > > > + vmcoreinfo_append_str("SYMBOL(%s)=%lx\n", #name, (unsigned long)name) > > > > > > Oh, you made a new one. We may use vmcoreinfo_append_str directly since > > > there's an existing one in crash_save_vmcoreinfo(): > > > > Yes, it should be something like this instead, this should ensure > > makedumpfile maybe crash tool works without any modifications, > > waiting for feedback from Atsushi, also ccing Dave for crash utility > > potential issue. > > > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > > index b3663896278e..122494364179 100644 > > --- a/kernel/crash_core.c > > +++ b/kernel/crash_core.c > > @@ -410,10 +410,16 @@ static int __init crash_save_vmcoreinfo_init(void) > > VMCOREINFO_SYMBOL(contig_page_data); > > #endif > > #ifdef CONFIG_SPARSEMEM > > +#ifdef CONFIG_SPARSEMEM_EXTREME > > + vmcoreinfo_append_str("SYMBOL(mem_section)=%lx\n", > > + (unsigned long)mem_section); > > +#else > > VMCOREINFO_SYMBOL(mem_section); > > +#endif > > vmcoreinfo_append_str("SYMBOL(mem_section)=%lx\n", > (unsigned long)mem_section); > > This is enough to cover both cases. mem_section is array name in non > SPARSEMEM_EXTREME case, so value of &mem_section == value of > mem_section. > > > VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); > > VMCOREINFO_STRUCT_SIZE(mem_section); > > VMCOREINFO_OFFSET(mem_section, section_mem_map); > > + > > #endif > > VMCOREINFO_STRUCT_SIZE(page); > > VMCOREINFO_STRUCT_SIZE(pglist_data); > > > > > > > > vmcoreinfo_append_str("CRASHTIME=%ld\n", get_seconds()); > > > > > > The thing is that VMCOREINFO_SYMBOL will reference symbol. While > > > checking all exported symbol, all of them are array names. So here > > > the value of &array_name is equal to the address of the first element of > > > array. Now the first exception appeared, mem_section, which could be not > > > an array name, but a pointer pointing at the allocated memory. > > > > > > For this issue, we either change as Dave mentioned two options, or can > > > we adjust VMCOREINFO_SYMBOL(name)? > > > > > > > > > > > static int __init crash_save_vmcoreinfo_init(void) > > > > { > > > > @@ -410,10 +412,11 @@ static int __init > > > > crash_save_vmcoreinfo_init(void) > > > > VMCOREINFO_SYMBOL(contig_page_data); > > > > #endif > > > > #ifdef CONFIG_SPARSEMEM > > > > - VMCOREINFO_SYMBOL(mem_section); > > > > + VMCOREINFO_SYMBOL_HACK(mem_section); > > > > VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); > > > > VMCOREINFO_STRUCT_SIZE(mem_section); > > > > VMCOREINFO_OFFSET(mem_section, section_mem_map); > > > > + > > > > #endif > > > > VMCOREINFO_STRUCT_SIZE(page); > > > > VMCOREINFO_STRUCT_SIZE(pglist_data); > > > > > > > > > > > > But probably we need this instead, but I can not test it because I do > > > > not know how to fix makedumpfile to use a _NUMBER instead of a SYMBOL. > > > > Thus bring up the issue, seeking for thoughts and discussion. > > > > > > > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > > > > index b3663896278e..dfa2238e2c28 100644 > > > > --- a/kernel/crash_core.c > > > > +++ b/kernel/crash_core.c > > > > @@ -410,10 +410,17 @@ static int __init > > > > crash_save_vmcoreinfo_init(void) > > > > VMCOREINFO_SYMBOL(contig_page_data); > > > > #endif > > > > #ifdef CONFIG_SPARSEMEM > > > > +#ifdef CONFIG_SPARSEMEM_EXTREME > > > > + VMCOREINFO_NUMBER(mem_section); > > > > +#else > > > > VMCOREINFO_SYMBOL(mem_section); > > > > +#endif > > > > VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); > > > > VMCOREINFO_STRUCT_SIZE(mem_section); > > > > VMCOREINFO_OFFSET(mem_section, section_mem_map); > > > > > > > > [snip] > > > > > > > > Thanks > > > > Dave > > > > ------------------------------ > > Subject: Digest Footer > > _______________________________________________ > kexec mailing list > kexec@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/kexec > > > ------------------------------ > > End of kexec Digest, Vol 130, Issue 2 > ************************************* > _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: makedumpfile saving vmcore fails with dynamically allocated mem_section (was: Re: [PATCH] handle renamed init_level4_pgt -> init_top_pgt) 2018-01-03 20:21 ` Dave Anderson @ 2018-01-05 2:38 ` Dave Young 2018-01-05 3:19 ` Dave Young 2018-01-05 14:16 ` Dave Anderson 0 siblings, 2 replies; 22+ messages in thread From: Dave Young @ 2018-01-05 2:38 UTC (permalink / raw) To: Dave Anderson; +Cc: kexec On 01/03/18 at 03:21pm, Dave Anderson wrote: > > > ----- Original Message ----- > > > On 01/02/18 at 05:08pm, Baoquan He wrote: > > > On 01/02/18 at 04:57pm, Dave Young wrote: > > > > The root cause is this commit makes mem_section as a pointer instead of > > > > the static array. > > > > > > > > VMCOREINFO_SYMBOL() expand it as &mem_section, this is not correct in > > > > the test case any more. > > > > > > > > This hack code works for me: > > > > > > > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > > > > index b3663896278e..f5fe6068ae39 100644 > > > > --- a/kernel/crash_core.c > > > > +++ b/kernel/crash_core.c > > > > @@ -376,6 +376,8 @@ phys_addr_t __weak paddr_vmcoreinfo_note(void) > > > > { > > > > return __pa(vmcoreinfo_note); > > > > } > > > > +#define VMCOREINFO_SYMBOL_HACK(name) \ > > > > + vmcoreinfo_append_str("SYMBOL(%s)=%lx\n", #name, (unsigned long)name) > > > > > > Oh, you made a new one. We may use vmcoreinfo_append_str directly since > > > there's an existing one in crash_save_vmcoreinfo(): > > > > Yes, it should be something like this instead, this should ensure > > makedumpfile maybe crash tool works without any modifications, > > waiting for feedback from Atsushi, also ccing Dave for crash utility > > potential issue. > > Yeah, I ran into that issue when testing 4.15, and fixed it upstream: > > https://github.com/crash-utility/crash/commit/264f22dafe9f37780c4113fd08e8d5b2138edbce > > commit 264f22dafe9f37780c4113fd08e8d5b2138edbce > Author: Dave Anderson <anderson@redhat.com> > Date: Wed Nov 29 15:28:41 2017 -0500 > > Fix for Linux 4.15 and later kernels that are configured with > CONFIG_SPARSEMEM_EXTREME, and that contain kernel commit > 83e3c48729d9ebb7af5a31a504f3fd6aff0348c4, titled "mm/sparsemem: > Allocate mem_section at runtime for CONFIG_SPARSEMEM_EXTREME=y". > Without the patch, kernels configured with SPARSEMEM_EXTREME > have changed the data type of "mem_section" from an array to > a pointer, leading to errors in commands such as "kmem -p", > "kmem -n", "kmem -s", and any other command that translates a > physical address to its page struct address. > (anderson@redhat.com) > Hi Dave, I tried latest crash tool, but segment fault happened, I put the vmlinux/vmcore in below url, could you have a look?: http://people.redhat.com/ruyang/rhbz1528542/127.0.0.1-2018-01-05-10:29:23/ --- crash 7.2.0++ Copyright (C) 2002-2017 Red Hat, Inc. Copyright (C) 2004, 2005, 2006, 2010 IBM Corporation Copyright (C) 1999-2006 Hewlett-Packard Co Copyright (C) 2005, 2006, 2011, 2012 Fujitsu Limited Copyright (C) 2006, 2007 VA Linux Systems Japan K.K. Copyright (C) 2005, 2011 NEC Corporation Copyright (C) 1999, 2002, 2007 Silicon Graphics, Inc. Copyright (C) 1999, 2000, 2001, 2002 Mission Critical Linux, Inc. This program is free software, covered by the GNU General Public License, and you are welcome to change it and/or distribute copies of it under certain conditions. Enter "help copying" to see the conditions. This program has absolutely no warranty. Enter "help warranty" for details. GNU gdb (GDB) 7.6 Copyright (C) 2013 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "x86_64-unknown-linux-gnu"... WARNING: could not find MAGIC_START! WARNING: kernel version inconsistency between vmlinux and dumpfile please wait... (gathering task table data) WARNING: duplicate idle tasks? WARNING: duplicate idle tasks? please wait... (determining panic task) WARNING: active task ffffffff81e90536 on cpu 0 not found in PID hash [ 1156.567444] crash[2964]: segfault at 7175228 ip 00000000004bf39e sp 00007ffd5dce3f30 error 6 in crash[400000+6da000] Segmentation fault (core dumped) The tested kernel applied below patch (a tuned patch according to bhe's suggestion): --- kernel/crash_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- linux.orig/kernel/crash_core.c +++ linux/kernel/crash_core.c @@ -410,7 +410,8 @@ static int __init crash_save_vmcoreinfo_ VMCOREINFO_SYMBOL(contig_page_data); #endif #ifdef CONFIG_SPARSEMEM - VMCOREINFO_SYMBOL(mem_section); + vmcoreinfo_append_str("SYMBOL(mem_section)=%lx\n", + (unsigned long)mem_section); VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); VMCOREINFO_STRUCT_SIZE(mem_section); VMCOREINFO_OFFSET(mem_section, section_mem_map); Thanks Dave _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: makedumpfile saving vmcore fails with dynamically allocated mem_section (was: Re: [PATCH] handle renamed init_level4_pgt -> init_top_pgt) 2018-01-05 2:38 ` Dave Young @ 2018-01-05 3:19 ` Dave Young 2018-01-05 14:16 ` Dave Anderson 1 sibling, 0 replies; 22+ messages in thread From: Dave Young @ 2018-01-05 3:19 UTC (permalink / raw) To: Dave Anderson; +Cc: kexec On 01/05/18 at 10:38am, Dave Young wrote: > On 01/03/18 at 03:21pm, Dave Anderson wrote: > > > > > > ----- Original Message ----- > > > > > On 01/02/18 at 05:08pm, Baoquan He wrote: > > > > On 01/02/18 at 04:57pm, Dave Young wrote: > > > > > The root cause is this commit makes mem_section as a pointer instead of > > > > > the static array. > > > > > > > > > > VMCOREINFO_SYMBOL() expand it as &mem_section, this is not correct in > > > > > the test case any more. > > > > > > > > > > This hack code works for me: > > > > > > > > > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > > > > > index b3663896278e..f5fe6068ae39 100644 > > > > > --- a/kernel/crash_core.c > > > > > +++ b/kernel/crash_core.c > > > > > @@ -376,6 +376,8 @@ phys_addr_t __weak paddr_vmcoreinfo_note(void) > > > > > { > > > > > return __pa(vmcoreinfo_note); > > > > > } > > > > > +#define VMCOREINFO_SYMBOL_HACK(name) \ > > > > > + vmcoreinfo_append_str("SYMBOL(%s)=%lx\n", #name, (unsigned long)name) > > > > > > > > Oh, you made a new one. We may use vmcoreinfo_append_str directly since > > > > there's an existing one in crash_save_vmcoreinfo(): > > > > > > Yes, it should be something like this instead, this should ensure > > > makedumpfile maybe crash tool works without any modifications, > > > waiting for feedback from Atsushi, also ccing Dave for crash utility > > > potential issue. > > > > Yeah, I ran into that issue when testing 4.15, and fixed it upstream: > > > > https://github.com/crash-utility/crash/commit/264f22dafe9f37780c4113fd08e8d5b2138edbce > > > > commit 264f22dafe9f37780c4113fd08e8d5b2138edbce > > Author: Dave Anderson <anderson@redhat.com> > > Date: Wed Nov 29 15:28:41 2017 -0500 > > > > Fix for Linux 4.15 and later kernels that are configured with > > CONFIG_SPARSEMEM_EXTREME, and that contain kernel commit > > 83e3c48729d9ebb7af5a31a504f3fd6aff0348c4, titled "mm/sparsemem: > > Allocate mem_section at runtime for CONFIG_SPARSEMEM_EXTREME=y". > > Without the patch, kernels configured with SPARSEMEM_EXTREME > > have changed the data type of "mem_section" from an array to > > a pointer, leading to errors in commands such as "kmem -p", > > "kmem -n", "kmem -s", and any other command that translates a > > physical address to its page struct address. > > (anderson@redhat.com) > > > > Hi Dave, > > I tried latest crash tool, but segment fault happened, I put the > vmlinux/vmcore in below url, could you have a look?: > http://people.redhat.com/ruyang/rhbz1528542/127.0.0.1-2018-01-05-10:29:23/ > > --- > crash 7.2.0++ > Copyright (C) 2002-2017 Red Hat, Inc. > Copyright (C) 2004, 2005, 2006, 2010 IBM Corporation > Copyright (C) 1999-2006 Hewlett-Packard Co > Copyright (C) 2005, 2006, 2011, 2012 Fujitsu Limited > Copyright (C) 2006, 2007 VA Linux Systems Japan K.K. > Copyright (C) 2005, 2011 NEC Corporation > Copyright (C) 1999, 2002, 2007 Silicon Graphics, Inc. > Copyright (C) 1999, 2000, 2001, 2002 Mission Critical Linux, Inc. > This program is free software, covered by the GNU General Public License, > and you are welcome to change it and/or distribute copies of it under > certain conditions. Enter "help copying" to see the conditions. > This program has absolutely no warranty. Enter "help warranty" for details. > > GNU gdb (GDB) 7.6 > Copyright (C) 2013 Free Software Foundation, Inc. > License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> > This is free software: you are free to change and redistribute it. > There is NO WARRANTY, to the extent permitted by law. Type "show copying" > and "show warranty" for details. > This GDB was configured as "x86_64-unknown-linux-gnu"... > > WARNING: could not find MAGIC_START! > WARNING: kernel version inconsistency between vmlinux and dumpfile > > please wait... (gathering task table data) > WARNING: duplicate idle tasks? > > WARNING: duplicate idle tasks? > please wait... (determining panic task) > WARNING: active task ffffffff81e90536 on cpu 0 not found in PID hash > > [ 1156.567444] crash[2964]: segfault at 7175228 ip 00000000004bf39e sp 00007ffd5dce3f30 error 6 in crash[400000+6da000] > Segmentation fault (core dumped) > > The tested kernel applied below patch (a tuned patch according to bhe's > suggestion): > > --- > kernel/crash_core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > --- linux.orig/kernel/crash_core.c > +++ linux/kernel/crash_core.c > @@ -410,7 +410,8 @@ static int __init crash_save_vmcoreinfo_ > VMCOREINFO_SYMBOL(contig_page_data); > #endif > #ifdef CONFIG_SPARSEMEM > - VMCOREINFO_SYMBOL(mem_section); > + vmcoreinfo_append_str("SYMBOL(mem_section)=%lx\n", > + (unsigned long)mem_section); > VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); > VMCOREINFO_STRUCT_SIZE(mem_section); > VMCOREINFO_OFFSET(mem_section, section_mem_map); > > BTW, crash works fine with CONFIG_SPARSEMEM_EXTREME being disabled. _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: makedumpfile saving vmcore fails with dynamically allocated mem_section (was: Re: [PATCH] handle renamed init_level4_pgt -> init_top_pgt) 2018-01-05 2:38 ` Dave Young 2018-01-05 3:19 ` Dave Young @ 2018-01-05 14:16 ` Dave Anderson 2018-01-06 6:13 ` Dave Young 1 sibling, 1 reply; 22+ messages in thread From: Dave Anderson @ 2018-01-05 14:16 UTC (permalink / raw) To: Dave Young; +Cc: kexec ----- Original Message ----- > On 01/03/18 at 03:21pm, Dave Anderson wrote: > > > > > > ----- Original Message ----- > > > > > On 01/02/18 at 05:08pm, Baoquan He wrote: > > > > On 01/02/18 at 04:57pm, Dave Young wrote: > > > > > The root cause is this commit makes mem_section as a pointer instead > > > > > of > > > > > the static array. > > > > > > > > > > VMCOREINFO_SYMBOL() expand it as &mem_section, this is not correct in > > > > > the test case any more. > > > > > > > > > > This hack code works for me: > > > > > > > > > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > > > > > index b3663896278e..f5fe6068ae39 100644 > > > > > --- a/kernel/crash_core.c > > > > > +++ b/kernel/crash_core.c > > > > > @@ -376,6 +376,8 @@ phys_addr_t __weak paddr_vmcoreinfo_note(void) > > > > > { > > > > > return __pa(vmcoreinfo_note); > > > > > } > > > > > +#define VMCOREINFO_SYMBOL_HACK(name) \ > > > > > + vmcoreinfo_append_str("SYMBOL(%s)=%lx\n", #name, (unsigned > > > > > long)name) > > > > > > > > Oh, you made a new one. We may use vmcoreinfo_append_str directly since > > > > there's an existing one in crash_save_vmcoreinfo(): > > > > > > Yes, it should be something like this instead, this should ensure > > > makedumpfile maybe crash tool works without any modifications, > > > waiting for feedback from Atsushi, also ccing Dave for crash utility > > > potential issue. > > > > Yeah, I ran into that issue when testing 4.15, and fixed it upstream: > > > > https://github.com/crash-utility/crash/commit/264f22dafe9f37780c4113fd08e8d5b2138edbce > > > > commit 264f22dafe9f37780c4113fd08e8d5b2138edbce > > Author: Dave Anderson <anderson@redhat.com> > > Date: Wed Nov 29 15:28:41 2017 -0500 > > > > Fix for Linux 4.15 and later kernels that are configured with > > CONFIG_SPARSEMEM_EXTREME, and that contain kernel commit > > 83e3c48729d9ebb7af5a31a504f3fd6aff0348c4, titled "mm/sparsemem: > > Allocate mem_section at runtime for CONFIG_SPARSEMEM_EXTREME=y". > > Without the patch, kernels configured with SPARSEMEM_EXTREME > > have changed the data type of "mem_section" from an array to > > a pointer, leading to errors in commands such as "kmem -p", > > "kmem -n", "kmem -s", and any other command that translates a > > physical address to its page struct address. > > (anderson@redhat.com) > > > > Hi Dave, > > I tried latest crash tool, but segment fault happened, I put the > vmlinux/vmcore in below url, could you have a look?: > http://people.redhat.com/ruyang/rhbz1528542/127.0.0.1-2018-01-05-10:29:23/ I can't access them: Forbidden You don't have permission to access /ruyang/rhbz1528542/127.0.0.1-2018-01-05-10:29:23/vmcore on this server. Although, in the meantime, what should first be clarified is why this message occurred: WARNING: kernel version inconsistency between vmlinux and dumpfile If you run with at least "crash -d1", it will display the version strings from the vmlinux file and the dumpfile, and they should be identical. Dave > > --- > crash 7.2.0++ > Copyright (C) 2002-2017 Red Hat, Inc. > Copyright (C) 2004, 2005, 2006, 2010 IBM Corporation > Copyright (C) 1999-2006 Hewlett-Packard Co > Copyright (C) 2005, 2006, 2011, 2012 Fujitsu Limited > Copyright (C) 2006, 2007 VA Linux Systems Japan K.K. > Copyright (C) 2005, 2011 NEC Corporation > Copyright (C) 1999, 2002, 2007 Silicon Graphics, Inc. > Copyright (C) 1999, 2000, 2001, 2002 Mission Critical Linux, Inc. > This program is free software, covered by the GNU General Public License, > and you are welcome to change it and/or distribute copies of it under > certain conditions. Enter "help copying" to see the conditions. > This program has absolutely no warranty. Enter "help warranty" for details. > > GNU gdb (GDB) 7.6 > Copyright (C) 2013 Free Software Foundation, Inc. > License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> > This is free software: you are free to change and redistribute it. > There is NO WARRANTY, to the extent permitted by law. Type "show copying" > and "show warranty" for details. > This GDB was configured as "x86_64-unknown-linux-gnu"... > > WARNING: could not find MAGIC_START! > WARNING: kernel version inconsistency between vmlinux and dumpfile > > please wait... (gathering task table data) > WARNING: duplicate idle tasks? > > WARNING: duplicate idle tasks? > please wait... (determining panic task) > WARNING: active task ffffffff81e90536 on cpu 0 not found in PID hash > > [ 1156.567444] crash[2964]: segfault at 7175228 ip 00000000004bf39e sp > 00007ffd5dce3f30 error 6 in crash[400000+6da000] > Segmentation fault (core dumped) > > The tested kernel applied below patch (a tuned patch according to bhe's > suggestion): > > --- > kernel/crash_core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > --- linux.orig/kernel/crash_core.c > +++ linux/kernel/crash_core.c > @@ -410,7 +410,8 @@ static int __init crash_save_vmcoreinfo_ > VMCOREINFO_SYMBOL(contig_page_data); > #endif > #ifdef CONFIG_SPARSEMEM > - VMCOREINFO_SYMBOL(mem_section); > + vmcoreinfo_append_str("SYMBOL(mem_section)=%lx\n", > + (unsigned long)mem_section); > VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); > VMCOREINFO_STRUCT_SIZE(mem_section); > VMCOREINFO_OFFSET(mem_section, section_mem_map); > > > Thanks > Dave > _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: makedumpfile saving vmcore fails with dynamically allocated mem_section (was: Re: [PATCH] handle renamed init_level4_pgt -> init_top_pgt) 2018-01-05 14:16 ` Dave Anderson @ 2018-01-06 6:13 ` Dave Young 2018-01-06 16:06 ` Dave Anderson 0 siblings, 1 reply; 22+ messages in thread From: Dave Young @ 2018-01-06 6:13 UTC (permalink / raw) To: Dave Anderson; +Cc: kexec On 01/05/18 at 09:16am, Dave Anderson wrote: > > > ----- Original Message ----- > > On 01/03/18 at 03:21pm, Dave Anderson wrote: > > > > > > > > > ----- Original Message ----- > > > > > > > On 01/02/18 at 05:08pm, Baoquan He wrote: > > > > > On 01/02/18 at 04:57pm, Dave Young wrote: > > > > > > The root cause is this commit makes mem_section as a pointer instead > > > > > > of > > > > > > the static array. > > > > > > > > > > > > VMCOREINFO_SYMBOL() expand it as &mem_section, this is not correct in > > > > > > the test case any more. > > > > > > > > > > > > This hack code works for me: > > > > > > > > > > > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > > > > > > index b3663896278e..f5fe6068ae39 100644 > > > > > > --- a/kernel/crash_core.c > > > > > > +++ b/kernel/crash_core.c > > > > > > @@ -376,6 +376,8 @@ phys_addr_t __weak paddr_vmcoreinfo_note(void) > > > > > > { > > > > > > return __pa(vmcoreinfo_note); > > > > > > } > > > > > > +#define VMCOREINFO_SYMBOL_HACK(name) \ > > > > > > + vmcoreinfo_append_str("SYMBOL(%s)=%lx\n", #name, (unsigned > > > > > > long)name) > > > > > > > > > > Oh, you made a new one. We may use vmcoreinfo_append_str directly since > > > > > there's an existing one in crash_save_vmcoreinfo(): > > > > > > > > Yes, it should be something like this instead, this should ensure > > > > makedumpfile maybe crash tool works without any modifications, > > > > waiting for feedback from Atsushi, also ccing Dave for crash utility > > > > potential issue. > > > > > > Yeah, I ran into that issue when testing 4.15, and fixed it upstream: > > > > > > https://github.com/crash-utility/crash/commit/264f22dafe9f37780c4113fd08e8d5b2138edbce > > > > > > commit 264f22dafe9f37780c4113fd08e8d5b2138edbce > > > Author: Dave Anderson <anderson@redhat.com> > > > Date: Wed Nov 29 15:28:41 2017 -0500 > > > > > > Fix for Linux 4.15 and later kernels that are configured with > > > CONFIG_SPARSEMEM_EXTREME, and that contain kernel commit > > > 83e3c48729d9ebb7af5a31a504f3fd6aff0348c4, titled "mm/sparsemem: > > > Allocate mem_section at runtime for CONFIG_SPARSEMEM_EXTREME=y". > > > Without the patch, kernels configured with SPARSEMEM_EXTREME > > > have changed the data type of "mem_section" from an array to > > > a pointer, leading to errors in commands such as "kmem -p", > > > "kmem -n", "kmem -s", and any other command that translates a > > > physical address to its page struct address. > > > (anderson@redhat.com) > > > > > > > Hi Dave, > > > > I tried latest crash tool, but segment fault happened, I put the > > vmlinux/vmcore in below url, could you have a look?: > > http://people.redhat.com/ruyang/rhbz1528542/127.0.0.1-2018-01-05-10:29:23/ > > I can't access them: > > Forbidden > > You don't have permission to access /ruyang/rhbz1528542/127.0.0.1-2018-01-05-10:29:23/vmcore on this server. Oops, updated with chmod 666 > > Although, in the meantime, what should first be clarified is why this message occurred: > > WARNING: kernel version inconsistency between vmlinux and dumpfile > > If you run with at least "crash -d1", it will display the version strings from > the vmlinux file and the dumpfile, and they should be identical. Sorry about that, maybe I mistakenly use another build: dumpfile /proc/version: Linux version 4.15.0-rc6+ (dyoung@dhcp-128-65.nay.redhat.com) (gcc version 7.2.1 20170915 (Red Hat 7.2.1-4) (GCC)) #455 SMP Fri Jan 5 09:57:01 CST 2018 vmlinux: Linux version 4.15.0-rc6+ (dyoung@dhcp-128-65.nay.redhat.com) (gcc version 7.2.1 20170915 (Red Hat 7.2.1-4) (GCC)) #456 SMP Fri Jan 5 10:26:27 CST 2018 But should be some simple change over the vmcore_append_str as Baoquan's suggestions, maybe I used Fedora default crash tool, I'm not sure now :( Retest with a fresh build, crash works fine to me. Here are the new files: http://people.redhat.com/ruyang/rhbz1528542/127.0.0.1-2018-01-06-14:02:59/ > > Dave > > > > > > --- > > crash 7.2.0++ > > Copyright (C) 2002-2017 Red Hat, Inc. > > Copyright (C) 2004, 2005, 2006, 2010 IBM Corporation > > Copyright (C) 1999-2006 Hewlett-Packard Co > > Copyright (C) 2005, 2006, 2011, 2012 Fujitsu Limited > > Copyright (C) 2006, 2007 VA Linux Systems Japan K.K. > > Copyright (C) 2005, 2011 NEC Corporation > > Copyright (C) 1999, 2002, 2007 Silicon Graphics, Inc. > > Copyright (C) 1999, 2000, 2001, 2002 Mission Critical Linux, Inc. > > This program is free software, covered by the GNU General Public License, > > and you are welcome to change it and/or distribute copies of it under > > certain conditions. Enter "help copying" to see the conditions. > > This program has absolutely no warranty. Enter "help warranty" for details. > > > > GNU gdb (GDB) 7.6 > > Copyright (C) 2013 Free Software Foundation, Inc. > > License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> > > This is free software: you are free to change and redistribute it. > > There is NO WARRANTY, to the extent permitted by law. Type "show copying" > > and "show warranty" for details. > > This GDB was configured as "x86_64-unknown-linux-gnu"... > > > > WARNING: could not find MAGIC_START! > > WARNING: kernel version inconsistency between vmlinux and dumpfile > > > > please wait... (gathering task table data) > > WARNING: duplicate idle tasks? > > > > WARNING: duplicate idle tasks? > > please wait... (determining panic task) > > WARNING: active task ffffffff81e90536 on cpu 0 not found in PID hash > > > > [ 1156.567444] crash[2964]: segfault at 7175228 ip 00000000004bf39e sp > > 00007ffd5dce3f30 error 6 in crash[400000+6da000] > > Segmentation fault (core dumped) > > > > The tested kernel applied below patch (a tuned patch according to bhe's > > suggestion): > > > > --- > > kernel/crash_core.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > --- linux.orig/kernel/crash_core.c > > +++ linux/kernel/crash_core.c > > @@ -410,7 +410,8 @@ static int __init crash_save_vmcoreinfo_ > > VMCOREINFO_SYMBOL(contig_page_data); > > #endif > > #ifdef CONFIG_SPARSEMEM > > - VMCOREINFO_SYMBOL(mem_section); > > + vmcoreinfo_append_str("SYMBOL(mem_section)=%lx\n", > > + (unsigned long)mem_section); > > VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); > > VMCOREINFO_STRUCT_SIZE(mem_section); > > VMCOREINFO_OFFSET(mem_section, section_mem_map); > > > > > > Thanks > > Dave > > _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: makedumpfile saving vmcore fails with dynamically allocated mem_section (was: Re: [PATCH] handle renamed init_level4_pgt -> init_top_pgt) 2018-01-06 6:13 ` Dave Young @ 2018-01-06 16:06 ` Dave Anderson 2018-01-08 8:40 ` Dave Young 0 siblings, 1 reply; 22+ messages in thread From: Dave Anderson @ 2018-01-06 16:06 UTC (permalink / raw) To: Dave Young; +Cc: kexec ----- Original Message ----- > On 01/05/18 at 09:16am, Dave Anderson wrote: > > > > > > ----- Original Message ----- > > > On 01/03/18 at 03:21pm, Dave Anderson wrote: > > > > > > > > > > > > ----- Original Message ----- > > > > > > > > > On 01/02/18 at 05:08pm, Baoquan He wrote: > > > > > > On 01/02/18 at 04:57pm, Dave Young wrote: > > > > > > > The root cause is this commit makes mem_section as a pointer > > > > > > > instead > > > > > > > of > > > > > > > the static array. > > > > > > > > > > > > > > VMCOREINFO_SYMBOL() expand it as &mem_section, this is not > > > > > > > correct in > > > > > > > the test case any more. > > > > > > > > > > > > > > This hack code works for me: > > > > > > > > > > > > > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > > > > > > > index b3663896278e..f5fe6068ae39 100644 > > > > > > > --- a/kernel/crash_core.c > > > > > > > +++ b/kernel/crash_core.c > > > > > > > @@ -376,6 +376,8 @@ phys_addr_t __weak > > > > > > > paddr_vmcoreinfo_note(void) > > > > > > > { > > > > > > > return __pa(vmcoreinfo_note); > > > > > > > } > > > > > > > +#define VMCOREINFO_SYMBOL_HACK(name) \ > > > > > > > + vmcoreinfo_append_str("SYMBOL(%s)=%lx\n", #name, (unsigned > > > > > > > long)name) > > > > > > > > > > > > Oh, you made a new one. We may use vmcoreinfo_append_str directly > > > > > > since > > > > > > there's an existing one in crash_save_vmcoreinfo(): > > > > > > > > > > Yes, it should be something like this instead, this should ensure > > > > > makedumpfile maybe crash tool works without any modifications, > > > > > waiting for feedback from Atsushi, also ccing Dave for crash utility > > > > > potential issue. > > > > > > > > Yeah, I ran into that issue when testing 4.15, and fixed it upstream: > > > > > > > > https://github.com/crash-utility/crash/commit/264f22dafe9f37780c4113fd08e8d5b2138edbce > > > > > > > > commit 264f22dafe9f37780c4113fd08e8d5b2138edbce > > > > Author: Dave Anderson <anderson@redhat.com> > > > > Date: Wed Nov 29 15:28:41 2017 -0500 > > > > > > > > Fix for Linux 4.15 and later kernels that are configured with > > > > CONFIG_SPARSEMEM_EXTREME, and that contain kernel commit > > > > 83e3c48729d9ebb7af5a31a504f3fd6aff0348c4, titled "mm/sparsemem: > > > > Allocate mem_section at runtime for CONFIG_SPARSEMEM_EXTREME=y". > > > > Without the patch, kernels configured with SPARSEMEM_EXTREME > > > > have changed the data type of "mem_section" from an array to > > > > a pointer, leading to errors in commands such as "kmem -p", > > > > "kmem -n", "kmem -s", and any other command that translates a > > > > physical address to its page struct address. > > > > (anderson@redhat.com) > > > > > > > > > > Hi Dave, > > > > > > I tried latest crash tool, but segment fault happened, I put the > > > vmlinux/vmcore in below url, could you have a look?: > > > http://people.redhat.com/ruyang/rhbz1528542/127.0.0.1-2018-01-05-10:29:23/ > > > > I can't access them: > > > > Forbidden > > > > You don't have permission to access > > /ruyang/rhbz1528542/127.0.0.1-2018-01-05-10:29:23/vmcore on this server. > > Oops, updated with chmod 666 > > > > Although, in the meantime, what should first be clarified is why this > > message occurred: > > > > WARNING: kernel version inconsistency between vmlinux and dumpfile > > > > If you run with at least "crash -d1", it will display the version strings from > > the vmlinux file and the dumpfile, and they should be identical. > > Sorry about that, maybe I mistakenly use another build: > dumpfile /proc/version: > Linux version 4.15.0-rc6+ (dyoung@dhcp-128-65.nay.redhat.com) (gcc version > 7.2.1 20170915 (Red Hat 7.2.1-4) (GCC)) #455 SMP Fri Jan 5 09:57:01 CST 2018 > vmlinux: > Linux version 4.15.0-rc6+ (dyoung@dhcp-128-65.nay.redhat.com) (gcc version > 7.2.1 20170915 (Red Hat 7.2.1-4) (GCC)) #456 SMP Fri Jan 5 10:26:27 CST 2018 > > But should be some simple change over the vmcore_append_str as Baoquan's > suggestions, maybe I used Fedora default crash tool, I'm not sure now :( No it's not the crash utility version that's the problem, but rather the vmcore_append_str() addition, which would modify/increment the virtual addresses of all static data symbols that come after it. The crash utility doesn't stand a prayer of working when the data symbol values in the vmlinux do not match those in the vmcore. Dave > > Retest with a fresh build, crash works fine to me. Here are the new > files: > http://people.redhat.com/ruyang/rhbz1528542/127.0.0.1-2018-01-06-14:02:59/ > _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: makedumpfile saving vmcore fails with dynamically allocated mem_section (was: Re: [PATCH] handle renamed init_level4_pgt -> init_top_pgt) 2018-01-06 16:06 ` Dave Anderson @ 2018-01-08 8:40 ` Dave Young 0 siblings, 0 replies; 22+ messages in thread From: Dave Young @ 2018-01-08 8:40 UTC (permalink / raw) To: Dave Anderson; +Cc: kexec On 01/06/18 at 11:06am, Dave Anderson wrote: > > > ----- Original Message ----- > > On 01/05/18 at 09:16am, Dave Anderson wrote: > > > > > > > > > ----- Original Message ----- > > > > On 01/03/18 at 03:21pm, Dave Anderson wrote: > > > > > > > > > > > > > > > ----- Original Message ----- > > > > > > > > > > > On 01/02/18 at 05:08pm, Baoquan He wrote: > > > > > > > On 01/02/18 at 04:57pm, Dave Young wrote: > > > > > > > > The root cause is this commit makes mem_section as a pointer > > > > > > > > instead > > > > > > > > of > > > > > > > > the static array. > > > > > > > > > > > > > > > > VMCOREINFO_SYMBOL() expand it as &mem_section, this is not > > > > > > > > correct in > > > > > > > > the test case any more. > > > > > > > > > > > > > > > > This hack code works for me: > > > > > > > > > > > > > > > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > > > > > > > > index b3663896278e..f5fe6068ae39 100644 > > > > > > > > --- a/kernel/crash_core.c > > > > > > > > +++ b/kernel/crash_core.c > > > > > > > > @@ -376,6 +376,8 @@ phys_addr_t __weak > > > > > > > > paddr_vmcoreinfo_note(void) > > > > > > > > { > > > > > > > > return __pa(vmcoreinfo_note); > > > > > > > > } > > > > > > > > +#define VMCOREINFO_SYMBOL_HACK(name) \ > > > > > > > > + vmcoreinfo_append_str("SYMBOL(%s)=%lx\n", #name, (unsigned > > > > > > > > long)name) > > > > > > > > > > > > > > Oh, you made a new one. We may use vmcoreinfo_append_str directly > > > > > > > since > > > > > > > there's an existing one in crash_save_vmcoreinfo(): > > > > > > > > > > > > Yes, it should be something like this instead, this should ensure > > > > > > makedumpfile maybe crash tool works without any modifications, > > > > > > waiting for feedback from Atsushi, also ccing Dave for crash utility > > > > > > potential issue. > > > > > > > > > > Yeah, I ran into that issue when testing 4.15, and fixed it upstream: > > > > > > > > > > https://github.com/crash-utility/crash/commit/264f22dafe9f37780c4113fd08e8d5b2138edbce > > > > > > > > > > commit 264f22dafe9f37780c4113fd08e8d5b2138edbce > > > > > Author: Dave Anderson <anderson@redhat.com> > > > > > Date: Wed Nov 29 15:28:41 2017 -0500 > > > > > > > > > > Fix for Linux 4.15 and later kernels that are configured with > > > > > CONFIG_SPARSEMEM_EXTREME, and that contain kernel commit > > > > > 83e3c48729d9ebb7af5a31a504f3fd6aff0348c4, titled "mm/sparsemem: > > > > > Allocate mem_section at runtime for CONFIG_SPARSEMEM_EXTREME=y". > > > > > Without the patch, kernels configured with SPARSEMEM_EXTREME > > > > > have changed the data type of "mem_section" from an array to > > > > > a pointer, leading to errors in commands such as "kmem -p", > > > > > "kmem -n", "kmem -s", and any other command that translates a > > > > > physical address to its page struct address. > > > > > (anderson@redhat.com) > > > > > > > > > > > > > Hi Dave, > > > > > > > > I tried latest crash tool, but segment fault happened, I put the > > > > vmlinux/vmcore in below url, could you have a look?: > > > > http://people.redhat.com/ruyang/rhbz1528542/127.0.0.1-2018-01-05-10:29:23/ > > > > > > I can't access them: > > > > > > Forbidden > > > > > > You don't have permission to access > > > /ruyang/rhbz1528542/127.0.0.1-2018-01-05-10:29:23/vmcore on this server. > > > > Oops, updated with chmod 666 > > > > > > Although, in the meantime, what should first be clarified is why this > > > message occurred: > > > > > > WARNING: kernel version inconsistency between vmlinux and dumpfile > > > > > > If you run with at least "crash -d1", it will display the version strings from > > > the vmlinux file and the dumpfile, and they should be identical. > > > > Sorry about that, maybe I mistakenly use another build: > > dumpfile /proc/version: > > Linux version 4.15.0-rc6+ (dyoung@dhcp-128-65.nay.redhat.com) (gcc version > > 7.2.1 20170915 (Red Hat 7.2.1-4) (GCC)) #455 SMP Fri Jan 5 09:57:01 CST 2018 > > vmlinux: > > Linux version 4.15.0-rc6+ (dyoung@dhcp-128-65.nay.redhat.com) (gcc version > > 7.2.1 20170915 (Red Hat 7.2.1-4) (GCC)) #456 SMP Fri Jan 5 10:26:27 CST 2018 > > > > But should be some simple change over the vmcore_append_str as Baoquan's > > suggestions, maybe I used Fedora default crash tool, I'm not sure now :( > > No it's not the crash utility version that's the problem, but rather the > vmcore_append_str() addition, which would modify/increment the virtual > addresses of all static data symbols that come after it. The crash utility > doesn't stand a prayer of working when the data symbol values in the vmlinux > do not match those in the vmcore. Ok, thanks for the reply. If Atsushi can fix it in makedumpfile without kernel patch it would be ideal. > > Dave > > > > > > Retest with a fresh build, crash works fine to me. Here are the new > > files: > > http://people.redhat.com/ruyang/rhbz1528542/127.0.0.1-2018-01-06-14:02:59/ > > _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec ^ permalink raw reply [flat|nested] 22+ messages in thread
end of thread, other threads:[~2018-01-09 5:33 UTC | newest]
Thread overview: 22+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-07 10:20 [PATCH] handle renamed init_level4_pgt -> init_top_pgt Atsushi Kumagai
2017-12-08 8:15 ` Atsushi Kumagai
2017-12-20 7:24 ` Dave Young
2017-12-21 8:48 ` Atsushi Kumagai
2017-12-22 4:54 ` Dave Young
2017-12-22 5:48 ` Dave Young
2017-12-26 8:21 ` Atsushi Kumagai
2018-01-02 8:57 ` Dave Young
2018-01-02 9:08 ` Baoquan He
2018-01-03 2:30 ` makedumpfile saving vmcore fails with dynamically allocated mem_section (was: Re: [PATCH] handle renamed init_level4_pgt -> init_top_pgt) Dave Young
2018-01-03 2:38 ` Baoquan He
2018-01-05 8:19 ` Atsushi Kumagai
2018-01-06 5:36 ` Dave Young
2018-01-09 5:17 ` Atsushi Kumagai
2018-01-09 5:33 ` Dave Young
[not found] <mailman.7.1515009607.12089.kexec@lists.infradead.org>
2018-01-03 20:21 ` Dave Anderson
2018-01-05 2:38 ` Dave Young
2018-01-05 3:19 ` Dave Young
2018-01-05 14:16 ` Dave Anderson
2018-01-06 6:13 ` Dave Young
2018-01-06 16:06 ` Dave Anderson
2018-01-08 8:40 ` Dave Young
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).