From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.linuxfoundation.org ([140.211.169.12]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1f94sU-0000pM-0h for kexec@lists.infradead.org; Thu, 19 Apr 2018 08:25:15 +0000 Date: Thu, 19 Apr 2018 10:24:56 +0200 From: Greg KH Subject: Re: [PATCH net-next v4 1/3] vmcore: add API to collect hardware dump in second kernel Message-ID: <20180419082456.GA8617@kroah.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Rahul Lakkireddy Cc: indranil@chelsio.com, netdev@vger.kernel.org, nirranjan@chelsio.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, stephen@networkplumber.org, ganeshgr@chelsio.com, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org, torvalds@linux-foundation.org, davem@davemloft.net, ebiederm@xmission.com On Tue, Apr 17, 2018 at 01:14:17PM +0530, Rahul Lakkireddy wrote: > +config PROC_VMCORE_DEVICE_DUMP > + bool "Device Hardware/Firmware Log Collection" > + depends on PROC_VMCORE > + default y Only things that require the machine to keep working should be 'default y', please remove this, it's an option. > + help > + Device drivers can collect the device specific snapshot of > + their hardware or firmware before they are initialized in > + crash recovery kernel. If you say Y here, the device dumps > + will be added as ELF notes to /proc/vmcore Which exact "device drivers" are you referring to here? thanks, greg k-h _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec