From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fuoKs-0007V5-CV for kexec@lists.infradead.org; Wed, 29 Aug 2018 00:27:52 +0000 Received: by mail-pf1-x444.google.com with SMTP id i26-v6so1405146pfo.12 for ; Tue, 28 Aug 2018 17:27:39 -0700 (PDT) Date: Wed, 29 Aug 2018 09:28:00 +0900 From: AKASHI Takahiro Subject: Re: [PATCH v13 03/16] s390, kexec_file: drop arch_kexec_mem_walk() Message-ID: <20180829002759.GG12252@linaro.org> References: <20180801075820.3753-1-takahiro.akashi@linaro.org> <20180801075820.3753-4-takahiro.akashi@linaro.org> <20180801102951.527cfc57@ThinkPad> <20180802000150.GN11258@linaro.org> <20180806055047.GC4246@dhcp-128-65.nay.redhat.com> <20180809033416.GA5069@dhcp-128-65.nay.redhat.com> <1235507889.17337085.1533788045597.JavaMail.zimbra@redhat.com> <20180828052107.GE12252@linaro.org> <20180828134347.GB12178@dhcp-128-65.nay.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180828134347.GB12178@dhcp-128-65.nay.redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Dave Young Cc: dhowells@redhat.com, herbert@gondor.apana.org.au, Pingfan Liu , ard biesheuvel , catalin marinas , bhsharma@redhat.com, will deacon , linux-kernel@vger.kernel.org, heiko carstens , Philipp Rudo , "piliu@redhat.com Thiago Jung Bauermann" , bhe@redhat.com, arnd@arndb.de, linux-arm-kernel@lists.infradead.org, kexec@lists.infradead.org, schwidefsky@de.ibm.com, james morse , davem@davemloft.net, vgoyal@redhat.com On Tue, Aug 28, 2018 at 09:43:47PM +0800, Dave Young wrote: > Hi AKASHI, > On 08/28/18 at 02:21pm, AKASHI Takahiro wrote: > > Hi Dave, > > > > On Thu, Aug 09, 2018 at 12:14:05AM -0400, Pingfan Liu wrote: > > > > > > > > > > > > > > > ----- Original Message ----- > > > > From: "Dave Young" > > > > To: "AKASHI Takahiro" , "Philipp Rudo" , "catalin marinas" > > > > , "will deacon" , dhowells@redhat.com, vgoyal@redhat.com, > > > > herbert@gondor.apana.org.au, davem@davemloft.net, bhe@redhat.com, arnd@arndb.de, schwidefsky@de.ibm.com, "heiko > > > > carstens" , "ard biesheuvel" , "james morse" > > > > , bhsharma@redhat.com, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, > > > > linux-kernel@vger.kernel.org, "piliu@redhat.com Thiago Jung Bauermann" > > > > Sent: Thursday, August 9, 2018 11:34:16 AM > > > > Subject: Re: [PATCH v13 03/16] s390, kexec_file: drop arch_kexec_mem_walk() > > > > > > > > Add more cc. Pingfan Liu confirmed ppc does not use 0 as valid address, > > > > if so it should be safe. > > > > > > > > Pingfan, can you add more words? > > > > > > > > > > ppc64 uses a few KB starting from 0 for exception handler. > > > > It assures that 0 (zero) is valid, but won't be assigned as a result of > > kexec_add_buffer(). > > > > So do you think that yet I should submit another patch set, introducing > > explicit KEXEC_BUF_MEM_UNKNOWN, while assuming 0 by default is safe for now? > > > > Now that this is the only comment against my v13, it's up to you. > > I'm fine with your proposal. It is simple enough, and we can look into > it when it becomes a problem in the future which is unlikely. Ok, thank you for this confirmation. -Takahiro AKASHI > Thanks > Dave _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec