From: Dave Young <dyoung@redhat.com>
To: lijiang <lijiang@redhat.com>
Cc: thomas.lendacky@amd.com, brijesh.singh@amd.com,
Baoquan He <bhe@redhat.com>,
tiwai@suse.de, x86@kernel.org, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org, mingo@redhat.com,
baiyaowei@cmss.chinamobile.com, hpa@zytor.com,
bhelgaas@google.com, tglx@linutronix.de,
Borislav Petkov <bp@suse.de>,
akpm@linux-foundation.org, dan.j.williams@intel.com
Subject: Re: [PATCH 1/3 v2] resource: fix an error which walks through iomem resources
Date: Thu, 20 Sep 2018 14:59:35 +0800 [thread overview]
Message-ID: <20180920065935.GA11980@dhcp-128-65.nay.redhat.com> (raw)
In-Reply-To: <32409e2a-533b-c317-5519-26e0993cd30e@redhat.com>
On 09/20/18 at 02:39pm, lijiang wrote:
> 在 2018年09月19日 21:29, Borislav Petkov 写道:
> > On Wed, Sep 19, 2018 at 08:52:49PM +0800, Lianbo Jiang wrote:
> >
> > ...
> >
> >> In fact, we should get the resource A and B when we walk through the
> >> whole tree, but it only gets the resource A, the resource B is missed.
> >>
> >> Signed-off-by: Dave Young <dyoung@redhat.com>
> >> Signed-off-by: Lianbo Jiang <lijiang@redhat.com>
> >
> > Before looking at this: the SOB chain of all three patches is wrong.
> > Hint: see section 12) in Documentation/process/submitting-patches.rst
> >
> Thanks for your advice, Borislav.
>
> I have discussed with Dave Young, and he suggested that i might add a Suggested-by
patch 2 and patch 3 are based on my draft patch, but since you did debugging
and changes you can move my SOB to Suggested-by for patch 2 and patch 3,
for patch 1 please just drop my SOB and leave yours only.
> tag instead of Signed-off-by tag for him. What do you think about?
>
> I will modify the invalid SOB chain and post it again.
>
Thanks
Dave
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2018-09-20 6:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 12:52 [PATCH 0/3 v2] add reserved e820 ranges to the kdump kernel e820 table Lianbo Jiang
2018-09-19 12:52 ` [PATCH 1/3 v2] resource: fix an error which walks through iomem resources Lianbo Jiang
2018-09-19 13:29 ` Borislav Petkov
2018-09-20 6:39 ` lijiang
2018-09-20 6:59 ` Dave Young [this message]
2018-09-19 12:52 ` [PATCH 2/3 v2] x86/kexec_file: add e820 entry in case e820 type string matches to io resource name Lianbo Jiang
2018-09-19 12:52 ` [PATCH 3/3 v2] x86/kexec_file: add reserved e820 ranges to kdump kernel e820 table Lianbo Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180920065935.GA11980@dhcp-128-65.nay.redhat.com \
--to=dyoung@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=baiyaowei@cmss.chinamobile.com \
--cc=bhe@redhat.com \
--cc=bhelgaas@google.com \
--cc=bp@suse.de \
--cc=brijesh.singh@amd.com \
--cc=dan.j.williams@intel.com \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=lijiang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tiwai@suse.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox